URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
Thank you for the testing and the review, I hope I addressed all comments.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288486811
Hi all,
So I have 2 Centos7 hosts, with same sssd and nsswitch configs.
One does find the users in IPA, and the other doesn't.
Looks like the Data Provider is offline.
I sent the SIGUSR2 signal to sssd which is supposed to bring him online.
Didn't help.
The hosts can resolve the IPA server
URL: https://github.com/SSSD/sssd/pull/203
Title: #203: IPA: Enhance debug logging for ipa s2n operations
justin-stephenson commented:
"""
Thank you Sumit and Lukas for the review, changes made as requested.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/203
Author: justin-stephenson
Title: #203: IPA: Enhance debug logging for ipa s2n operations
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/203/head:pr203
git checkout pr203
URL: https://github.com/SSSD/sssd/pull/207
Author: sumit-bose
Title: #207: nss-idmap: add sss_nss_getlistbycert()
Action: opened
PR body:
"""
This patch adds a getlistbycert() call to libsss_nss_idmap to make it on
par with InfoPipe.
Related to https://pagure.io/SSSD/sssd/issue/3050
The
URL: https://github.com/SSSD/sssd/pull/205
Title: #205: MAN: Mention sssd-secrets in "SEE ALSO" section
lslebodn commented:
"""
master:
* 3c071c4d6ec0d8f798eb862ebc4584123ff44663
sssd-1-14:
* 9d24fcb1ea1197f5bde2c5953e36df25db047da2
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/205
Author: lslebodn
Title: #205: MAN: Mention sssd-secrets in "SEE ALSO" section
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/205/head:pr205
git checkout pr205
URL: https://github.com/SSSD/sssd/pull/205
Title: #205: MAN: Mention sssd-secrets in "SEE ALSO" section
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Some nitpicks mostly regarding the lack of DEBUG messages.
src/responder/kcm/kcmsrv_cmd.c
164 /* First 16 bits are 8 bit major and 8bit major protocol version */
URL: https://github.com/SSSD/sssd/pull/206
Title: #206: IFP: Fix of names in GetUserGroups method
celestian commented:
"""
How to test:
We need setup sssd as client of FreeIPA server with AD trust. And we need add
user from AD domain to FreeIPA group (ask me if you need help).
```
# Reset
URL: https://github.com/SSSD/sssd/pull/206
Author: celestian
Title: #206: IFP: Fix of names in GetUserGroups method
Action: opened
PR body:
"""
This patch adds code which chooses the right domain for
creation of output group's name.
"""
To pull the PR as Git branch:
git remote add ghsssd
URL: https://github.com/SSSD/sssd/pull/136
Title: #136: Tlog integration WIP
spbnick commented:
"""
One thing bothering me is that `dp_req_initgr_pp` doesn't seem well suited for
what we're doing. I.e. nothing cares if it fails. Can we do something about it?
Change the interface, put that
URL: https://github.com/SSSD/sssd/pull/136
Title: #136: Tlog integration WIP
spbnick commented:
"""
I've pushed a draft rewrite using cache_req and data provider. The
functionality is very basic and is mostly a proof-of-concept with no intent to
be efficient.
For each entry returned for a
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Other then that it LGTM and what I tried worked for me.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288409819
___
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Other than that it LGTM and what I tried worked for me.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288409819
___
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
mzidek-rh commented:
"""
Some nitpicks mostly regarding the lack of DEBUG messages.
src/responder/kcm/kcmsrv_cmd.c
164 /* First 16 bits are 8 bit major and 8bit major protocol version */
URL: https://github.com/SSSD/sssd/pull/136
Author: spbnick
Title: #136: Tlog integration WIP
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/136/head:pr136
git checkout pr136
From
URL: https://github.com/SSSD/sssd/pull/203
Title: #203: IPA: Enhance debug logging for ipa s2n operations
sumit-bose commented:
"""
Besides the review comments the patch looks good and is working as expected.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client
lslebodn commented:
"""
On (22/03/17 03:08), Jakub Hrozek wrote:
>I'm fine with adding this form to master now and asking for feedback in
>downstream as long as we agree that the functionality must be part of
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
pbrezina commented:
"""
On 03/22/2017 10:09 AM, Jakub Hrozek wrote:
> Looks like the curl version on RHEL-7 is too old to support some features:
>
>
URL: https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
sumit-bose commented:
"""
Thank you for the review, the new versions also contains a fix for the default
matching rule which we discussed on irc.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/187
Title: #187: Add support to lookup for users/groups in subdomains just by the
user shortname
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client
jhrozek commented:
"""
I'm fine with adding this form to master now and asking for feedback in
downstream as long as we agree that the functionality must be part of sssctl
before the next upstream release (similar
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
About the missing Content-Lenght, did you check with @tiran if this is a bug in
Custodia?
Finally, I'm conflicted if we need to allow the options to disable peer
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/65/17/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/197#issuecomment-288347513
___
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
I think you need to make libcurl detection not optional, but required if sssd
is build with sssd-secrets to avoid errors like:
```
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
Looks like the CI tests fail even on fedora..:
```
=== FAILURES ===
URL: https://github.com/SSSD/sssd/pull/198
Title: #198: secrets: support https in proxy provider
jhrozek commented:
"""
Looks like the curl version on RHEL-7 is too old to support some features:
```
/var/lib/jenkins/workspace/ci/label/rhel7/src/util/tev_curl.c: In function
'curl_code2errno':
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I also removed the declaration of sss_krb5_marshal_creds which was a leftover
from parsing the creds (which is something I have in a different branch until
we need to renew credentials..)
"""
See the
URL: https://github.com/SSSD/sssd/pull/197
Title: #197: KCM responder
jhrozek commented:
"""
I made two fixes related to documentation and packaging. They are already
squashed, but to ease the review, the documentation fix was:
```
diff --git a/src/man/sssd-kcm.8.xml b/src/man/sssd-kcm.8.xml
34 matches
Mail list logo
