URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
simo5 commented:
"""
So I can't really comment inline because there are too many lines in the patch
but I grepped throught the code:
I see:
+ void sss_talloc_abort(const char reas
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
simo5 commented:
"""
Please also do not commit as root, but use a proper user/email setting, and if
you can add the signed-off-by header.
"""
See the full comment at
https://git
On Wed, 2017-04-05 at 21:02 +0200, Jakub Hrozek wrote:
> On Tue, Nov 22, 2016 at 08:51:10AM +0100, Jakub Hrozek wrote:
> > Hi,
> >
> > I was working on a KCM server for SSSD for some time already in parallel
> > with the files provider and had some discussions with Simo as well. Of
> > course my i
URL: https://github.com/SSSD/sssd/pull/196
Author: mzidek-rh
Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/196/head:pr196
git checkout pr196
URL: https://github.com/SSSD/sssd/pull/196
Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing
lslebodn commented:
"""
master:
* 955574eeb3a3b937abc3df150e979b75c889
sssd-1-14:
* b35d7aa90b18ba544ba11fcabeb9662e38fb91fa
"""
See the full comment at
https://github.com/S
URL: https://github.com/SSSD/sssd/pull/196
Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.f
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
fidencio commented:
"""
@amitkumar50:
So, I didn't go through your patches but I've noticed that you added a bunch of
files that are not part of our tree (and shouldn't be).
I'm
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
lslebodn commented:
"""
@amitkumar50 could you rebase patches on top of git master?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/231#issuecomment-292961182
_
URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client
lslebodn commented:
"""
master:
* dbeae483464e42238a84c6a5b8c3c4f5312ae643
* 4a9160e2b3b9c531e2b4a7884f49bfbb4a07a992
* 9be97c9cc69e5e6e568d7e21f61a46c3ae2dc387
* 40ff10d73063949ca699670ca212e96b809d5fcd
* 435b3678de
URL: https://github.com/SSSD/sssd/pull/200
Author: sumit-bose
Title: #200: Improve PAM test client
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/200/head:pr200
git checkout pr200
___
URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/231#issuecomment-292950202
___
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/231#issuecomment-292950199
___
URL: https://github.com/SSSD/sssd/pull/227
Author: lslebodn
Title: #227: CONFDB: Fix handling of enable_files_domain
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/227/head:pr227
git checkout pr227
_
URL: https://github.com/SSSD/sssd/pull/227
Title: #227: CONFDB: Fix handling of enable_files_domain
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/227
Title: #227: CONFDB: Fix handling of enable_files_domain
lslebodn commented:
"""
master:
* 3509bb03ecef49264820c9e287e8b2c7e0a8a508
"""
See the full comment at
https://github.com/SSSD/sssd/pull/227#issuecomment-292938580
__
URL: https://github.com/SSSD/sssd/pull/200
Title: #200: Improve PAM test client
pbrezina commented:
"""
Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/200#issuecomment-292923387
___
sssd-devel mailing list -- sssd-devel@lists.fedo
18 matches
Mail list logo