[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-26 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier justin-stephenson commented: """ I think the patch from **PR 242** is okay. This patch is inside the very large `ipa_s2n_save_objects` function containing a case statement

[SSSD] [sssd PR#249][comment] DP: Reduce Data Provider log level noise

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/249 Title: #249: DP: Reduce Data Provider log level noise jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-297544662 ___ sssd-devel mailing list --

[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier jhrozek commented: """ By the way is the first patch where we added this message OK or does it need the same treatment as well? """ See the full comment at https://github

[SSSD] [sssd PR#249][comment] DP: Reduce Data Provider log level noise

2017-04-26 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/249 Title: #249: DP: Reduce Data Provider log level noise centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-297539057 __

[SSSD] [sssd PR#249][opened] DP: Reduce Data Provider log level noise

2017-04-26 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/249 Author: justin-stephenson Title: #249: DP: Reduce Data Provider log level noise Action: opened PR body: """ Certain operations are not supported with certain providers causing informational Data Provider log messages to be logged as errors or failure

[SSSD] [sssd PR#249][comment] DP: Reduce Data Provider log level noise

2017-04-26 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/249 Title: #249: DP: Reduce Data Provider log level noise centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-297539055 __

[SSSD] [sssd PR#243][closed] IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/243 Author: jhrozek Title: #243: IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/243/h

[SSSD] [sssd PR#243][-Accepted] IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/243 Title: #243: IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe

[SSSD] [sssd PR#243][+Pushed] IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/243 Title: #243: IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe se

[SSSD] [sssd PR#243][comment] IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/243 Title: #243: IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure jhrozek commented: """ * master: * 337dd8a87cd774ac20d15c16ec3d9a6c4d2defc7 * 53e9a5aef4a688f7c81a4a1e77013e05313e5f9a """ See the full co

[SSSD] [sssd PR#235][+Pushed] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send a

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side jhrozek commented: """ * b78febe4c579f86f8007a27599605d1eb9f97a62 * 213048fd9a5e800deb74cb5b7f0eaf465945c640 * f9bac02756aa05cc9c6ac07ae581dba672

[SSSD] [sssd PR#235][closed] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/235 Author: fidencio Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/235/head

[SSSD] [sssd PR#235][-Accepted] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Wed, Apr 26, 2017 at 6:34 PM, Fabiano Fidêncio wrote: > > > On Wed, Apr 26, 2017 at 11:34 AM, Pavel Březina > wrote: > >> >>- >> >>*NSS: Us

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Wed, Apr 26, 2017 at 11:34 AM, Pavel Březina wrote: > >- > >*NSS: Use fqnames when performing a ncache check* >This should be done in th

[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-26 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier justin-stephenson commented: """ Thank you for the review, patch updated. """ See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297458904

[SSSD] [sssd PR#248][synchronized] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-26 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/248 Author: justin-stephenson Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/248/head:pr248 git ch

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side fidencio commented: """ Added the "Accepted" label according to @pbrezina's ACK, """ See the full comment at https://github.com/SSSD/sssd/pull/

[SSSD] [sssd PR#235][+Accepted] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#136][comment] Tlog integration

2017-04-26 Thread spbnick
URL: https://github.com/SSSD/sssd/pull/136 Title: #136: Tlog integration spbnick commented: """ Alright, I'll work on the manpages as well. Another thing: should we also make a configure option for enabling session recording, so that we can have this enabled and have an RPM dependency in Fedo

[SSSD] [sssd PR#246][+Changes requested] filter_users and filter_groups stop working properly in v 1.15

2017-04-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 fidencio commented: """ On Wed, Apr 26, 2017 at 11:34 AM, Pavel Březina wrote: > >- > >*NSS: Use fqnames when performing a ncache check* >This should be done in th

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ * **NSS: Use fqnames when performing a ncache check** This should be done in the ncache module, not in the callers. * **RESPONDER: Make nss_get_name_fro

[SSSD] [sssd PR#246][comment] filter_users and filter_groups stop working properly in v 1.15

2017-04-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/246 Title: #246: filter_users and filter_groups stop working properly in v 1.15 pbrezina commented: """ * **NSS: Use fqnames when performing a ncache check** This should be done in the ncache module, not in the callers. * **RESPONDER: Make nss_get_name_fro

[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier pbrezina commented: """ Using just local variable `name` seems to be a better idea, but please check if it is always initialized. """ See the full comment at https://gith

[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier pbrezina commented: """ Nack. `attrs->a.name` is set only when `attrs->response_type == RESP_NAME` which is not always true here. """ See the full comment at https://gith

[SSSD] [sssd PR#248][comment] IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier

2017-04-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/248 Title: #248: IPA: Improve s2n debug message for missing ipaNTSecurityIdentifier pbrezina commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/248#issuecomment-297310590 ___

[SSSD] [sssd PR#136][comment] Tlog integration

2017-04-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/136 Title: #136: Tlog integration pbrezina commented: """ Yes, that is a good idea. And although the configuration itself is rather simple, it may be a good thing to also create sssd-tlog or sssd-session-recording manpage with few paragraphs describing th

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-26 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side pbrezina commented: """ Ack. Thank you for your patience. """ See the full comment at https://github.com/SSSD/sssd/pull/235#issuecomment-297304

[SSSD] [sssd PR#246][synchronized] filter_users and filter_groups stop working properly in v 1.15

2017-04-26 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/246 Author: fidencio Title: #246: filter_users and filter_groups stop working properly in v 1.15 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/246/head:pr246 git checkout pr246