[SSSD] [sssd PR#285][comment] SSSCTL: Add primary or subdomain information

2017-06-06 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information justin-stephenson commented: """ @mzidek-rh not a problem, I agree it makes more sense to use the terminology 'trusted domain' to avoid confusion. I updated the PR to fix the description and co

[SSSD] [sssd PR#285][synchronized] SSSCTL: Add primary or subdomain information

2017-06-06 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/285 Author: justin-stephenson Title: #285: SSSCTL: Add primary or subdomain information Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/285/head:pr285 git checkout pr285 From 4d5d

[SSSD] [sssd PR#285][comment] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information mzidek-rh commented: """ Also please change the sentence in the --verbose description: "Show domain list including primary or subdomain type" to "Show domain list including primary or trusted

[SSSD] [sssd PR#285][+Changes requested] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#285][comment] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information mzidek-rh commented: """ Sorry to jump late to the conversation, but I want to request one change to the patch. We should really not use the word "subdomain" in any user facing information. Th

[SSSD] [sssd PR#285][comment] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information mzidek-rh commented: """ Sorry to jump late to the conversation, but I want to request one change to the patch. We should really not use the word "subdomain" in any user facing information. Th

[SSSD] [sssd PR#285][comment] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information mzidek-rh commented: """ Sorry to jump late to the conversation, but I want to request one change to the patch. We should really not use the word "subdomain" in any user facing information. Th

[SSSD] [sssd PR#285][-Accepted] SSSCTL: Add primary or subdomain information

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/285 Title: #285: SSSCTL: Add primary or subdomain information Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o

[SSSD] [sssd PR#260][comment] Update sss_override.c

2017-06-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/260 Title: #260: Update sss_override.c fidencio commented: """ Amit, Sorry for the long time taken for reviewing this patch. I didn't go through the code but I still can see some functional issues with your patches. (same one mentioned in the [in the com

[SSSD] [sssd PR#247][comment] Subdomain inherit

2017-06-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit mzidek-rh commented: """ @lslebodn the downstream bugs were moved to later milestone, but we still need to do it... unfortunately something with higher priority always pops up... I hope to get back to this before next we

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-06-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section fidencio commented: """ I'm adding the "Changes Requested" label per [@lslebodn's comment](https://github.com/SSSD/sssd/pull/295#discussion_r119560316).

[SSSD] [sssd PR#295][+Changes requested] MAN: Document that the secrets provider can only be specified in a per-client section

2017-06-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe sen

[SSSD] [sssd PR#260][comment] Update sss_override.c

2017-06-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/260 Title: #260: Update sss_override.c fidencio commented: """ Amit, Sorry for the long time taken for reviewing this patch. I didn't go through the code but I still can see some functional issues with your patches. (same one mentioned in the [in the com

[SSSD] [sssd PR#260][+Changes requested] Update sss_override.c

2017-06-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/260 Title: #260: Update sss_override.c Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#260][comment] Update sss_override.c

2017-06-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/260 Title: #260: Update sss_override.c fidencio commented: """ Amit, Sorry for the long time taken for reviewing this patch. I didn't go through the code but I still can see some functional issues with your patches. (same one mentioned in the [in the com