[SSSD] [sssd PR#274][comment] Merge sss_cache and sss_debuglevel into sssctl

2017-07-28 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/274 Title: #274: Merge sss_cache and sss_debuglevel into sssctl justin-stephenson commented: """ Patches updated, I believe the Makefile changes are done as Michal proposed but please let me know if anything needs correcting. """ See the full comment at

[SSSD] [sssd PR#274][synchronized] Merge sss_cache and sss_debuglevel into sssctl

2017-07-28 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/274 Author: justin-stephenson Title: #274: Merge sss_cache and sss_debuglevel into sssctl Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/274/head:pr274 git checkout pr274 From 3b

[SSSD] [sssd PR#237][synchronized] providers: Move hostid from ipa to sdap

2017-07-28 Thread hvenev
URL: https://github.com/SSSD/sssd/pull/237 Author: hvenev Title: #237: providers: Move hostid from ipa to sdap Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/237/head:pr237 git checkout pr237 _

[SSSD] [sssd PR#237][closed] providers: Move hostid from ipa to sdap

2017-07-28 Thread hvenev
URL: https://github.com/SSSD/sssd/pull/237 Author: hvenev Title: #237: providers: Move hostid from ipa to sdap Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/237/head:pr237 git checkout pr237 ___

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-07-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled lslebodn commented: """ > Patch looks good to me and also addresses @lslebodn's comment. Maybe partially. I am still not persuaded that it is the best solution for ticket https:/

[SSSD] [sssd PR#334][+Changes requested] Print a warning when enumeration is requested but disabled

2017-07-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le.

[SSSD] [sssd PR#334][-Accepted] Print a warning when enumeration is requested but disabled

2017-07-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-07-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled lslebodn commented: """ > Patch looks good to me and also addresses @lslebodn's comment. Maybe partially. I am still not persuaded that it is the best solution for ticket https:/

[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ Adding the "Changes Requested". """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-318753252 _

[SSSD] [sssd PR#334][+Accepted] Print a warning when enumeration is requested but disabled

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled fidencio commented: """ Patch looks good to me and also addresses @lslebodn's comment. ACK! """ See the full comment at https://github.com/SSSD/sssd/pull/334#issuecomment-31875125

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master fidencio commented: """ Actually, I'd like to hear from a more experienced developer the concept of a `ghost` object. The error reported by @celestian happens because ldb_msg_find_element(group, SYSDB_GH

[SSSD] [sssd PR#189][closed] SELINUX: Use getseuserbyname to get IPA seuser

2017-07-28 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/189 Author: justin-stephenson Title: #189: SELINUX: Use getseuserbyname to get IPA seuser Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/189/head:pr189 git checkout pr189 _

[SSSD] [sssd PR#189][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-07-28 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/189 Title: #189: SELINUX: Use getseuserbyname to get IPA seuser justin-stephenson commented: """ @fidencio I don't really know if this ticket is required anymore to be honest, it may not be required after https://pagure.io/SSSD/sssd/issue/3297 was fixed.

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-07-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master lslebodn commented: """ On (28/07/17 16:45), fidencio wrote: >Okay. I was able to reproduce the issue described in the bug report and the >patch does fix the issue. >However, I do not think the fix is corr

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master fidencio commented: """ Okay. I was able to reproduce the issue described in the bug report and the patch does fix the issue. However, I do not think the fix is correct as it's not done in the right part

[SSSD] [sssd PR#214][comment] UTIL: Set udp_preference_limit=0 in krb5 snippet

2017-07-28 Thread frozencemetery
URL: https://github.com/SSSD/sssd/pull/214 Title: #214: UTIL: Set udp_preference_limit=0 in krb5 snippet frozencemetery commented: """ @fidencio I don't know the codebase well enough to give ack, sorry (just to complain about krb5 bits 😄). """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder amitkumar50 commented: """ @fidencio Done changes .. """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-318623610

[SSSD] [sssd PR#333][synchronized] Move header files consumed by both server and client to special folder

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/333 Author: amitkumar50 Title: #333: Move header files consumed by both server and client to special folder Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/333/head:pr333 git che

[SSSD] [sssd PR#334][-Changes requested] Print a warning when enumeration is requested but disabled

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le.

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ @fidencio Done """ See the full comment at https://github.com/SSSD/sssd/pull/334#issuecomment-318613367 ___

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334 F

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled fidencio commented: """ @amitkumar50, please, mind the indentation. I've mentioned that in a few other reviews, already. Seems to me you're using tabs for indentation while we do

[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ @amitkumar50, please, do not merge the branches. Just rebase your patches on top of git master. The workflow that I follow is: - fork the SSSD'

[SSSD] [sssd PR#333][synchronized] Move header files consumed by both server and client to special folder

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/333 Author: amitkumar50 Title: #333: Move header files consumed by both server and client to special folder Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/333/head:pr333 git che

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ @fidencio Changes Done.. Thanks for Comments!! """ See the full comment at https://github.com/SSSD/sssd/pull/334#issuecomment-318596965

[SSSD] [sssd PR#237][comment] providers: Move hostid from ipa to sdap

2017-07-28 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/237 Title: #237: providers: Move hostid from ipa to sdap lslebodn commented: """ @fidencio tests very likely will not pass due to expired certificates in unit test. Which was fixed in 2ccfa9502abf52941d8b6e44b5f7cfdd13311a2d. Patches would need to rebased

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334 F

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ > "Please, note that when enumeration is disabled getent passwd does not > return all users by design. See sssd.conf man page for more detailed > infor

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-07-28 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334 F

[SSSD] [sssd PR#237][comment] providers: Move hostid from ipa to sdap

2017-07-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/237 Title: #237: providers: Move hostid from ipa to sdap fidencio commented: """ @hvenev. sorry, the "retest this, please" is a command that will trigger our CI to retest the patch set. :-) """ See the full comment at https://github.com/SSSD/sssd/pull/23