[SSSD] debugging adcli info - short name not returned

2017-08-01 Thread smfrench
In one of our test domains, we noticed that the short name of the domain was not being returned by "adcli info" (it is visible in the output of "net rpc info" though and it is clearly configured in Windows and can be seen in the GUI and CLI of Windows). Running "adcli info --verbose" we see onl

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration jhrozek commented: """ I think the error condition is not really as much of a code issue as a user-friendliness issue. Admins of older IPA servers would suddendly see an odd message saying that something failed.

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration fidencio commented: """ @jhrozek, about the issue when connecting to old server that has no support for the desktop profiles ... In that case we'd always get a reply could as 0. Would be okay, for you, to just

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-08-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master mzidek-rh commented: """ ACK. I was able to reproduce the bug following the instructions provided above and the patch does fix it. CI passed. """ See the full comment at https://github.com/SSSD/sssd/pul

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-08-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master mzidek-rh commented: """ ACK. I was able to reproduce the bug following the instructions provided above and the patch does fix it. CI: http://vm-058-233.abc.idm.lab.eng.brq.redhat.com/logs/job/72/58/summa

[SSSD] [sssd PR#202][+Accepted] T3315 infopipe group users master

2017-08-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#343][synchronized] INTG: Add --with-session-recording=false to intgcheck's configure

2017-08-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/343 Author: fidencio Title: #343: INTG: Add --with-session-recording=false to intgcheck's configure Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/343/head:pr343 git checkout pr3

[SSSD] [sssd PR#343][comment] INTG: Add --with-session-recording=false to intgcheck's configure

2017-08-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/343 Title: #343: INTG: Add --with-session-recording=false to intgcheck's configure fidencio commented: """ @lslebodn, thanks for the comment. I've updated the patch in order to include your suggestion. """ See the full comment at https://github.com/SSSD/

[SSSD] [sssd PR#343][-Changes requested] INTG: Add --with-session-recording=false to intgcheck's configure

2017-08-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/343 Title: #343: INTG: Add --with-session-recording=false to intgcheck's configure Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-de

[SSSD] [sssd PR#343][synchronized] INTG: Add --with-session-recording=false to intgcheck's configure

2017-08-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/343 Author: fidencio Title: #343: INTG: Add --with-session-recording=false to intgcheck's configure Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/343/head:pr343 git checkout pr3

[SSSD] [sssd PR#343][comment] INTG: Add --with-session-recording=false to intgcheck's configure

2017-08-01 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/343 Title: #343: INTG: Add --with-session-recording=false to intgcheck's configure lslebodn commented: """ If you decided to add it to makefile then remove it from `contrib/ci/configure.sh` LS """ See the full comment at https://github.com/SSSD/sssd/pul

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-08-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master mzidek-rh commented: """ Thank you for the description. I see the bug now and the patch makes sense. I sent the patch to CI. """ See the full comment at https://github.com/SSSD/sssd/pull/202#issuecomment-

[SSSD] [sssd PR#241][+Changes requested] FleetCommander Integration

2017-08-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration jhrozek commented: """ sorry, I hit comment too soon. I think we want to handle that more gracefully and not throw an error. By the way, I'm still not finished with the review of the last patch (the previous on

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration jhrozek commented: """ With an old server that has no support for the desktop profiles, I'm getting: ``` (Tue Aug 1 10:19:17 2017) [sssd[be[ipa.test]]] [ipa_deskprofile_get_config_done] (0x0040): Unexpected numb

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration jhrozek commented: """ In general, to get rid of the TOCTOU issues, the key is using the `*at` and `*fd` family of functions - you might open the top level directory to get a fd and then instead of `stat` call `

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration jhrozek commented: """ There are some issues Coverity found: ``` Error: TOCTOU (CWE-367): sssd-1.15.4/src/providers/ipa/ipa_deskprofile_rules_util.c:157: fs_check_call: Calling function "stat" to perform check on

[SSSD] [sssd PR#326][synchronized] IPA: check if IPA hostname is a FQDN

2017-08-01 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/326 Author: amitkumar50 Title: #326: IPA: check if IPA hostname is a FQDN Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/326/head:pr326 git checkout pr326 From f68fcf13edea6a8d17

[SSSD] [sssd PR#343][opened] INTG: Add --with-session-recording=false to intgcheck's configure

2017-08-01 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/343 Author: fidencio Title: #343: INTG: Add --with-session-recording=false to intgcheck's configure Action: opened PR body: """ Let's ensure that running `make intgcheck-*` doesn't fail when done locally. """ To pull the PR as Git branch: git remote add