[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser fidencio commented: """ Is there an equivalent API for del_seuser as there is for get_seuser? I didn't find anything like that when looking at https://github.com/SELinuxProject/selinux/blob/m

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser lslebodn commented: """ If we decided to remove `get_seuser` then is there any reason why `del_seuser` cannot be replaced as well? I would prefer all or nothing. """ See the full comment at

[SSSD] [sssd PR#342][+Changes requested] SELINUX: Use getseuserbyname to get IPA seuser

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#342][-Accepted] SELINUX: Use getseuserbyname to get IPA seuser

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted

[SSSD] [sssd PR#354][comment] libwbclient: Fix warning statement with no effect

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect lslebodn commented: """ master: * aede6a1f4412f133e4b3fd76944f764d76fc4868 """ See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324099400

[SSSD] [sssd PR#354][+Pushed] libwbclient: Fix warning statement with no effect

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#354][closed] libwbclient: Fix warning statement with no effect

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/354 Author: lslebodn Title: #354: libwbclient: Fix warning statement with no effect Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/354/head:pr354 git checkout pr354 ___

[SSSD] [sssd PR#354][comment] libwbclient: Fix warning statement with no effect

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect fidencio commented: """ That's exactly the case that could be avoided by having something like https://github.com/SSSD/sssd/pull/50. """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#347][comment] Fixes related to negative cache and "root" user/group

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/347 Title: #347: Fixes related to negative cache and "root" user/group fidencio commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/347#issuecomment-324096441 ___ sss

[SSSD] [sssd PR#354][+Accepted] libwbclient: Fix warning statement with no effect

2017-08-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#354][comment] libwbclient: Fix warning statement with no effect

2017-08-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect sumit-bose commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324065118 ___ sssd-devel mailing li

[SSSD] [sssd PR#354][comment] libwbclient: Fix warning statement with no effect

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect fidencio commented: """ That's exactly the case that could be avoided by having something like https://github.com/SSSD/sssd/pull/50. """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#354][comment] libwbclient: Fix warning statement with no effect

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect lslebodn commented: """ I was testing such patch on el7 and I did not notice it either. I wonder how could it fix https://pagure.io/SSSD/sssd/issue/3461 :-) """ See the full comment at htt

[SSSD] [sssd PR#354][comment] libwbclient: Fix warning statement with no effect

2017-08-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/354 Title: #354: libwbclient: Fix warning statement with no effect sumit-bose commented: """ oops, I'm sorry for not catching this, so I put a postit to my monitor reminding me to really run a build with even the simplest looking changes. So let me run a

[SSSD] [sssd PR#354][opened] libwbclient: Fix warning statement with no effect

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/354 Author: lslebodn Title: #354: libwbclient: Fix warning statement with no effect Action: opened PR body: """ src/sss_client/libwbclient/wbc_pam_sssd.c: In function ‘wbcAuthenticateUserEx’: src/sss_client/libwbclient/wbc_pam_sssd.c:52:5: error: statemen

[SSSD] [sssd PR#347][comment] Fixes related to negative cache and "root" user/group

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/347 Title: #347: Fixes related to negative cache and "root" user/group jhrozek commented: """ On Tue, Aug 22, 2017 at 12:48:50PM +, fidencio wrote: > @jhrozek: Let me answer your questions here ... > > 1. I've dropped the patches related to "0"; > 2. T

[SSSD] [sssd PR#353][+Pushed] libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/353 Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#353][comment] libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/353 Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx jhrozek commented: """ * master: 725d04cd21016dc6092a9f03cd363bb83d7c054c """ See the full comment at https://github.com/SSSD/sssd/pull/353#issuecomment-324029049 _

[SSSD] [sssd PR#353][closed] libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/353 Author: lslebodn Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/353/head:pr353 git checkout pr353 ___

[SSSD] Re: about access control reporting with id_provider=ad

2017-08-22 Thread Michal Židek
On 08/22/2017 12:31 PM, Jakub Hrozek wrote: On Tue, Aug 22, 2017 at 11:40:39AM +0200, Michal Židek wrote: On 08/22/2017 11:21 AM, Michal Židek wrote: On 08/21/2017 02:27 PM, Jakub Hrozek wrote: Hi Michal and sssd-devel, one of the RFEs that keeps coming up for SSSD is to provide a sort of an

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-08-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ Since we depend on name attribute here, we should make it part of default attributes that are merged to the requested attributes in `cache_req_data_create_att

[SSSD] [sssd PR#347][synchronized] Fixes related to negative cache and "root" user/group

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/347 Author: fidencio Title: #347: Fixes related to negative cache and "root" user/group Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/347/head:pr347 git checkout pr347 From 336d

[SSSD] [sssd PR#347][-Changes requested] Fixes related to negative cache and "root" user/group

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/347 Title: #347: Fixes related to negative cache and "root" user/group Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@li

[SSSD] [sssd PR#347][comment] Fixes related to negative cache and "root" user/group

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/347 Title: #347: Fixes related to negative cache and "root" user/group fidencio commented: """ @jhrozek: Let me answer your questions here ... 1. I've dropped the patches related to "0"; 2. Thanks for the integration tests. I've gone through your patches a

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration pbrezina commented: """ On 08/22/2017 01:54 PM, fidencio wrote: > @pbrezina : patchset has been updated. > Thanks for your suggestions! Ack. """ See the full comment at https://gi

[SSSD] [sssd PR#128][-Changes requested] Fix group renaming issue when "id_provider = ldap" is set

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le..

[SSSD] [sssd PR#128][synchronized] Fix group renaming issue when "id_provider = ldap" is set

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Author: fidencio Title: #128: Fix group renaming issue when "id_provider = ldap" is set Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/128/head:pr128 git checkout pr128 From

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @lslebodn: patchset has been updated. Thanks for your suggestions! """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-324004045

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration fidencio commented: """ @pbrezina: patchset has been updated. Thanks for your suggestions! """ See the full comment at https://github.com/SSSD/sssd/pull/241#issuecomment-324003707 ___

[SSSD] [sssd PR#353][comment] libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/353 Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx sumit-bose commented: """ @lslebodn, thank you for taking case of this. For this PR is it a plain ACK from me. Imo #351 is fine as well but I would prefer the hear if @pbrezina has

[SSSD] [sssd PR#353][+Accepted] libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/353 Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#347][+Changes requested] Fixes related to negative cache and "root" user/group

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/347 Title: #347: Fixes related to negative cache and "root" user/group Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@li

[SSSD] [sssd PR#347][comment] Fixes related to negative cache and "root" user/group

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/347 Title: #347: Fixes related to negative cache and "root" user/group jhrozek commented: """ Actually, one more question -- why do we descend into only active domains? I think we should set the negcache also for disabled domains. """ See the full comment

[SSSD] [sssd PR#347][comment] Fixes related to negative cache and "root" user/group

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/347 Title: #347: Fixes related to negative cache and "root" user/group jhrozek commented: """ The patches mostly look good and fix the issue. I have two things to ask: 1) I don't think the patches that special-case the "id 0" case are needed. If you run "i

[SSSD] Re: about access control reporting with id_provider=ad

2017-08-22 Thread Jakub Hrozek
On Tue, Aug 22, 2017 at 11:40:39AM +0200, Michal Židek wrote: > On 08/22/2017 11:21 AM, Michal Židek wrote: > > On 08/21/2017 02:27 PM, Jakub Hrozek wrote: > > > Hi Michal and sssd-devel, > > > > > > one of the RFEs that keeps coming up for SSSD is to provide a sort of an > > > 'attestation report

[SSSD] Re: about access control reporting with id_provider=ad

2017-08-22 Thread Michal Židek
On 08/22/2017 12:43 PM, Michal Židek wrote: On 08/22/2017 11:38 AM, Jakub Hrozek wrote: On Tue, Aug 22, 2017 at 11:21:43AM +0200, Michal Židek wrote: On 08/21/2017 02:27 PM, Jakub Hrozek wrote: Hi Michal and sssd-devel, one of the RFEs that keeps coming up for SSSD is to provide a sort of an

[SSSD] [sssd PR#353][comment] libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/353 Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx lslebodn commented: """ @sumit-bose this PR + #351 together improves situation with sssd-libwbclient and samba-4.6 """ See the full comment at https://github.com/SSSD/sssd/pull/35

[SSSD] Re: debugging adcli info - short name not returned

2017-08-22 Thread Sumit Bose
On Wed, Aug 02, 2017 at 09:44:41AM +0200, Jakub Hrozek wrote: > On Tue, Aug 01, 2017 at 06:52:41PM -, smfre...@gmail.com wrote: > > In one of our test domains, we noticed that the short name of the domain > > was not being returned by "adcli info" (it is visible in the output of "net > > rpc

[SSSD] [sssd PR#353][opened] libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/353 Author: lslebodn Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx Action: opened PR body: """ Samba-4.6 change behaviour of few functions New version of code make sure session info for user is stored in cache. It is a performance

[SSSD] Re: about access control reporting with id_provider=ad

2017-08-22 Thread Michal Židek
On 08/22/2017 11:38 AM, Jakub Hrozek wrote: On Tue, Aug 22, 2017 at 11:21:43AM +0200, Michal Židek wrote: On 08/21/2017 02:27 PM, Jakub Hrozek wrote: Hi Michal and sssd-devel, one of the RFEs that keeps coming up for SSSD is to provide a sort of an 'attestation report' for SSSD. Mostly the req

[SSSD] [sssd PR#342][+Accepted] SELINUX: Use getseuserbyname to get IPA seuser

2017-08-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-08-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser mzidek-rh commented: """ @jhrozek sry, I only parsed 'accepted' from your message and I though you did accept it. So, ACK and adding accepted flag. """ See the full comment at https://githu

[SSSD] Re: about access control reporting with id_provider=ad

2017-08-22 Thread Michal Židek
On 08/22/2017 11:21 AM, Michal Židek wrote: On 08/21/2017 02:27 PM, Jakub Hrozek wrote: Hi Michal and sssd-devel, one of the RFEs that keeps coming up for SSSD is to provide a sort of an 'attestation report' for SSSD. Mostly the request is about printing who can access this client machine. I k

[SSSD] Re: about access control reporting with id_provider=ad

2017-08-22 Thread Jakub Hrozek
On Tue, Aug 22, 2017 at 11:21:43AM +0200, Michal Židek wrote: > On 08/21/2017 02:27 PM, Jakub Hrozek wrote: > > Hi Michal and sssd-devel, > > > > one of the RFEs that keeps coming up for SSSD is to provide a sort of an > > 'attestation report' for SSSD. Mostly the request is about printing who > >

[SSSD] Re: about access control reporting with id_provider=ad

2017-08-22 Thread Michal Židek
On 08/21/2017 02:27 PM, Jakub Hrozek wrote: Hi Michal and sssd-devel, one of the RFEs that keeps coming up for SSSD is to provide a sort of an 'attestation report' for SSSD. Mostly the request is about printing who can access this client machine. I know that we fetch all the HBAC rules for a cl

[SSSD] [sssd PR#332][comment] sydb: index improvements

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/332 Title: #332: sydb: index improvements jhrozek commented: """ I think the patches are great and we've seen already reports by users who run the patches and reported that performance improved substantially. There are some objects that are not user or gr

[SSSD] [sssd PR#352][synchronized] logging: Removing duplicate log message

2017-08-22 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/352 Author: amitkumar50 Title: #352: logging: Removing duplicate log message Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/352/head:pr352 git checkout pr352 From 1e7afe84a9871a2

[SSSD] Re: RFC: 1.15.4 cleanup

2017-08-22 Thread Jakub Hrozek
On Tue, Aug 22, 2017 at 09:19:54AM +0200, Lukas Slebodnik wrote: > On (21/08/17 21:04), Jakub Hrozek wrote: > >Hi, > > > >1.15.4 will be released by the end of this months in a time-based > >fashion. But obviously, the milestone is too big, so we need to decide > >where do we push the tickets to. >

[SSSD] [sssd PR#325][-Changes requested] MAN: Improve description of 'trusted domain section' in sssd.conf's man page

2017-08-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/325 Title: #325: MAN: Improve description of 'trusted domain section' in sssd.conf's man page Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an emai

[SSSD] [sssd PR#128][+Changes requested] Fix group renaming issue when "id_provider = ldap" is set

2017-08-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le..

[SSSD] [sssd PR#241][comment] FleetCommander Integration

2017-08-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/241 Title: #241: FleetCommander Integration pbrezina commented: """ Typo in "related": ```xml + +Default: id_provider is used if it +is set and can perform session reltted tasks

[SSSD] Re: RFC: 1.15.4 cleanup

2017-08-22 Thread Lukas Slebodnik
On (21/08/17 21:04), Jakub Hrozek wrote: >Hi, > >1.15.4 will be released by the end of this months in a time-based >fashion. But obviously, the milestone is too big, so we need to decide >where do we push the tickets to. > >I added tags to the tickets with my proposed cleanup: >- move to 1.16: