URL: https://github.com/SSSD/sssd/pull/363
Title: #363: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-13)
fidencio commented:
"""
@lslebodn: It's hard to do that without having the patches pushed in 1-14
branch.
As our team is really bad at reviewing patches, I
URL: https://github.com/SSSD/sssd/pull/363
Title: #363: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-13)
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
fidencio commented:
"""
Hmm. Nice catch. @lslebodn.
@jhrozek:
```
diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
index 039d0fd8d..1db5a4862 100644
--- a/src/confdb/confdb.c
+++
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
sumit-bose commented:
"""
@lslebodn, for clarification, do you prefer to define SPRItime to 'ld' or use
'%ld' directly in the format template?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/362#issuecomme
URL: https://github.com/SSSD/sssd/pull/128
Author: fidencio
Title: #128: Fix group renaming issue when "id_provider = ldap" is set
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/128/head:pr128
git checkout pr128
From
URL: https://github.com/SSSD/sssd/pull/128
Title: #128: Fix group renaming issue when "id_provider = ldap" is set
fidencio commented:
"""
And I'm updating the patches as I've just realized that the link to the pagure
issue is wrong.
"""
See the full comment at
https://github.com/SSSD/sssd/pul
URL: https://github.com/SSSD/sssd/pull/128
Title: #128: Fix group renaming issue when "id_provider = ldap" is set
fidencio commented:
"""
So, I've just made a simple test after talking to @jhrozek on #sssd.
Here's the sssd.conf of my IPA client:
```
[root@clnt x86_64]# cat /etc/sssd/sssd.conf
URL: https://github.com/SSSD/sssd/pull/363
Title: #363: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-13)
lslebodn commented:
"""
Do not cherry-pick patched directly from master. It's better to cherry-pick
from 1.14 branch. Because it will be simpler to track wh
URL: https://github.com/SSSD/sssd/pull/363
Title: #363: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-13)
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
URL: https://github.com/SSSD/sssd/pull/358
Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedoraho
URL: https://github.com/SSSD/sssd/pull/358
Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8
lslebodn commented:
"""
BTW fixing pep8 warnings without enforcing this check in CI is a little bit
wasted effort.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/358#issue
URL: https://github.com/SSSD/sssd/pull/358
Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedo
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@l
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
lslebodn commented:
"""
The same problem is in `CONFDB_DOMAIN_CASE_SENSITIVE`
"""
See the full comment at
https://github.com/SSSD/sssd/pull/359#issuecomment-325783670
URL: https://github.com/SSSD/sssd/pull/364
Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case
an invalid value is set
jhrozek commented:
"""
LGTM, I fired the internal CI just to do everything by the book before pushing..
"""
See the full comment at
https://github
URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedor
URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout
lslebodn commented:
"""
IIRC there was a plan to update error reporting. Because following error is not
very useful for troubleshooting:
`AssertionError: assert (27 + 1) == 27`
"""
See the full
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
lslebodn commented:
"""
Use "%ld" for time_t
Or check
57cd3443dcb7c073c5a00a9f2c3c3a3030ae2d3e..aac071824f6c98003f30d49ab440c15b4b53692c
"""
See the full comment at
https://github.com/SSSD/sssd/pull/362#issuecomment-325
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
lslebodn commented:
"""
use "%ld" for time_t
"""
See the full comment at
https://github.com/SSSD/sssd/pull/362#issuecomment-325779931
___
sssd-devel mailing list -- sssd-devel@
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
fidencio commented:
"""
ACK!
CI: http://vm-058-233.${abc}/logs/job/74/71/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/362#issuecomment-325748355
_
URL: https://github.com/SSSD/sssd/pull/364
Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case
an invalid value is set
fidencio commented:
"""
Ops, made some mess commenting in the wrong bug. :-)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/364#is
URL: https://github.com/SSSD/sssd/pull/364
Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case
an invalid value is set
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
URL: https://github.com/SSSD/sssd/pull/364
Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case
an invalid value is set
fidencio commented:
"""
ACK!
Ci: http://vm-058-233.${abc}/logs/job/74/71/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pul
URL: https://github.com/SSSD/sssd/pull/364
Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case
an invalid value is set
fidencio commented:
"""
ACK!
Ci: http://vm-058-233.${abc}/logs/job/74/71/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pul
URL: https://github.com/SSSD/sssd/pull/364
Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case
an invalid value is set
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
URL: https://github.com/SSSD/sssd/pull/364
Author: fidencio
Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in
case an invalid value is set
Action: opened
PR body:
"""
The code as it was seemed wrong as when an invalid value as set we
neither error out nor set a defaul
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
fidencio commented:
"""
CI failed due to https://pagure.io/SSSD/sssd/issue/2854, which is not related
to this patch.
http://vm-058-233.${abc}/logs/job/74/70/summary.html
ACK!
"""
See
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedo
URL: https://github.com/SSSD/sssd/pull/363
Author: fidencio
Title: #363: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-13)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/363/head:pr363
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
fidencio commented:
"""
@sumit-bose, patch looks good (and here I'm assuming you built it on 32bits
without any issue).
I'll ACK the patch as soon as I hear back from our internal CI. :-)
"""
See the full comment at
ht
URL: https://github.com/SSSD/sssd/pull/363
Author: fidencio
Title: #363: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-13)
Action: opened
PR body:
"""
Some patches have been dropped from the original series as those touched
files/functions that are not present
URL: https://github.com/SSSD/sssd/pull/362
Author: sumit-bose
Title: #362: IPA: format fixes
Action: opened
PR body:
"""
There are format warnings when compiling on 32bit. One is about time_t
where I added SPRItime and the other is about size_t where %zu should be
used.
Related to https://pag
URL: https://github.com/SSSD/sssd/pull/361
Title: #361: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-14)
fidencio commented:
"""
retest this, please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/361#issuecomment-325681340
__
URL: https://github.com/SSSD/sssd/pull/361
Author: fidencio
Title: #361: Add root (user, group, uid and gid) to the negative cache
(backport to sssd-1-14)
Action: opened
PR body:
"""
Some patches have been dropped from the original series as those touched
files/functions that are not present
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
fidencio commented:
"""
Patch looks good and I'll add the "Accepted" label as soon as I get the result
from our internal CI.
"""
See the full comment at
https://github.com/SSSD/sssd/
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
fidencio commented:
"""
@mzidek-rh: Here I'm guessing so would be better to wait and hear it from
@lslebodn ... but what I understood from his comment is: "either we have
equivalent functions
URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout
fidencio commented:
"""
ACK!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/360#issuecomment-325628617
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/358
Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8
fidencio commented:
"""
ACK!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/358#issuecomment-325628536
___
sssd-devel mailing li
URL: https://github.com/SSSD/sssd/pull/358
Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedoraho
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fed
URL: https://github.com/SSSD/sssd/pull/342
Title: #342: SELINUX: Use getseuserbyname to get IPA seuser
mzidek-rh commented:
"""
I am removing the changes requested and adding back the accepted label.
@lslebodn If you had a specific function in mind you can point us to it and we
can add it in a
Hi,
I've got a PR opened for some time that I would really like to merge for
the next version:
https://github.com/SSSD/sssd/pull/225 - SECRETS: Apply separate
quotas for cn=secrets and cn=kcm
It's been through several passes of a review already, so I think it
would be easy to add the fina
URL: https://github.com/SSSD/sssd/pull/360
Author: jhrozek
Title: #360: TESTS: Relax the assert in test_idle_timeout
Action: opened
PR body:
"""
Resolves:
https://pagure.io/SSSD/sssd/issue/3473
We're being quite strict in test_idle_timeout when checking for the number
of open fds which lea
URL: https://github.com/SSSD/sssd/pull/359
Author: jhrozek
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Action: opened
PR body:
"""
If the domain_type parameter contained an invalid value, the error branch
wouldn't have set the 'ret' parameter to an error condition, whic
52 matches
Mail list logo
