[SSSD] [sssd PR#357][comment] A few fixes/improvements related to issue #2976

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/357 Title: #357: A few fixes/improvements related to issue #2976 jhrozek commented: """ Thank you for fixing the nitpick. """ See the full comment at https://github.com/SSSD/sssd/pull/357#issuecomment-326205286

[SSSD] [sssd PR#357][+Accepted] A few fixes/improvements related to issue #2976

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/357 Title: #357: A few fixes/improvements related to issue #2976 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#361][+Accepted] Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-14)

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/361 Title: #361: Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-14) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#361][comment] Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-14)

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/361 Title: #361: Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-14) jhrozek commented: """ OK, ACK, the CI job had an issue with LDAP test on Debian but IIRC that's an issue we suppressed on master, but not in the older bran

[SSSD] Re: stuck with ticket #3465

2017-08-30 Thread Sumit Bose
On Wed, Aug 30, 2017 at 05:30:02PM +0200, Jakub Hrozek wrote: > Hi, > > I'm afraid I got a little stuck looking into upstream ticket > https://pagure.io/SSSD/sssd/issue/3465 > > The reporter is seeing sssd memory usage increasing on RHEL-6 and > RHEL-7. There is a valgrind log from RHEL-6 attache

[SSSD] [sssd PR#359][+Accepted] CONFDB: Do not crash with an invalid domain_type value

2017-08-30 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/359 Title: #359: CONFDB: Do not crash with an invalid domain_type value Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedo

[SSSD] [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value

2017-08-30 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/359 Title: #359: CONFDB: Do not crash with an invalid domain_type value fidencio commented: """ ACK from me as it also addresses @lslebodn's comments. """ See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-326129417 ___

[SSSD] [sssd PR#357][synchronized] A few fixes/improvements related to issue #2976

2017-08-30 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/357 Author: fidencio Title: #357: A few fixes/improvements related to issue #2976 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/357/head:pr357 git checkout pr357 From 2b9523a7a1

[SSSD] [sssd PR#357][comment] A few fixes/improvements related to issue #2976

2017-08-30 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/357 Title: #357: A few fixes/improvements related to issue #2976 fidencio commented: """ @jhrozek, patchset has been updated. """ See the full comment at https://github.com/SSSD/sssd/pull/357#issuecomment-326129011

[SSSD] [sssd PR#326][+Changes requested] IPA: check if IPA hostname is a FQDN

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/326 Title: #326: IPA: check if IPA hostname is a FQDN Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#363][comment] Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-13)

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/363 Title: #363: Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-13) jhrozek commented: """ btw I acked the sssd-1-14 patches so feel free to base the sssd-1-13 patches atop them """ See the full comment at https://github.c

[SSSD] [sssd PR#359][synchronized] CONFDB: Do not crash with an invalid domain_type value

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/359 Author: jhrozek Title: #359: CONFDB: Do not crash with an invalid domain_type value Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/359/head:pr359 git checkout pr359 From 0b7a

[SSSD] [sssd PR#359][-Changes requested] CONFDB: Do not crash with an invalid domain_type value

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/359 Title: #359: CONFDB: Do not crash with an invalid domain_type value Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@l

[SSSD] [sssd PR#359][synchronized] CONFDB: Do not crash with an invalid domain_type value

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/359 Author: jhrozek Title: #359: CONFDB: Do not crash with an invalid domain_type value Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/359/head:pr359 git checkout pr359 From 23eb

[SSSD] [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/359 Title: #359: CONFDB: Do not crash with an invalid domain_type value jhrozek commented: """ new patch pushed """ See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-326101033 ___ sssd-d

[SSSD] [sssd PR#360][comment] TESTS: Relax the assert in test_idle_timeout

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/360 Title: #360: TESTS: Relax the assert in test_idle_timeout jhrozek commented: """ OK, see new patches """ See the full comment at https://github.com/SSSD/sssd/pull/360#issuecomment-326098584 ___ sssd-devel ma

[SSSD] [sssd PR#360][-Changes requested] TESTS: Relax the assert in test_idle_timeout

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/360 Title: #360: TESTS: Relax the assert in test_idle_timeout Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#360][synchronized] TESTS: Relax the assert in test_idle_timeout

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/360 Author: jhrozek Title: #360: TESTS: Relax the assert in test_idle_timeout Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/360/head:pr360 git checkout pr360 From 212f5a464003e7

[SSSD] [sssd PR#361][comment] Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-14)

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/361 Title: #361: Add root (user, group, uid and gid) to the negative cache (backport to sssd-1-14) jhrozek commented: """ Code-wise ack, waiting for CI and Coverity before pushing """ See the full comment at https://github.com/SSSD/sssd/pull/361#issuecom

[SSSD] [sssd PR#364][+Pushed] CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/364 Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an e

[SSSD] [sssd PR#364][comment] CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/364 Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set jhrozek commented: """ * master: b4195db089bc481161b37cd129d0876571f633b4 """ See the full comment at https://github.com/SSSD/sssd/pull/364#issuec

[SSSD] [sssd PR#364][closed] CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/364 Author: fidencio Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/364/head:pr

[SSSD] stuck with ticket #3465

2017-08-30 Thread Jakub Hrozek
Hi, I'm afraid I got a little stuck looking into upstream ticket https://pagure.io/SSSD/sssd/issue/3465 The reporter is seeing sssd memory usage increasing on RHEL-6 and RHEL-7. There is a valgrind log from RHEL-6 attached to the ticket which does show some leaks, the three biggest ones are: ==1

[SSSD] [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/325 Title: #325: MAN: Improve description of 'trusted domain section' in sssd.conf's man page jhrozek commented: """ I would say "in *the* child domain", but otherwise LGTM, thank you. """ See the full comment at https://github.com/SSSD/sssd/pull/325#iss

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled jhrozek commented: """ Here's how I would go about the warning: - add a boolean into struct rctx, something like 'enumeration_warn_logged" - when the code reaches `cache_req_valid

[SSSD] [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page

2017-08-30 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/325 Title: #325: MAN: Improve description of 'trusted domain section' in sssd.conf's man page amitkumar50 commented: """ @jhrozek Thanks for comment. Done changes in 3rd patch. Please review. Once ok. I will rebase these. """ See the full comment at http

[SSSD] [sssd PR#325][synchronized] MAN: Improve description of 'trusted domain section' in sssd.conf's man page

2017-08-30 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/325 Author: amitkumar50 Title: #325: MAN: Improve description of 'trusted domain section' in sssd.conf's man page Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/325/head:pr325 g

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-08-30 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ @jhrozek Can you please review this PR as well and provide your suggestions? """ See the full comment at https://github.com/SSSD/sssd/pull/334#issuecomm

[SSSD] Re: Can someone review PR #225 (secrets quotas) ?

2017-08-30 Thread Fabiano Fidêncio
On Tue, Aug 29, 2017 at 11:17 AM, Jakub Hrozek wrote: > Hi, > > I've got a PR opened for some time that I would really like to merge for > the next version: > https://github.com/SSSD/sssd/pull/225 - SECRETS: Apply separate > quotas for cn=secrets and cn=kcm > > It's been through several pa

[SSSD] [sssd PR#364][+Accepted] CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/364 Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#364][comment] CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/364 Title: #364: CONFDB: Set a default value for subdomain_refresh_interval in case an invalid value is set jhrozek commented: """ CI passed """ See the full comment at https://github.com/SSSD/sssd/pull/364#issuecomment-325925923

[SSSD] [sssd PR#358][+Rejected] Requesting a pull to SSSD:master from jhrozek:pep8

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/358 Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8 Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#358][-Changes requested] Requesting a pull to SSSD:master from jhrozek:pep8

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/358 Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists

[SSSD] [sssd PR#358][closed] Requesting a pull to SSSD:master from jhrozek:pep8

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/358 Author: jhrozek Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/358/head:pr358 git checkout pr358 ___

[SSSD] [sssd PR#358][comment] Requesting a pull to SSSD:master from jhrozek:pep8

2017-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/358 Title: #358: Requesting a pull to SSSD:master from jhrozek:pep8 jhrozek commented: """ OK, then.. > On 29 Aug 2017, at 22:15, lslebodn wrote: > > BTW fixing pep8 warnings without enforcing this check in CI is a little bit > wasted effort. > > — > Y