URL: https://github.com/SSSD/sssd/pull/332
Title: #332: sydb: index improvements
sumit-bose commented:
"""
Just added a reference to the pagure ticket in the commit messages.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/332#issuecomment-327698402
__
URL: https://github.com/SSSD/sssd/pull/332
Author: sumit-bose
Title: #332: sydb: index improvements
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/332/head:pr332
git checkout pr332
From 38db1948b72c32ea9188f8b32d1ace2
URL: https://github.com/SSSD/sssd/pull/332
Title: #332: sydb: index improvements
jhrozek commented:
"""
The ticket for the objectcategory addition is
https://pagure.io/SSSD/sssd/issue/3503
The ticket for the indexing changes is already in 1.15.4
"""
See the full comment at
https://github.com/
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
Just a note. The CI passed. Codewise I see no blockers for this patchset. I
will keep the 'changes_requested' label solely for the requested metadata
changes.
"""
See the full comme
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
fidencio commented:
"""
Btw, sssctl: Fix warning may be used uninitialized was also part of my patch
set and was rejected by @lslebodn for the following reason "I do not think that
initialisation to NULL is
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
Label: -Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
Hmm.. it was a different CI result that came. So I am postponing the ACK for a
few moments now (but really just waiting for the rawhide machine to finish).
Lukas, can you please upda
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
fidencio commented:
"""
I'd prefer having my name as author (well, as I am the author of the pretty
much identical non reviewed patches).
Also, I'd prefer to have that patch set reviewed.
"""
See the full c
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
@fidencio Sorry, I was not aware of the PRs you mentioned (my mistake). However
I already reviewed this and I think it is better to have the patches rather
then not have them.
Becau
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
NACK! As said by @lslebodn "fixing pep8 warnings without enforcing this check
in CI is a little bit wasted effort.".
"""
See the full comment at
https://github.com/SSSD/s
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
I'm adding the "Rejected" label as "PR should be reviewd as whole patch set and
not just some parts.".
Feel free to remove the label when the Nacked patch is removed from
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
NACK! As said by @lslebodn "fixing pep8 warnings without enforcing this check
in CI is a little bit wasted effort." and
"""
See the full comment at
https://github.com/SS
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
fidencio commented:
"""
Nack to this PR.
sssctl: Fix warning shadows a global declaration: was fixed as part by
https://github.com/SSSD/sssd/pull/50/commits/862d10c5f98ae4b891ddd1d40ae1aa186534e737
and was
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/372#issuecomment-327468376
__
URL: https://github.com/SSSD/sssd/pull/368
Title: #368: ipa: make sure view name is initialized at startup
lslebodn commented:
"""
master:
* f00591a4615720640cf01b1c408315b57dd397dc
"""
See the full comment at
https://github.com/SSSD/sssd/pull/368#issuecomment-327501693
___
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
lslebodn commented:
"""
There are definitely issues in this PR but it is enough for sanity testing.
And PR will probably need to get rid of ldbadd usage in favour of python
bindings.
"""
See the
URL: https://github.com/SSSD/sssd/pull/373
Author: lslebodn
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Action: opened
PR body:
"""
Such simple test takes just 10 seconds and covers following regressions.
https://pagure.io/SSSD/sssd/issue/3283
https://pagure.io/SSSD/sssd/issue/3284
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
The patches fix the warnings. Just waiting for the CI before acking.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/371#issuecomment-327476891
URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
sumit-bose commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/372#issuecomment-327470431
___
sss
URL: https://github.com/SSSD/sssd/pull/261
Title: #261: Add systemtap probes into the top-level data provider requests
justin-stephenson commented:
"""
@lslebodn it was a mistake in my local testing I am sure. If it works for you
then please consider this set of patches ready for review and app
URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/372#issuecomment-327468371
__
URL: https://github.com/SSSD/sssd/pull/372
Author: amitkumar50
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
Action: opened
PR body:
"""
IPA and AD providers default to userCertificate;binary for the
ldap_user_certificate option. It will be good to default that valu
URL: https://github.com/SSSD/sssd/pull/368
Title: #368: ipa: make sure view name is initialized at startup
sumit-bose commented:
"""
@lslebodn, yes I would say the bug is present since the views/override support
was added. Since this issue can only be seen with non-default views and the
names
URL: https://github.com/SSSD/sssd/pull/326
Title: #326: IPA: check if IPA hostname is a FQDN
amitkumar50 commented:
"""
@jhrozek Thanks. Updated.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/326#issuecomment-327461874
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/371
Title: #371: Fixes for few el6 gcc warnings
mzidek-rh commented:
"""
LGTM. Will check the warnings on el6 to see if they disappear with this patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/371#issuecomment-327461833
__
URL: https://github.com/SSSD/sssd/pull/326
Author: amitkumar50
Title: #326: IPA: check if IPA hostname is a FQDN
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/326/head:pr326
git checkout pr326
From ddfe639c74406c1389
URL: https://github.com/SSSD/sssd/pull/368
Title: #368: ipa: make sure view name is initialized at startup
lslebodn commented:
"""
@sumit-bose Upstream ticket has not been triaged yet. So I am not sure where to
push the patch.
Is this bug also in 1.13 and 1.14?
"""
See the full comment at
htt
URL: https://github.com/SSSD/sssd/pull/371
Author: lslebodn
Title: #371: Fixes for few el6 gcc warnings
Action: opened
PR body:
"""
I noticed them as part of checking patch for #370
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/371/
URL: https://github.com/SSSD/sssd/pull/326
Author: amitkumar50
Title: #326: IPA: check if IPA hostname is a FQDN
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/326/head:pr326
git checkout pr326
From ddfe639c74406c1389
URL: https://github.com/SSSD/sssd/pull/366
Title: #366: SUDO: Use initgr_with_views when looking up a sudo user
pbrezina commented:
"""
Functional ack. But you need to amend tests.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/366#issuecomment-327454078
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedor
URL: https://github.com/SSSD/sssd/pull/351
Author: lslebodn
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/351/head:pr351
git checkout pr351
_
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
master:
* 2e72ababbbadda4c4036f99528460c1d595e0941
"""
See the full comment at
https://github.com/SSSD/sssd/pull/351#issuecomment-327452904
__
URL: https://github.com/SSSD/sssd/pull/370
Title: #370: certmap: Suppress warning Wmissing-braces
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/370
Title: #370: certmap: Suppress warning Wmissing-braces
lslebodn commented:
"""
master:
* 22abbb479e00438ec4ab19735824cc6e79dd9aaf
"""
See the full comment at
https://github.com/SSSD/sssd/pull/370#issuecomment-327452133
URL: https://github.com/SSSD/sssd/pull/370
Author: lslebodn
Title: #370: certmap: Suppress warning Wmissing-braces
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/370/head:pr370
git checkout pr370
___
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fed
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
pbrezina commented:
"""
Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/351#issuecomment-327450226
___
sssd-devel maili
URL: https://github.com/SSSD/sssd/pull/370
Title: #370: certmap: Suppress warning Wmissing-braces
sumit-bose commented:
"""
Thank you for adding the comment. ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/370#issuecomment-327449552
___
URL: https://github.com/SSSD/sssd/pull/370
Title: #370: certmap: Suppress warning Wmissing-braces
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/370
Author: lslebodn
Title: #370: certmap: Suppress warning Wmissing-braces
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/370/head:pr370
git checkout pr370
From 2dc3484022bd0939
URL: https://github.com/SSSD/sssd/pull/369
Author: lslebodn
Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/369/head:pr369
git checkout pr369
From 983e16
URL: https://github.com/SSSD/sssd/pull/370
Title: #370: certmap: Suppress warning Wmissing-braces
sumit-bose commented:
"""
Maybe: "To avoid 'missing-braces' warnings with older versions of gcc
kerberos_principal_name cannot be initialized with { 0 } but must be
initialized with memset()."?
""
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
On (06/09/17 00:49), Pavel Březina wrote:
>I don't see `ORIGINALAD_PREFIX SYSDB_NAME` here...
>
Nice catch. i have no idea where I found `ORIGINALAD_PREFIX ...
URL: https://github.com/SSSD/sssd/pull/351
Author: lslebodn
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/351/head:pr351
git checkout pr351
From 79
URL: https://github.com/SSSD/sssd/pull/370
Title: #370: certmap: Suppress warning Wmissing-braces
lslebodn commented:
"""
On (06/09/17 07:20), sumit-bose wrote:
>ACK, but maybe it would be good to add a comment about the issue in the code
>as well so that this change will not be 'optimized' out
URL: https://github.com/SSSD/sssd/pull/366
Title: #366: SUDO: Use initgr_with_views when looking up a sudo user
lslebodn commented:
"""
CI probably failed due to following error which I can see on my machine:
```
CC src/sss_client/libwbclient/test_wbc_calls-wbclient_common.o
src/tests/cm
URL: https://github.com/SSSD/sssd/pull/366
Title: #366: SUDO: Use initgr_with_views when looking up a sudo user
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
pbrezina commented:
"""
```c
const char *
sss_get_name_from_msg(struct sss_domain_info *domain,
struct ldb_message *msg)
{
const char *name;
/* If domain
URL: https://github.com/SSSD/sssd/pull/332
Title: #332: sydb: index improvements
sumit-bose commented:
"""
sure, would you mind to open them?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/332#issuecomment-327402970
___
sssd-devel ma
URL: https://github.com/SSSD/sssd/pull/332
Title: #332: sydb: index improvements
jhrozek commented:
"""
btw now I would also prefer to have 2 tickets - one for indexing fixes and one
for objectcategory. The latter first in 1.16.0 with a possible backport later.
What do you think?
"""
See the
URL: https://github.com/SSSD/sssd/pull/370
Title: #370: certmap: Suppress warning Wmissing-braces
sumit-bose commented:
"""
ACK, but maybe it would be good to add a comment about the issue in the code as
well so that this change will not be 'optimized' out later because the { 0 }
initializer
URL: https://github.com/SSSD/sssd/pull/368
Title: #368: ipa: make sure view name is initialized at startup
jhrozek commented:
"""
CI and Coverity passed -> accepted.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/368#issuecomment-327395463
___
URL: https://github.com/SSSD/sssd/pull/368
Title: #368: ipa: make sure view name is initialized at startup
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedoraho
57 matches
Mail list logo
