URL: https://github.com/SSSD/sssd/pull/378
Author: fidencio
Title: #378: [RFC] Use GNULIB's compiler warning code
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/378/head:pr378
git checkout pr378
From 1da51bc58480619be
On Tue, Sep 19, 2017 at 8:50 PM, Jakub Hrozek wrote:
> Hi,
>
> Timo mentioned last week on IRC that he would appreciate if we released
> 1.13.5.
>
> Does anyone have some patches to merge in sssd-1-13 or can we release
> the tarball?
>
> I know there are some pending PRs with backports and some pa
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
CI: http://vm-058-233.${abc}/logs/job/77/70/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/379#issuecomment-330652762
__
Hi,
Timo mentioned last week on IRC that he would appreciate if we released
1.13.5.
Does anyone have some patches to merge in sssd-1-13 or can we release
the tarball?
I know there are some pending PRs with backports and some patches for RHEL-6
bugs were proposed in bugzilla.redhat.com, but there
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
From 15f05529a7037f51ec65e5dd958799b812d6
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
From 15f05529a7037f51ec65e5dd958799b812d6
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
I have updated the patch set.
This new version has the each issue fixed explained and also the ones found
just on this or that distro also explained where they were found.
CI is already runnin
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
From 15f05529a7037f51ec65e5dd958799b812d6
URL: https://github.com/SSSD/sssd/pull/388
Title: #388: IDMAP: add a unit test
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/388
Title: #388: IDMAP: add a unit test
fidencio commented:
"""
@sumit-bose: make check failed in CentOS CI.
make-check: failure 00:00:17 ci-build-coverage/ci-make-check.log
I'm adding the "Changes Requested" label due to the failure (no, I'm
URL: https://github.com/SSSD/sssd/pull/389
Author: sumit-bose
Title: #389: sssd_client: add mutex protected call to the PAC responder
Action: opened
PR body:
"""
SSSD's plugin for MIT Kerberos to send the PAC to the PAC responder
currently uses sss_pac_make_request() which does not protect the
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
@lslebodn, @jhrozek: I'll follow a different approach in case you guys are
fine. Basically what I'm going to do is combine all the ignored by default
warnings in all our supported systems (RHE
URL: https://github.com/SSSD/sssd/pull/388
Author: sumit-bose
Title: #388: IDMAP: add a unit test
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/388/head:pr388
git checkout pr388
From 845a316c13b7887183a214c11693c38c2
URL: https://github.com/SSSD/sssd/pull/384
Title: #384: Prevent colision for explicitly defined slice. Currently it
happens f…
sumit-bose commented:
"""
@lslebodn, like https://github.com/SSSD/sssd/pull/388?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/384#issuecomment-33055
URL: https://github.com/SSSD/sssd/pull/388
Author: sumit-bose
Title: #388: IDMAP: add a unit test
Action: opened
PR body:
"""
A unit test for the recent changes from
0526dde7f3d4089617c0f4a6a85f83e9d266c9f1 is added.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/S
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
justin-stephenson commented:
"""
Thanks for the comments @lslebodn, changes made.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/274#issuecomment-330529794
URL: https://github.com/SSSD/sssd/pull/274
Author: justin-stephenson
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/274/head:pr274
git checkout pr274
From a7
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
lslebodn commented:
"""
few nitpicks: 1st patch "SSSCTL: Replace sss_debuglevel with shell wrapper"
should be after introducing command "sssctl debug*" otherwise it will break
bisect an may b
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
jhrozek commented:
"""
CI pased: http://vm-058-233.XXX/logs/job/77/62/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/274#issuecomment-330518395
___
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/384
Title: #384: Prevent colision for explicitly defined slice. Currently it
happens f…
lslebodn commented:
"""
@sumit-bose would you mind to write a unit test?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/384#issuecomment-330516729
URL: https://github.com/SSSD/sssd/pull/384
Title: #384: Prevent colision for explicitly defined slice. Currently it
happens f…
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-l
URL: https://github.com/SSSD/sssd/pull/384
Author: cinek810
Title: #384: Prevent colision for explicitly defined slice. Currently it
happens f…
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/384/head:pr384
git checkout pr3
URL: https://github.com/SSSD/sssd/pull/384
Title: #384: Prevent colision for explicitly defined slice. Currently it
happens f…
jhrozek commented:
"""
I fixed the two nitpicks and pushed the result as
0526dde7f3d4089617c0f4a6a85f83e9d266c9f1 to master.
Thank you for the contribution!
"""
See
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
CI: http://vm-058-233.${abc}/logs/job/77/61/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/379#issuecomment-330502831
__
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fed
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
jhrozek commented:
"""
The patches now look good, but please squash the three commits into a single
one so I can push a single patch.
You can run `git rebase -i origin/master` in
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
jhrozek commented:
"""
@amitkumar50 do you need any help with this PR?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/231#issuecomment-330496260
__
URL: https://github.com/SSSD/sssd/pull/260
Title: #260: Update sss_override.c
jhrozek commented:
"""
@amitkumar50 do you need any help with this PR?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/260#issuecomment-330496175
___
sssd-dev
URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
jhrozek commented:
"""
Yes, binary is what we want, but since it's the default now everywhere, we do
not want to document that as a deviation from default in
`src/man/include/ip
URL: https://github.com/SSSD/sssd/pull/387
Title: #387: Setting ldap_sudo_include_regexp to false
jhrozek commented:
"""
Yes, we can't merge this PR until we start working on the 2.0 milestone and are
ready to break compatibility.
That will happen during the F-28 timeframe.
"""
See the full c
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
I have provided a workaround for the issues pointed out in one of my comments.
That may be a way to go ...
"""
See the full comment at
https://github.com/SSSD/sssd/pull/379#issuecomment-33046
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
From f7a8ebba310fbfb94ea66e7d3b3e1d81ced6
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
justin-stephenson commented:
"""
Thank you for the review @jhrozek
Patchset updated.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/274#issuecomment-330415031
___
URL: https://github.com/SSSD/sssd/pull/274
Author: justin-stephenson
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/274/head:pr274
git checkout pr274
From 62
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorah
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
And seems that the tests failed in all machines in our internal CI:
http://vm-058-233.${abc}/logs/job/77/52/summary.html.
Adding back the "Changes Requested" label till it
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@li
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
lslebodn commented:
"""
Code wise ACK, but I noticed unrelated commit title before pushing.
@amitkumar50 it has nothing to do with integration test (prefix intg) and there
is not any er
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedor
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
Title: #377: This patch set fixes a bunch warnings
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377
From 5b5fd5fa29eae2b3a2cf
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
fidencio commented:
"""
I have updated the patch set, now using the correct version of the patches done
for PR #50. Also, I have added to this PR one patch from PR #371 that was not
part of PR #50.
I
URL: https://github.com/SSSD/sssd/pull/387
Title: #387: Setting ldap_sudo_include_regexp to false
fidencio commented:
"""
Oh, now I see that the issue has the tag "break compatibility" and is actually
set to 2.0 already.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/387#issuec
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
lslebodn commented:
"""
ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/386#issuecomment-330197646
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedor
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
lslebodn commented:
"""
There was a comment: someone else feel free to double-check this patch
Temporary removing ACK label so anybody else can check as well.
Timeout for temporary removed ack is 4
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/387
Title: #387: Setting ldap_sudo_include_regexp to false
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedoraho
URL: https://github.com/SSSD/sssd/pull/387
Title: #387: Setting ldap_sudo_include_regexp to false
fidencio commented:
"""
So, a few things related to this PR:
- I would like to see a message in the commit log that could explain as well as
the ticket does why this changes has been done;
- It's g
URL: https://github.com/SSSD/sssd/pull/387
Title: #387: Setting ldap_sudo_include_regexp to false
fidencio commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/387#issuecomment-330195910
___
sssd-devel mailing list
URL: https://github.com/SSSD/sssd/pull/387
Title: #387: Setting ldap_sudo_include_regexp to false
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/387#issuecomment-330194632
_
URL: https://github.com/SSSD/sssd/pull/387
Author: amitkumar50
Title: #387: Setting ldap_sudo_include_regexp to false
Action: opened
PR body:
"""
Disable ldap_sudo_include_regexp option by default since this is costly
operation for evaluation on ldap server.
Resolves: https://pagure.io/SSSD/s
URL: https://github.com/SSSD/sssd/pull/387
Title: #387: Setting ldap_sudo_include_regexp to false
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/387#issuecomment-330194634
_
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
fidencio commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/386#issuecomment-330192709
___
sssd-devel m
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/386#issuecomment-330191442
_
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/386#issuecomment-330191441
_
URL: https://github.com/SSSD/sssd/pull/386
Author: amitkumar50
Title: #386: intg: prevent "TypeError: must be type, not classobj"
Action: opened
PR body:
"""
Changes
- src/config/SSSDConfig/ipachangeconf.py:class IPAChangeConf:
- src/sbus/sbus_codegen:class Base:
- src/sbus/sbus_codegen:class
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
amitkumar50 commented:
"""
@jhrozek Done changes thanks.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-330189578
_
URL: https://github.com/SSSD/sssd/pull/334
Author: amitkumar50
Title: #334: Print a warning when enumeration is requested but disabled
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/334/head:pr334
git checkout pr334
F
URL: https://github.com/SSSD/sssd/pull/334
Author: amitkumar50
Title: #334: Print a warning when enumeration is requested but disabled
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/334/head:pr334
git checkout pr334
F
URL: https://github.com/SSSD/sssd/pull/334
Author: amitkumar50
Title: #334: Print a warning when enumeration is requested but disabled
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/334/head:pr334
git checkout pr334
F
URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
amitkumar50 commented:
"""
@jhrozek Thanks for review.
On latest master Its:
`
ldap_user_certificate = userCertificate;binary
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
I've opened https://pagure.io/SSSD/sssd/issue/3517 and marked it as easyfix.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/373#issuecomment-330165208
_
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
Although I strongly would prefer all or nothing, let's do it in the way you
wish.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/373#issuecomment-330162286
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
lslebodn commented:
"""
On (18/09/17 01:48), fidencio wrote:
>- **intg: prevent "TypeError: must be type, not classobj":** Althought I
>understand it would be out of the scope of this patch, but i
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorah
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorah
URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap
fidencio commented:
"""
- **intg: prevent "TypeError: must be type, not classobj":** Althought I
understand it would be out of the scope of this patch, but it could be fixed
(not in the same patc
74 matches
Mail list logo
