URL: https://github.com/SSSD/sssd/pull/275
Title: #275: Implement access verification by rhost using ldap_access_order
rhost option
akamensky commented:
"""
I have seen next release plans email which mentions test coverage (which I
strongly agree with), if someone could point me to the impleme
> On 25 Sep 2017, at 22:40, Jakub Hrozek wrote:
>
>> - TEST: Adding krb5-libs to dependencies
>> (https://github.com/SSSD/sssd/pull/218)
>> This PR has been stalled since celestian left the project. It's
>> something good to have but far from having high priority. IMO, this
>> can be postponed
> On 22 Sep 2017, at 11:10, Sumit Bose wrote:
>
>> - Add support for ActiveDirectory's logonHorous restrictions
>> (https://github.com/SSSD/sssd/pull/269)
>> This PR comes from an external contributor and as far as I
>> understood there's still some work to be done. So, should be postponed
>> t
> On 21 Sep 2017, at 23:23, Fabiano Fidêncio wrote:
>
> People,
>
> We have 27 PRs opened by the moment I'm writing this email and I'd
> like to have a clear idea which ones are the *must* have for our next
> release.
I think it should be notes that we’re trying to get the next release (1.15.4
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
lslebodn commented:
"""
master:
* f74408e37a3007aa41b19ab2afb693a91694da42
* da19eaea902744ec3cb41f87fa93fadb767f90e7
* d2c614143870e6efd4b3ab20c3a55cf714595256
"""
See the full comment at
ht
URL: https://github.com/SSSD/sssd/pull/274
Author: justin-stephenson
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/274/head:pr274
git checkout pr274
_
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/393
Author: pbrezina
Title: #393: IFP: parse ping arguments in codegen
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/393/head:pr393
git checkout pr393
URL: https://github.com/SSSD/sssd/pull/393
Title: #393: IFP: parse ping arguments in codegen
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/393
Title: #393: IFP: parse ping arguments in codegen
lslebodn commented:
"""
master:
* 1024dbcba0c16fb5df5e6d16894a8c7a36dc75f2
"""
See the full comment at
https://github.com/SSSD/sssd/pull/393#issuecomment-331991765
_
URL: https://github.com/SSSD/sssd/pull/371
Author: lslebodn
Title: #371: Fixes for few el6 gcc warnings
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/371/head:pr371
git checkout pr371
__
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
Title: #377: This patch set fixes a bunch warnings
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377
___
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
lslebodn commented:
"""
master:
* 39e300314cb43e534179a6950274e1e9c9a48465
* d8d49ae91708a2360c5c8f7a01e531952e2f7771
* 01f852fcb27e0a0a07e2b8b51e7e838a256b485f
* 3cb4592e27dac8032bd528b6a9f1b49dfa4ec0b
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
justin-stephenson commented:
"""
@lslebodn yes looks good to me, thank you for that.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/274#issuecomment-331957533
_
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
lslebodn commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/377#issuecomment-331935988
___
sssd-devel mailing l
URL: https://github.com/SSSD/sssd/pull/274
Title: #274: Merge sss_cache and sss_debuglevel into sssctl
lslebodn commented:
"""
@justin-stephenson, I did few changes to build each commit separately (make git
bisect happy :-)
Are you fine with them?
https://pagure.io/fork/lslebodn/SSSD/sssd/comm
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
On (25/09/17 13:19), sumit-bose wrote:
>Documenting them gives us the ability to explain why it is not a good idea to
>use them, what the side effects are and why they are there a
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
On (25/09/17 13:19), sumit-bose wrote:
>Documenting them gives us the ability to explain why it is not a good idea to
>use them, what the side effects are and why they are there a
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
> @lslebodn, your request is out of the scope of this patch.
It is not because if we decide that we do not want to document discouraged
options by upstream then
this PR need to b
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
sumit-bose commented:
"""
In retrospect I agree that we should document all options. It is not that hard
to find the options but currently it is not easy to understand the side effects
to those options
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
fidencio commented:
"""
@lslebodn, IIRC I saw that in our CI but not on my system.
So, in case I face it again, I'll add it as part of the PR #378.
"""
See the full comment at
https://github.com/SSSD
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
lslebodn commented:
"""
ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/377#issuecomment-331876520
___
sssd-devel mailing list -- sssd-dev
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
lslebodn commented:
"""
On (25/09/17 12:54), fidencio wrote:
>fidencio commented on this pull request.
>
>
>
>> @@ -195,7 +195,15 @@ struct sdap_get_initgr_state *prepare_state(struct
>> test_sdap_init
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
fidencio commented:
"""
Patch set has been updated addressing @lslebodn's comments.
Thanks for the review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/377#issuecomment-331871694
___
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
Title: #377: This patch set fixes a bunch warnings
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377
From 38c6441c359e5dd138b0
URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
I updated the 'Warning' patch to use wording suggested by @fidencio (I like it
more then mine).
Btw. I do not mind documenting other discouraged options, such as the one to
dis
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
lslebodn commented:
"""
"python: Changing class declaration from old to new-style type"
sounds good to me
"""
See the full comment at
https://github.com/SSSD/sssd/pull/386#issuecommen
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From 60326acc76b654308f9bc
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fe
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
master:
* c33fa33065b1211dba5ea2909bac62843a72e8b5
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-331867769
___
URL: https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
Following coding style issue fixed before push:
```
diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
index 4d55b38a1..b01306ab6 100644
--- a/src/confdb
URL: https://github.com/SSSD/sssd/pull/334
Author: amitkumar50
Title: #334: Print a warning when enumeration is requested but disabled
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/334/head:pr334
git checkout pr334
___
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
fidencio commented:
"""
@lslebodn, your request is out of the scope of this patch.
I see your request as exactly the same case as
https://github.com/SSSD/sssd/pull/373#issuecomment-330161363. And we're
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
On (25/09/17 10:46), fidencio wrote:
>I still don't understand.
>
>"Sure democracy works but there is not a reason why some discouraged options
>should be documented and other sho
URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-l
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
mzidek-rh commented:
"""
@fidencio I mentioned that I think we should add warning to the man page, but I
was not sure if we end up deleting the man page, so I did not add the change
immediately.
Lookin
URL: https://github.com/SSSD/sssd/pull/390
Author: mzidek-rh
Title: #390: NSS: Add option to disable memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/390/head:pr390
git checkout pr390
From 60326acc76b654308f9bc
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
fidencio commented:
"""
I still don't understand.
"Sure democracy works but there is not a reason why some discouraged options
should be documented and other should not be documented. We need to be
con
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
>Also, can you be explicit about which changes are you requesting? Either that
>or do not add the "Changes requested" label.
https://github.com/SSSD/sssd/pull/390#issuecomment-33
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
fidencio commented:
"""
@lslebodn: issue has been opened https://pagure.io/SSSD/sssd/issue/3524 and
would be way more coherent to have the discussion related to it there in the
pagure issue.
Also, can
URL: https://github.com/SSSD/sssd/pull/391
Title: #391: Use dbus-daemon in cwrap enviroment for test
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedor
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
Sure democracy works but there is not a reason why some discouraged options
should be documented and other should not be documented. We need to be
consistent. And @mzidek already
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
Sure democracy works but there is not a reason why some discouraged options
should be documented and other should not be documented. We need to be
consistent.
"""
See the full c
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
Sure democracy works but there is not a reason why some discouraged options
shoudl be documented and other should not be documented. We need to be
consistent.
"""
See the full c
URL: https://github.com/SSSD/sssd/pull/218
Title: #218: TEST: Adding krb5-libs to dependencies
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/372
Author: amitkumar50
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/372/head:pr372
git checkout pr372
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/218
Title: #218: TEST: Adding krb5-libs to dependencies
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary
amitkumar50 commented:
"""
@jhrozek Done Thanks..
"""
See the full comment at
https://github.com/SSSD/sssd/pull/372#issuecomment-331838532
__
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
fidencio commented:
"""
As @mzidek-rh, @jhrozek, @sumit-bose, @pbrezina and myself prefer to have the
feature documented, I'm adding back the "Accepted" label, which was given by
@pbrezina after his rev
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/386
Title: #386: intg: prevent "TypeError: must be type, not classobj"
amitkumar50 commented:
"""
@lslebodn waiting for your comments..
"""
See the full comment at
https://github.com/SSSD/sssd/pull/386#issuecomment-331837047
__
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
fidencio commented:
"""
Firstly, sorry for jumping in in the discussion without having any technical
contribution to give.
While is quite clear that @lslebodn is against the solution, I'd just like to
URL: https://github.com/SSSD/sssd/pull/393
Title: #393: IFP: parse ping arguments in codegen
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
On (24/09/17 07:14), Jakub Hrozek wrote:
>I prefer to document this as well.
>
Then I would prefer to document all hidden options and advertise
them in next release.
LS
"""
See
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
On (22/09/17 15:19), mzidek-rh wrote:
>As for not putting this to upstream and only to the requested downstream distro
It is a problem of downstream distribution that it accept un
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
lslebodn commented:
"""
On (25/09/17 07:23), sumit-bose wrote:
>I think adding to option to the man page is the only way to make sure the
>negative impact of this option is properly documented and nobody
URL: https://github.com/SSSD/sssd/pull/393
Title: #393: IFP: parse ping arguments in codegen
lslebodn commented:
"""
On (22/09/17 14:34), Pavel Březina wrote:
>On 09/22/2017 04:21 PM, lslebodn wrote:
>> *@lslebodn* commented on this pull request.
>>
>> ---
URL: https://github.com/SSSD/sssd/pull/390
Title: #390: NSS: Add option to disable memcache
sumit-bose commented:
"""
I think adding to option to the man page is the only way to make sure the
negative impact of this option is properly documented and nobody can be hit by
the effects of the opti
67 matches
Mail list logo