[SSSD] [sssd PR#449][+Changes requested] cache: Check for max_id/min_id in cache_req

2017-11-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#449][-Changes requested] cache: Check for max_id/min_id in cache_req

2017-11-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req

2017-11-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req jhrozek commented: """ Removing changes requested since a new patch had arrived """ See the full comment at https://github.com/SSSD/sssd/pull/449#issuecomment-347890037 _

[SSSD] [sssd PR#461][+Accepted] responder: Fix talloc hierarchy in sized_output_name

2017-11-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/461 Title: #461: responder: Fix talloc hierarchy in sized_output_name Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name

2017-11-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/461 Title: #461: responder: Fix talloc hierarchy in sized_output_name fidencio commented: """ I'm adding the "Accepted" label. Thanks for the patch and for the explanation of the issue (face-to-face, last week). I totally missed that when looking at the i

[SSSD] [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name

2017-11-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/461 Title: #461: responder: Fix talloc hierarchy in sized_output_name fidencio commented: """ I can see one failure in our internal CI: ``` ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 5b05f2b1276141ae922d65eae7807749 -D /var/lib/mock/fedora-27

[SSSD] [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name

2017-11-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/461 Title: #461: responder: Fix talloc hierarchy in sized_output_name fidencio commented: """ Ack! I'll add the accepted label after getting the results from our CI. """ See the full comment at https://github.com/SSSD/sssd/pull/461#issuecomment-347849459

[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

2017-11-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 fidencio commented: """ One thing that I have notice (with or without the patch) is that `getent group f...@ad.ff`, f...@ad.ff being an AD group from the trusted domain

[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

2017-11-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 fidencio commented: """ I've tried to reproduce the very same issue using sssd-1.13.3-57.el6_9 and I simply can't. May it be related to the ipa version? I'll give it an

[SSSD] [sssd PR#438][comment] krb5_child: Distinguish between expired & disabled AD user

2017-11-29 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/438 Title: #438: krb5_child: Distinguish between expired & disabled AD user sumit-bose commented: """ Hi Lukas, thank you for the patch. I will have a close look at the code later but I think the general approach is good. I'm just wondering if we should

[SSSD] [sssd PR#449][synchronized] cache: Check for max_id/min_id in cache_req

2017-11-29 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/449/head:pr449 git checkout pr449 From d9ec950853e