[SSSD] [sssd PR#464][comment] SYSDB: Properly handle name/gid override when using domain resolution order

2017-12-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order fidencio commented: """ Coverity: passed without issues! Internal CI: also passed without issues ... http://vm-031.${abc}/logs/job/82/16/summary.html """ See the

[SSSD] [sssd PR#464][comment] SYSDB: Properly handle name/gid override when using domain resolution order

2017-12-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order fidencio commented: """ Coverity: passed without issues! Internal CI: waiting for rawhide results, but all the other passed without issues! """ See the full comm

[SSSD] [sssd PR#464][synchronized] SYSDB: Properly handle name/gid override when using domain resolution order

2017-12-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Author: fidencio Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/464/head:pr464 git c

[SSSD] [sssd PR#464][synchronized] SYSDB: Properly handle name/gid override when using domain resolution order

2017-12-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Author: fidencio Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/464/head:pr464 git c

[SSSD] [sssd PR#464][opened] SYSDB: Properly handle name/gid override when using domain resolution order

2017-12-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Author: fidencio Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order Action: opened PR body: """ When using name/gid override together with domain resolution order the mpg name/gid may be returned instead of the o

[SSSD] [sssd PR#453][comment] Speed up by-ID lookups with the help of the Global Catalog

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/453 Title: #453: Speed up by-ID lookups with the help of the Global Catalog jhrozek commented: """ downstream tests: * AD tests "passed" - 2182302 - there are some child tests that failed, but Lukas tells me he has at least a workaround for the tests in t

[SSSD] [sssd PR#462][+Accepted] confdb: Do not start implicit_files with proxy domain

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/462 Title: #462: confdb: Do not start implicit_files with proxy domain Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#462][comment] confdb: Do not start implicit_files with proxy domain

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/462 Title: #462: confdb: Do not start implicit_files with proxy domain jhrozek commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/462#issuecomment-349427265 ___ sssd-devel mailing l

[SSSD] [sssd PR#436][comment] subdomains: Remove code only used in tests

2017-12-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/436 Title: #436: subdomains: Remove code only used in tests fidencio commented: """ @amitkumar50, you don't have to **remove** tests from test_ad_create_1way_trust_options and test_ad_create_2way_trust_options. What you'll have to do is dig in the code an

[SSSD] [sssd PR#436][comment] subdomains: Remove code only used in tests

2017-12-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/436 Title: #436: subdomains: Remove code only used in tests amitkumar50 commented: """ @jhrozek Yes I plan to update. But still not clear which tests to remove from test_ad_create_1way_trust_options(void **state) and test_ad_create_2way_trust_options """

[SSSD] [sssd PR#436][comment] subdomains: Remove code only used in tests

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/436 Title: #436: subdomains: Remove code only used in tests jhrozek commented: """ @amitkumar50 ping, do you still plan on updating this PR? """ See the full comment at https://github.com/SSSD/sssd/pull/436#issuecomment-349311997 _

[SSSD] [sssd PR#463][+Changes requested] cache: Check for max_id/min_id in cache_req

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/463 Title: #463: cache: Check for max_id/min_id in cache_req Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#463][comment] cache: Check for max_id/min_id in cache_req

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/463 Title: #463: cache: Check for max_id/min_id in cache_req jhrozek commented: """ I have two more requests and in the interest of speeding up this PR, I also proposed patches in my review branch: 1. There are some issues in your patch. The new error cod

[SSSD] [sssd PR#453][comment] Speed up by-ID lookups with the help of the Global Catalog

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/453 Title: #453: Speed up by-ID lookups with the help of the Global Catalog jhrozek commented: """ new patches that fix the Coverity warnings were pushed """ See the full comment at https://github.com/SSSD/sssd/pull/453#issuecomment-349283744

[SSSD] [sssd PR#453][comment] Speed up by-ID lookups with the help of the Global Catalog

2017-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/453 Title: #453: Speed up by-ID lookups with the help of the Global Catalog jhrozek commented: """ btw Coverity found two issues in the latest patches; I've fixed them both locally and I'm re-running all the tests now.. """ See the full comment at https: