[SSSD] [sssd PR#496][edited] sysdb: sanitize search filter input - backport sssd-1-13

2018-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/496 Author: sumit-bose Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Action: edited Changed field: title Original value: """ sysdb: sanitize search filter input """ ___ sssd-devel maili

[SSSD] [sssd PR#497][edited] sysdb: sanitize search filter input - backport sssd-1-14

2018-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/497 Author: sumit-bose Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 Action: edited Changed field: title Original value: """ sysdb: sanitize search filter input """ ___ sssd-devel maili

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input

2018-01-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input sumit-bose commented: """ @fidencio, the number of templates in SYSDB_PWUPN_FILTER changed and because of that that patch cannot be cherry-picked to sssd-1-13 without a change. """ See the full comment

[SSSD] [sssd PR#483][comment] Password change with two factor authentication

2018-01-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/483 Title: #483: Password change with two factor authentication jhrozek commented: """ Code-wise looks good. I've started some tests to make sure nothing is broken and I'll add the accepted label when they come back green. """ See the full comment at htt

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input

2018-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input fidencio commented: """ @sumit-bose, seems that this PR is exactly the same as #496. If that's the case, would you mind closing one of them? """ See the full comment at https://github.com/SSSD/sssd/pul

[SSSD] [sssd PR#464][comment] SYSDB: Properly handle name/gid override when using domain resolution order

2018-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order fidencio commented: """ @jhrozek, sorry, no. I'd strongly prefer if someone else could take it over from now. """ See the full comment at https://github.com/SSS

[SSSD] [sssd PR#464][comment] SYSDB: Properly handle name/gid override when using domain resolution order

2018-01-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order jhrozek commented: """ Hi @fidencio given that there is a downstream BZ where the support person mentioned they might need the fix in downstream I was wondering i

[SSSD] [sssd PR#472][+Accepted] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

2018-01-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/472 Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sss

[SSSD] [sssd PR#472][comment] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

2018-01-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/472 Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA jhrozek commented: """ Since the code will be (in absence of proper upstream infrastructure) tested by our downstream QE, I'm adding the Accepted label back. ""

[SSSD] [sssd PR#475][comment] AD: Use the right sdap_domain for the forest root

2018-01-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/475 Title: #475: AD: Use the right sdap_domain for the forest root jhrozek commented: """ Hi @lslebodn I would like to merge this code also to downstream during this week, I wonder if you already had some time to run tests with the latest patch? """ See t

[SSSD] [sssd PR#499][comment] dyndns_tests: Fix unit test with missing features in nsupdate

2018-01-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/499 Title: #499: dyndns_tests: Fix unit test with missing features in nsupdate lslebodn commented: """ You can easily that that on fedora rawhide i686 atm; due to crash in nsupdate Or you can modify ifdef in `nsupdate_msg_add_realm_cmd` to simulate such b

[SSSD] [sssd PR#499][comment] dyndns_tests: Fix unit test with missing features in nsupdate

2018-01-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/499 Title: #499: dyndns_tests: Fix unit test with missing features in nsupdate lslebodn commented: """ You can easily that that on fedora rawhide i686 atm; due to crash in nsupdate Or you can modify ifdef in `nsupdate_msg_add_realm_cmd` to simulate such b

[SSSD] [sssd PR#499][opened] dyndns_tests: Fix unit test with missing features in nsupdate

2018-01-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/499 Author: lslebodn Title: #499: dyndns_tests: Fix unit test with missing features in nsupdate Action: opened PR body: """ We return different string in the function nsupdate_msg_add_realm_cmd if realm command is not supported by nsupdate. However cmocka

[SSSD] [sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

2018-01-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/410 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13 sumit-bose commented: """ Hi Lukas, I think you backported the changes to the wrong function. In 1.13 in ipa_get_ad_override_connect_done() be_acct_req_to_override_filt

[SSSD] Re: Fleet Commander: design changes due to the drop of DAC_OVERRIDE capability

2018-01-22 Thread Simo Sorce
On Mon, 2018-01-22 at 15:10 +0100, Fabiano FidĂȘncio wrote: > People, > > Let's start with the context of this email: > https://bugzilla.redhat.com/show_bug.cgi?id=1536854 > So, seems that even without knowing that, I've relied on CAP_DAC_OVERRIDE > in order to have the Fleet Commander integration

[SSSD] Fleet Commander: design changes due to the drop of DAC_OVERRIDE capability

2018-01-22 Thread Fabiano FidĂȘncio
People, Let's start with the context of this email: https://bugzilla.redhat.com/show_bug.cgi?id=1536854 So, seems that even without knowing that, I've relied on CAP_DAC_OVERRIDE in order to have the Fleet Commander integration working as expected and in the implementation details of this feature.

[SSSD] [sssd PR#498][+Changes requested] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-01-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#498][comment] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-01-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/498 Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE lslebodn commented: """ Would you be so kind and could you firstly update design page. ATM it is unclear who should have which access to the related directory. Therefore it is difficult to say wh

[SSSD] [sssd PR#498][synchronized] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/498 Author: fidencio Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/498/head:pr498 git checkout pr498 From 3e3c9d2ac6ec4

[SSSD] [sssd PR#498][opened] DESKPROFILE: Do not require CAP_DAC_OVERRIDE

2018-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/498 Author: fidencio Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE Action: opened PR body: """ See the attached patches. Step-by-step on how to test this will be added later on. """ To pull the PR as Git branch: git remote add ghsssd https:/

[SSSD] [sssd PR#497][opened] sysdb: sanitize search filter input

2018-01-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/497 Author: sumit-bose Title: #497: sysdb: sanitize search filter input Action: opened PR body: """ Backport of commit 1f2662c8f97c9c0fa250055d4b6750abfc6d0835 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch

[SSSD] [sssd PR#495][comment] DESKPROFILE: Add checks for user and host category

2018-01-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/495 Title: #495: DESKPROFILE: Add checks for user and host category fidencio commented: """ Steps to reproduce the issue: 1. git clone https://github.com/fidencio/fleet-commander-vagans 2. In the project's folder do: cd fleet-commander; vagrant up 3. Once