[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data jhrozek commented: """ Dunno, I keep going back and forth on this myself.. Let's table this and talk on IRC tomorrow :) """ See the full comment at https://github.com/SSSD/sssd/pull/

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data fidencio commented: """ That's another approach that can be taken. If you prefer taking this path, let me go for this. """ See the full comment at https://github.com/SSSD/sssd/pull/5

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data jhrozek commented: """ Umm looking at the code more, shouldn't we rather make sure that whatever we get out of tcurl is NULL-terminated? Wouldn't that be a safer way also for the futu

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data fidencio commented: """ Right, I'll do a complete check on that. I've already mentioned that it has to be checked in the issue I've opened ... About the json_loads(), the other two pl

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data jhrozek commented: """ Actually, there is more. I think I was writing the code under the impression that you will get a NULL-teminated string in the secrets output. But I would sugges

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data jhrozek commented: """ There is another usage of `json_loads` in `sec_value_to_json`, do you think it would make sense to fix that one as well? Otherwise LGTM, very nice catch, thank

[SSSD] Re: Allowing local ssh login when using sssd

2018-03-21 Thread Sumit Bose
On Wed, Mar 21, 2018 at 07:08:42AM -0700, Richard Sharpe wrote: > On Wed, Mar 21, 2018 at 1:26 AM, Sumit Bose wrote: > > On Tue, Mar 20, 2018 at 06:17:11PM -0700, Richard Sharpe wrote: > >> On Tue, Mar 20, 2018 at 1:16 AM, Sumit Bose wrote: > >> > On Mon, Mar 19, 2018 at 04:45:12PM -0700, Richard

[SSSD] [sssd PR#542][opened] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/542 Author: fidencio Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data Action: opened PR body: """ As sss_iobuf data is *non* NULL terminated, we have to use json_loadb() passing the data's length instead of just using json_loads(). Due

[SSSD] Re: Allowing local ssh login when using sssd

2018-03-21 Thread Richard Sharpe
On Wed, Mar 21, 2018 at 1:26 AM, Sumit Bose wrote: > On Tue, Mar 20, 2018 at 06:17:11PM -0700, Richard Sharpe wrote: >> On Tue, Mar 20, 2018 at 1:16 AM, Sumit Bose wrote: >> > On Mon, Mar 19, 2018 at 04:45:12PM -0700, Richard Sharpe wrote: >> >> Hi folks, >> >> >> >> It seems that once we are joi

[SSSD] Re: Allowing local ssh login when using sssd

2018-03-21 Thread Sumit Bose
On Tue, Mar 20, 2018 at 06:17:11PM -0700, Richard Sharpe wrote: > On Tue, Mar 20, 2018 at 1:16 AM, Sumit Bose wrote: > > On Mon, Mar 19, 2018 at 04:45:12PM -0700, Richard Sharpe wrote: > >> Hi folks, > >> > >> It seems that once we are joined to a domain, ssh logins with local > >> accounts no lon