[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured fidencio commented: """ @amitkumar50, you have squashed **all** patches from @pbrezina into yours and that's not exactly the best way to go. We'd like to keep: Your patches with the two f

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ @jhrozek @pbrezina Done the changes on my branch itself. """ See the full comment at https://github.com/SSSD/sssd/pull/515#issuecomment-378486902 __

[SSSD] [sssd PR#515][synchronized] sssctl: Showing help even when sssd not configured

2018-04-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Author: amitkumar50 Title: #515: sssctl: Showing help even when sssd not configured Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/515/head:pr515 git checkout pr515 From b261

[SSSD] [sssd PR#387][comment] Setting ldap_sudo_include_regexp to false

2018-04-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false amitkumar50 commented: """ @jhrozek Yes. Are Only comments at this point are those provided by @fidencio on Sep 18, 2017 """ See the full comment at https://github.com/SSSD/sssd/pull/387#issuecom

[SSSD] [sssd PR#387][comment] Setting ldap_sudo_include_regexp to false

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false jhrozek commented: """ @amitkumar50 do you still plan on updating this PR? """ See the full comment at https://github.com/SSSD/sssd/pull/387#issuecomment-378382497

[SSSD] [sssd PR#434][+Accepted] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#434][-Changes requested] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@

[SSSD] [sssd PR#434][comment] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules jhrozek commented: """ The tests found no regressions. """ See the full comment at https://github.com/SSSD/sssd/pull/434#issuecomment-378381481 __

[SSSD] [sssd PR#548][opened] SERVER: Tone down shutdown messages for socket-activated responders

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/548 Author: fidencio Title: #548: SERVER: Tone down shutdown messages for socket-activated responders Action: opened PR body: """ When dealing with socket-activated responders, those may be shut themselves down after some inactivy period. And that's comp

[SSSD] [sssd PR#485][comment] Support alternative sources for the files provider

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider jhrozek commented: """ Yes, there is still one more thing to check (which is not related to the code of the patches but we should either test that before pushing them or else we forget)

[SSSD] [sssd PR#515][+Changes requested] sssctl: Showing help even when sssd not configured

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured fidencio commented: """ @amitkumar50, please, squash the patches suggested by Pavel and also add his other patch atop of yours. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#485][comment] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider fidencio commented: """ Sorry, I'm removing the "Accepted" label. Just for the process sake, @jhrozek or @justin-stephenson, would you mind to force push @jhrozek's branch containing the

[SSSD] [sssd PR#485][-Accepted] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#528][comment] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used fidencio commented: """ I'll add back the "Accepted" label after getting results from our CI. """ See the full comment at https://github.com/SSSD/sssd/pull/528#i

[SSSD] [sssd PR#528][-Accepted] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-

[SSSD] [sssd PR#543][+Accepted] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email t

[SSSD] [sssd PR#543][comment] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 fidencio commented: """ Ack, thanks for the change! """ See the full comment at https://github.com/SSSD/sssd/pull/543#issuecomment-378245994 _

[SSSD] [sssd PR#544][comment] IPA: Qualify the externalUser sudo attribute

2018-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/544 Title: #544: IPA: Qualify the externalUser sudo attribute pbrezina commented: """ LGTM """ See the full comment at https://github.com/SSSD/sssd/pull/544#issuecomment-378205992 ___ sssd-devel mailing list --

[SSSD] [sssd PR#434][comment] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules jhrozek commented: """ OK, let me run the downstream tests so that we can move forward """ See the full comment at https://github.com/SSSD/sssd/pull/434#issuecomment-378205840 __

[SSSD] [sssd PR#434][comment] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules pbrezina commented: """ I update the patch per Fabiano's review. """ See the full comment at https://github.com/SSSD/sssd/pull/434#issuecomment-378205521

[SSSD] [sssd PR#528][+Accepted] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-

[SSSD] [sssd PR#434][synchronized] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/434 Author: pbrezina Title: #434: sudo: require sudoHost attribute and do not merge rules Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/434/head:pr434 git checkout pr434 From e4

[SSSD] [sssd PR#528][comment] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/528#issuecomment-378204806 ___

[SSSD] [sssd PR#434][comment] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules jhrozek commented: """ We still need someone to run the downstream tests. """ See the full comment at https://github.com/SSSD/sssd/pull/434#issuecomment-378199924 __

[SSSD] [sssd PR#539][comment] Make nss netgroup requests more robust

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/539 Title: #539: Make nss netgroup requests more robust jhrozek commented: """ No, the downstream tests hang for me and I'm still investigating, otherwise I would have added the accepted label, """ See the full comment at https://github.com/SSSD/sssd/pul

[SSSD] [sssd PR#543][-Changes requested] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send a

[SSSD] [sssd PR#543][synchronized] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/543 Author: jhrozek Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/543/head:pr543

[SSSD] [sssd PR#543][synchronized] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/543 Author: jhrozek Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/543/head:pr543

[SSSD] [sssd PR#464][comment] SYSDB: Properly handle name/gid override when using domain resolution order

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order fidencio commented: """ @sumit-bose, did you have the chance to take a look at https://github.com/SSSD/sssd/pull/464#issuecomment-373682283 ? """ See the full co

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @jhrozek, @pbrezina, @sumit-bose, @mzidek-rh ... Please, could someone take a look on https://github.com/SSSD/sssd/pull/128#issuecomment-373748289 ? """ See

[SSSD] [sssd PR#528][comment] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used fidencio commented: """ @jhrozek, code looks fine by me. I'll fire a CI just for the process sake. @pbrezina, may I get your input here as well? """ See the full

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured pbrezina commented: """ Ack. But please squash these two commits from [1]: 1. coding style fix: https://github.com/pbrezina/sssd/commit/94906199bc0eb70f8134a39d08c3be0df2d43e62 2. move hel

[SSSD] [sssd PR#539][comment] Make nss netgroup requests more robust

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/539 Title: #539: Make nss netgroup requests more robust fidencio commented: """ @jhrozek, did you get the results of the downstream tests? Is this PR good to go? """ See the full comment at https://github.com/SSSD/sssd/pull/539#issuecomment-378168520

[SSSD] [sssd PR#481][+Blocked] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Label: +Blocked ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fe

[SSSD] [sssd PR#481][comment] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn fidencio commented: """ As this PR is blocked by #378, I'm adding the "Blocked" label here. """ See the full comment at https://github.com/SSSD/sssd/pull/481#issuecomment-378168297

[SSSD] [sssd PR#434][+Changes requested] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@

[SSSD] [sssd PR#485][comment] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider fidencio commented: """ I'm adding the "Accepted" label as per @pbrezina's review. """ See the full comment at https://github.com/SSSD/sssd/pull/485#issuecomment-378166511 _

[SSSD] [sssd PR#485][+Accepted] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#543][+Changes requested] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send a