[SSSD] [sssd PR#613][+Changes requested] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to ss

[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider fidencio commented: """ @jhrozek, patchset has been updated. """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403609462 _

[SSSD] [sssd PR#607][synchronized] Do not apply override_homedir and override_shell to files provider

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/607 Author: fidencio Title: #607: Do not apply override_homedir and override_shell to files provider Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/607/head:pr607 git checkout pr

[SSSD] [sssd PR#609][comment] SUDO: Don't save duplicates when saving qualified names

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/609 Title: #609: SUDO: Don't save duplicates when saving qualified names jhrozek commented: """ I rebased the patches atop the current origin/master and to be on the safe side I will only push them when the centOS CI finishes. """ See the full comment at

[SSSD] [sssd PR#609][synchronized] SUDO: Don't save duplicates when saving qualified names

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/609 Author: jhrozek Title: #609: SUDO: Don't save duplicates when saving qualified names Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/609/head:pr609 git checkout pr609 From 57f

[SSSD] [sssd PR#605][closed] PAM: create pre-auth indicator file

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/605 Author: sumit-bose Title: #605: PAM: create pre-auth indicator file Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/605/head:pr605 git checkout pr605 ___

[SSSD] [sssd PR#605][+Pushed] PAM: create pre-auth indicator file

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/605 Title: #605: PAM: create pre-auth indicator file Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora C

[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider jhrozek commented: """ I'm sorry to ask for a change in such a trivial patch, but I would prefer if the is_files_provider() function took a sss_domain_info parameter and no

[SSSD] [sssd PR#612][synchronized] crypto: Silence a Coverity warning in sss_hmac_sha1()

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/612 Author: jhrozek Title: #612: crypto: Silence a Coverity warning in sss_hmac_sha1() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/612/head:pr612 git checkout pr612 From 7d1e7

[SSSD] [sssd PR#605][comment] PAM: create pre-auth indicator file

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/605 Title: #605: PAM: create pre-auth indicator file jhrozek commented: """ I'm sorry I forgot to add the accepted label after the trivial change was done. Feel free to ping me if I forget again next time. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#605][+Accepted] PAM: create pre-auth indicator file

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/605 Title: #605: PAM: create pre-auth indicator file Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#609][+Accepted] SUDO: Don't save duplicates when saving qualified names

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/609 Title: #609: SUDO: Don't save duplicates when saving qualified names Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/610 Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes jhrozek commented: """ The design document at https://pagure.io/SSSD/docs/pull-request/69 was updated. I mostly touched the overview and implementation

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ @fidencio, ah, I only checked the current code because I thought I've already seen some macro/call for this. Thanks for adding the call. Given

[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider

2018-07-09 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider sumit-bose commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403466534

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've done that as part of https://github.com/SSSD/sssd/pull/607. Take a look at https://github.com/SSSD/sssd/pull/607/commits/1e3e8

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, btw, I've updated my other patch to also use strcasecmp() instead of strcmp(), thanks. """ See the full comment at https://github

[SSSD] [sssd PR#607][synchronized] Do not apply override_homedir and override_shell to files provider

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/607 Author: fidencio Title: #607: Do not apply override_homedir and override_shell to files provider Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/607/head:pr607 git checkout pr

[SSSD] [sssd PR#613][synchronized] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/613 Author: fidencio Title: #613: cache_req: Keep the files provider as the first domain to be searched Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/613/head:pr613 git checkou

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ @sumit-bose, I've done that as part of https://github.com/SSSD/sssd/pull/607. Take a look at https://github.com/SSSD/sssd/pull/607/commits/76803

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched fidencio commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/613#issuecomment-403456101 __

[SSSD] [sssd PR#613][comment] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/613 Title: #613: cache_req: Keep the files provider as the first domain to be searched sumit-bose commented: """ Not strictly related but in confdb.c strcasecmp() is used to check for the files provider. Maybe it would make sense to add a macro like e.g.

[SSSD] [sssd PR#613][opened] cache_req: Keep the files provider as the first domain to be searched

2018-07-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/613 Author: fidencio Title: #613: cache_req: Keep the files provider as the first domain to be searched Action: opened PR body: """ Currently we can't guarantee any order on which domain will the first to be searched. More than that, in case domain_resol

[SSSD] [sssd PR#609][comment] SUDO: Don't save duplicates when saving qualified names

2018-07-09 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/609 Title: #609: SUDO: Don't save duplicates when saving qualified names pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/609#issuecomment-403435084 ___ sssd-devel maili

[SSSD] [sssd PR#610][+Accepted] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes

2018-07-09 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/610 Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an ema

[SSSD] [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes

2018-07-09 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/610 Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes pbrezina commented: """ This is very nice Jakub. Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-403414183 ___

[SSSD] [sssd PR#612][opened] crypto: Silence a Coverity warning in sss_hmac_sha1()

2018-07-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/612 Author: jhrozek Title: #612: crypto: Silence a Coverity warning in sss_hmac_sha1() Action: opened PR body: """ It looks like the case where the key_len was exactly 64 was Confusing Coverity. The trace looks like this: 3. cond_at_most: Checking key_l