URL: https://github.com/SSSD/sssd/pull/715
Author: AdamWill
Title: #715: Use 120 second default timeout for dbus (#1654537)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/715/head:pr715
git checkout pr715
From
URL: https://github.com/SSSD/sssd/pull/715
Author: AdamWill
Title: #715: Use 120 second default timeout for dbus (#1654537)
Action: opened
PR body:
"""
As discussed in #1654537, first login to a system as a FreeIPA
domain user now usually causes an expensive SELinux operation
to happen; this
URL: https://github.com/SSSD/sssd/pull/715
Title: #715: Use 120 second default timeout for dbus (#1654537)
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/715#issuecomment-446858543
URL: https://github.com/SSSD/sssd/pull/713
Title: #713: krb5_child: fix permissions during SC auth
sumit-bose commented:
"""
np, new version has the corrected link. Thanks for doing the paperwork.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/713#issuecomment-446855902
URL: https://github.com/SSSD/sssd/pull/713
Author: sumit-bose
Title: #713: krb5_child: fix permissions during SC auth
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/713/head:pr713
git checkout pr713
From
URL: https://github.com/SSSD/sssd/pull/713
Title: #713: krb5_child: fix permissions during SC auth
jhrozek commented:
"""
Thank you. As discussed on IRC, I filed a separate ticket
https://pagure.io/SSSD/sssd/issue/3903 as the issue is a bit different from the
generic 'can't access ccache as
URL: https://github.com/SSSD/sssd/pull/702
Title: #702: NSS: Avoid changing the memory cache ownership away from the SSSD
user
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/702
Title: #702: NSS: Avoid changing the memory cache ownership away from the SSSD
user
mzidek-rh commented:
"""
Thanks. CI passed except for unrelated failure on debian and jhrozek showed me
the fix in interactive session.
ACK.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/713
Title: #713: krb5_child: fix permissions during SC auth
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/713
Author: sumit-bose
Title: #713: krb5_child: fix permissions during SC auth
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/713/head:pr713
git checkout pr713
From
URL: https://github.com/SSSD/sssd/pull/713
Title: #713: krb5_child: fix permissions during SC auth
sumit-bose commented:
"""
The latest version has the ret assignment removed.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/713#issuecomment-446603494
URL: https://github.com/SSSD/sssd/pull/713
Title: #713: krb5_child: fix permissions during SC auth
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/677
Author: thalman
Title: #677: pcre: port to pcre2
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/677/head:pr677
git checkout pr677
From
URL: https://github.com/SSSD/sssd/pull/677
Author: thalman
Title: #677: pcre: port to pcre2
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/677/head:pr677
git checkout pr677
From
URL: https://github.com/SSSD/sssd/pull/714
Title: #714: p11_child(openssl): do not free static memory
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/714
Title: #714: p11_child(openssl): do not free static memory
sumit-bose commented:
"""
> Btw. +1 for jhrozek's LGTM and if the "Related to" tag is added to commit
> message, then feel free to consider this acked.
Thanks for checking, I added "Related
URL: https://github.com/SSSD/sssd/pull/714
Author: sumit-bose
Title: #714: p11_child(openssl): do not free static memory
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/714/head:pr714
git checkout pr714
From
URL: https://github.com/SSSD/sssd/pull/714
Title: #714: p11_child(openssl): do not free static memory
mzidek-rh commented:
"""
Btw. +1 for jhrozek's LGTM and if the "Related to" tag is added to commit
message, then feel free to consider this acked.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/714
Title: #714: p11_child(openssl): do not free static memory
mzidek-rh commented:
"""
It was introduced in this commit e27d4f31342f68a2ddbb22c2d17336652046f9ad
So I think it would be good to add "Related to
https://pagure.io/SSSD/sssd/issue/3887; to the
URL: https://github.com/SSSD/sssd/pull/714
Title: #714: p11_child(openssl): do not free static memory
jhrozek commented:
"""
For some reason, coverity didn't see the defect as fixed, but OTOH it also
didn't find any new defects :-)
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/714
Author: sumit-bose
Title: #714: p11_child(openssl): do not free static memory
Action: opened
PR body:
"""
Coverity found a code path where we try to free a static array, this
patch removes it.
"""
To pull the PR as Git branch:
git remote add ghsssd
URL: https://github.com/SSSD/sssd/pull/713
Title: #713: krb5_child: fix permissions during SC auth
jhrozek commented:
"""
In general this looks good, but please fix this clang warning:
```
Error: CLANG_WARNING:
sssd-2.0.99/src/providers/krb5/krb5_child.c:1759:13: warning: Value stored to
'ret'
22 matches
Mail list logo
