[SSSD] [sssd PR#720][comment] contrib/ci/deps.sh: added missing dependency

2018-12-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/720 Title: #720: contrib/ci/deps.sh: added missing dependency mzidek-rh commented: """ > @alexey-tikhonov is right that test_pam_responder.py uses certutil > unconditionally. > > Adding it as a dependency is ok, however if it is possible with pytest to

[SSSD] [sssd PR#720][comment] contrib/ci/deps.sh: added missing dependency

2018-12-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/720 Title: #720: contrib/ci/deps.sh: added missing dependency sumit-bose commented: """ @alexey-tikhonov is right that test_pam_responder.py uses certutil unconditionally. Adding it as a dependency is ok, however if it is possible with pytest to run the

[SSSD] [sssd PR#720][comment] contrib/ci/deps.sh: added missing dependency

2018-12-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/720 Title: #720: contrib/ci/deps.sh: added missing dependency jhrozek commented: """ @sumit-bose do you have an opinion? """ See the full comment at https://github.com/SSSD/sssd/pull/720#issuecomment-448606952

[SSSD] [sssd PR#715][comment] Use 120 second default timeout for dbus (#1654537)

2018-12-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537) mzidek-rh commented: """ Just a note that pbrezina is on holiday, so the review may need to wait for January. """ See the full comment at

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2018-12-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name mzidek-rh commented: """ I will check in ding-libs if we have support for whitespaces before option name, but I suspect that it could collide with the multiline values feature in

[SSSD] [sssd PR#720][opened] contrib/ci/deps.sh: added missing dependency

2018-12-19 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/720 Author: alexey-tikhonov Title: #720: contrib/ci/deps.sh: added missing dependency Action: opened PR body: """ Added libnss3-tools to list of debian dependencies: certutil from this package is required by test_pam_responder.py. """ To pull the PR as