URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
thalman commented:
"""
@jhrozek I fixed all minor comments. There is still question whether we move
the check as you suggested.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/712
Title: #712: SSSCTL: user-checks does not show custom attributes
thalman commented:
"""
> But this looks like I haven't gotten to your codepath yet. Did you see the
> error locally as well?
No, I did not see this error. It worked fine in my testing
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
From
URL: https://github.com/SSSD/sssd/pull/726
Title: #726: TESTS: Add a simple integration test for retrieving the
extraAttributes property
Label: -Blocked
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/726
Title: #726: TESTS: Add a simple integration test for retrieving the
extraAttributes property
jhrozek commented:
"""
Ah, sorry, there were some pep8 errors in the test. Should work now.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/726
Author: jhrozek
Title: #726: TESTS: Add a simple integration test for retrieving the
extraAttributes property
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/726/head:pr726
URL: https://github.com/SSSD/sssd/pull/723
Title: #723: MAN: Explicitly state that not all generic domain options are
supported for the files provider
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe
URL: https://github.com/SSSD/sssd/pull/728
Title: #728: ci: add Fedora 29
jhrozek commented:
"""
scan.coverity.com uses an invalid certificate. It's issued for
misc.synopsys.com and a couple of other strange sites using the subjectAltName,
but none of them matches scan.coverity.com
I suggest
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
jhrozek commented:
"""
I think this commit is mostly good. I'll just leave some very minor nitpics
inline using the github review tool.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/712
Title: #712: SSSCTL: user-checks does not show custom attributes
jhrozek commented:
"""
I'm getting a crash when testing this code:
```
#0 0x7fdfcaefaeab in raise () from /lib64/libc.so.6
#1 0x7fdfcaee55b9 in abort () from /lib64/libc.so.6
URL: https://github.com/SSSD/sssd/pull/728
Title: #728: ci: add Fedora 29
pbrezina commented:
"""
I have no idea why the travis ci failed.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/728#issuecomment-452281320
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/723
Author: jhrozek
Title: #723: MAN: Explicitly state that not all generic domain options are
supported for the files provider
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd
URL: https://github.com/SSSD/sssd/pull/723
Title: #723: MAN: Explicitly state that not all generic domain options are
supported for the files provider
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To
URL: https://github.com/SSSD/sssd/pull/722
Title: #722: KCM: Deleting a non-existent ccache should not yield an error
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/722
Title: #722: KCM: Deleting a non-existent ccache should not yield an error
thalman commented:
"""
LGTM, ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/722#issuecomment-452259179
___
URL: https://github.com/SSSD/sssd/pull/728
Author: pbrezina
Title: #728: ci: add Fedora 29
Action: opened
PR body:
"""
I pushed Fedora 29 machines into [1] vagrant cloud. This patch
enables testing on this distro in our CI.
[1] https://app.vagrantup.com/sssd-vagrant/
"""
To pull the PR as
URL: https://github.com/SSSD/sssd/pull/715
Title: #715: Use 120 second default timeout for dbus (#1654537)
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/715
Title: #715: Use 120 second default timeout for dbus (#1654537)
jhrozek commented:
"""
Oops, this was pushed already, I just forgot to close the PR. Master:
e4469fbdb3d5c53294c6514280ac75b847b3c61c
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/715
Author: AdamWill
Title: #715: Use 120 second default timeout for dbus (#1654537)
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/715/head:pr715
git checkout pr715
URL: https://github.com/SSSD/sssd/pull/726
Title: #726: TESTS: Add a simple integration test for retrieving the
extraAttributes property
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/726#issuecomment-452213696
20 matches
Mail list logo
