[SSSD] [sssd PR#726][comment] TESTS: Add a simple integration test for retrieving the extraAttributes property

2019-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/726 Title: #726: TESTS: Add a simple integration test for retrieving the extraAttributes property jhrozek commented: """ @mrniranjan does the patch look OK now? """ See the full comment at https://github.com/SSSD/sssd/pull/726#issuecomment-460997309

[SSSD] [sssd PR#739][comment] TESTS: Add a test for extra attributes in the output of sssctl user-checks

2019-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/739 Title: #739: TESTS: Add a test for extra attributes in the output of sssctl user-checks jhrozek commented: """ @mrniranjan can you review, please? """ See the full comment at https://github.com/SSSD/sssd/pull/739#issuecomment-460997520 __

[SSSD] [sssd PR#736][comment] KCM: Allow representing ccaches with a NULL principal

2019-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/736 Title: #736: KCM: Allow representing ccaches with a NULL principal jhrozek commented: """ You are right @mzidek-rh a patch should have a test. See the new patchset.. """ See the full comment at https://github.com/SSSD/sssd/pull/736#issuecomment-460996

[SSSD] [sssd PR#736][synchronized] KCM: Allow representing ccaches with a NULL principal

2019-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/736 Author: jhrozek Title: #736: KCM: Allow representing ccaches with a NULL principal Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/736/head:pr736 git checkout pr736 From 740ce

[SSSD] [sssd PR#744][comment] ssh: sssd_ssh fails completely on p11_child timeout

2019-02-06 Thread thalman
URL: https://github.com/SSSD/sssd/pull/744 Title: #744: ssh: sssd_ssh fails completely on p11_child timeout thalman commented: """ > > Or was the idea behind the path that since the output is just a public key, > we can go on? > But shouldn't the code fall through in that case instead of endin

[SSSD] [sssd PR#705][-Changes requested] KCM: Add configurable quotas

2019-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedo

[SSSD] [sssd PR#705][comment] KCM: Add configurable quotas

2019-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas jhrozek commented: """ The tests were not cleaning after one another. I guess that's why I didn't see the failed results on my machine when running the tests one-by-one. So far I added a standalone fixup commi

[SSSD] [sssd PR#705][synchronized] KCM: Add configurable quotas

2019-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Author: jhrozek Title: #705: KCM: Add configurable quotas Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/705/head:pr705 git checkout pr705 From 201d021c17032fc1a1425666b97fec