[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2019-07-01 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable alexey-tikhonov commented: """ Thank you. ACK code-wise. """ See the full comment at https://github.com/SSSD/sssd/pull/837#issuecomment-507347238 ___ sss

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2019-07-01 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable alexey-tikhonov commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/837#issuecomment-507285845 ___ sssd-devel

[SSSD] [sssd PR#838][-Changes requested] FIPS140 compliant usage of PRNG

2019-07-01 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/838 Title: #838: FIPS140 compliant usage of PRNG Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#838][comment] FIPS140 compliant usage of PRNG

2019-07-01 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/838 Title: #838: FIPS140 compliant usage of PRNG alexey-tikhonov commented: """ > This is exactly the case with `sss_generate_csprng_buffer()` function, which > might be used in security relevant functionality, thus it fails if > `RAND_bytes()` fails. > B

[SSSD] [sssd PR#838][synchronized] FIPS140 compliant usage of PRNG

2019-07-01 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/838 Author: alexey-tikhonov Title: #838: FIPS140 compliant usage of PRNG Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/838/head:pr838 git checkout pr838 From 5262735f993b195149a

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2019-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable sumit-bose commented: """ Hi @alexey-tikhonov, thanks for the review, you are right with both, in the latest version I moved the changes for Maklefile.am to the other patch and removed the CRYPTO a

[SSSD] [sssd PR#837][synchronized] p11_child: make OCSP digest configurable

2019-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/837 Author: sumit-bose Title: #837: p11_child: make OCSP digest configurable Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/837/head:pr837 git checkout pr837 From 2b2a5b135d454cd

[SSSD] [sssd PR#812][comment] Implement background refresh for IPA and AD domains and subdomains

2019-07-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/812 Title: #812: Implement background refresh for IPA and AD domains and subdomains jhrozek commented: """ I added two new patches, one should IMO stay as a separate patch, the other I'll squash into the initgroups support patches, but having both the patc

[SSSD] [sssd PR#812][comment] Implement background refresh for IPA and AD domains and subdomains

2019-07-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/812 Title: #812: Implement background refresh for IPA and AD domains and subdomains jhrozek commented: """ Ah, OK, the attribute is set at the DP level (`set_initgroups_expire_attribute()`). It was even me who moved it outside the provider..oops.. """ Se

[SSSD] [sssd PR#812][comment] Implement background refresh for IPA and AD domains and subdomains

2019-07-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/812 Title: #812: Implement background refresh for IPA and AD domains and subdomains jhrozek commented: """ btw I don't see this behaviour when I run id from the command line..weird. Anyway, thank you for reporting, I will take a look. """ See the full com

[SSSD] [sssd PR#812][comment] Implement background refresh for IPA and AD domains and subdomains

2019-07-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/812 Title: #812: Implement background refresh for IPA and AD domains and subdomains jhrozek commented: """ Yes, I can see it as well.. """ See the full comment at https://github.com/SSSD/sssd/pull/812#issuecomment-507213297 ___

[SSSD] [sssd PR#812][comment] Implement background refresh for IPA and AD domains and subdomains

2019-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/812 Title: #812: Implement background refresh for IPA and AD domains and subdomains sumit-bose commented: """ Hi Jakub, while checking with the AD provider it looks like although the initgroups refresh is run the related timestamp in the cache object is n