[SSSD] [sssd PR#836][+Changes requested] sss_obfuscate fails to rewriting comments

2019-08-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/836 Title: #836: sss_obfuscate fails to rewriting comments Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#836][comment] sss_obfuscate fails to rewriting comments

2019-08-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/836 Title: #836: sss_obfuscate fails to rewriting comments sumit-bose commented: """ Hi, it looks like your patch fails when it is used with python-3: ``` $ echo -e "12444" | sss_obfuscate -s -d default -f 3d31deed24c69b9479ce96d79c9a8e70ec37b20c03b4f6e5

[SSSD] [sssd PR#867][comment] ci: use python2 version of pytest

2019-08-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/867 Title: #867: ci: use python2 version of pytest sumit-bose commented: """ Hi Pavel, there still the issue with pep8 which should be replaced with python3-pycodestyle. Do you think it would make sense to add this to this PR as well to cover all issues

[SSSD] [sssd PR#869][opened] pam: keep pin on the PAM stack for forward_pass

2019-08-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/869 Author: sumit-bose Title: #869: pam: keep pin on the PAM stack for forward_pass Action: opened PR body: """ Currently only the password or the long-term part of a two-factor authentication was kept on the PM stack if pam_sss.so has the option forward_

[SSSD] [sssd PR#868][opened] ifp: let cache_req parse input name so it can fallback to upn search

2019-08-19 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/868 Author: pbrezina Title: #868: ifp: let cache_req parse input name so it can fallback to upn search Action: opened PR body: """ UPN search expects that the input name is in its fully qualified form. However, GetUserAttr calls cache_req with unqualifie

[SSSD] [sssd PR#868][comment] ifp: let cache_req parse input name so it can fallback to upn search

2019-08-19 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/868 Title: #868: ifp: let cache_req parse input name so it can fallback to upn search pbrezina commented: """ I am not entirely sure about this change: ```diff /* IFP serves both POSIX and application domains. Requests that need * to differenti

[SSSD] [sssd PR#863][comment] ci: add Debian 10

2019-08-19 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/863 Title: #863: ci: add Debian 10 pbrezina commented: """ I do not think so. We might concatenate several distro-specific suppresion files into one and feed this to valgrind but that would be quite tedious work. """ See the full comment at https://githu

[SSSD] [sssd PR#863][comment] ci: add Debian 10

2019-08-19 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/863 Title: #863: ci: add Debian 10 pbrezina commented: """ The ssh error is fixed with new box. """ See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-522531656 ___ sssd-devel mailing lis

[SSSD] [sssd PR#867][opened] ci: use python2 version of pytest

2019-08-19 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/867 Author: pbrezina Title: #867: ci: use python2 version of pytest Action: opened PR body: """ Fedora 31 changed symlink of /usr/bin/py.test from pytest2 to pytest3. We need to run the python2 version in order to run our tests with python2. We might wan

[SSSD] [sssd PR#861][comment] IPA: Allow paging when fetching external groups

2019-08-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/861 Title: #861: IPA: Allow paging when fetching external groups sumit-bose commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/861#issuecomment-522442489 ___ sssd-devel mailing list

[SSSD] [sssd PR#861][+Accepted] IPA: Allow paging when fetching external groups

2019-08-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/861 Title: #861: IPA: Allow paging when fetching external groups Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste