URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
> When we are touching the code, I believe also `subdomains_provider` is
> missing. Also most of the providers defaults to `id_provider`, few have other
> defaults so I think it should be handle
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
> @alexal Alex, can you please complete the patch by adding missing things per
> [this](https://github.com/SSSD/sssd/pull/851#issuecomment-516750056) comment?
> Thank you.
@pbrezina done. I apo
URL: https://github.com/SSSD/sssd/pull/851
Author: alexal
Title: #851: Update __init__.py.in
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/851/head:pr851
git checkout pr851
From 86f62a2e362259bd2e8a38d012a243bc91e4e6
URL: https://github.com/SSSD/sssd/pull/867
Author: pbrezina
Title: #867: ci: use python2 version of pytest
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/867/head:pr867
git checkout pr867
From 59454a8012bbe31ff0f1993f
URL: https://github.com/SSSD/sssd/pull/867
Author: pbrezina
Title: #867: ci: use python2 version of pytest
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/867/head:pr867
git checkout pr867
From 59454a8012bbe31ff0f1993f
URL: https://github.com/SSSD/sssd/pull/457
Title: #457: ipa: Removal of umask(0) in selinux_child
pbrezina commented:
"""
@amitkumar50 Would you mind just changing the comment so we can merge this
patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/457#issuecomment-522981230
URL: https://github.com/SSSD/sssd/pull/807
Title: #807: sudo: do not update last usn value on rules refresh
pbrezina commented:
"""
@alexey-tikhonov Could you review this please?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/807#issuecomment-522978505
__
URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency
pbrezina commented:
"""
Well, we can perhaps put all missing dependencies there (I mean even patch and
sed and perhaps other) to have the complete list. It may be helpful because
e.g. fedora-cloud
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
Sure it would be better, but I'd say it is out of scope of this pull request.
Unless the author wants to do the extra job, of course.
@alexal Alex, can you please complete the patch by adding
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code
URL: https://github.com/SSSD/sssd/pull/864
Title: #864: Monitor resolv.conf symlink
pbrezina commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/864#issuecomment-522970593
___
sssd-devel mailing list -- sssd-devel@
URL: https://github.com/SSSD/sssd/pull/865
Title: #865: KCM: Use int32_t type conversion in DEBUG message for int32_t
variable
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel
URL: https://github.com/SSSD/sssd/pull/865
Title: #865: KCM: Use int32_t type conversion in DEBUG message for int32_t
variable
pbrezina commented:
"""
Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/865#issuecomment-522969891
___
URL: https://github.com/SSSD/sssd/pull/869
Title: #869: pam: keep pin on the PAM stack for forward_pass
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fe
URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn
search
pbrezina commented:
"""
I am not entirely sure about this change:
```diff
/* IFP serves both POSIX and application domains. Requests that need
* to differenti
URL: https://github.com/SSSD/sssd/pull/870
Title: #870: pam: do not accept empty PIN
pbrezina commented:
"""
Looking at the callers, we are mixing errno with pam return code:
```c
static int prompt_by_config(pam_handle_t *pamh, struct pam_items *pi)
...
case PC_TYPE_SC_PIN:
URL: https://github.com/SSSD/sssd/pull/870
Title: #870: pam: do not accept empty PIN
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedo
URL: https://github.com/SSSD/sssd/pull/870
Author: sumit-bose
Title: #870: pam: do not accept empty PIN
Action: opened
PR body:
"""
The current check for an empty PIN was incomplete and if no PIN was
given pam_sss should not send a request to SSSD's pam responder. This
would match the behavior
18 matches
Mail list logo
