[SSSD] [sssd PR#5356][+Accepted] krb5_child: Harden credentials validation code

2020-10-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5356 Title: #5356: krb5_child: Harden credentials validation code Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahost

[SSSD] [sssd PR#5356][comment] krb5_child: Harden credentials validation code

2020-10-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5356 Title: #5356: krb5_child: Harden credentials validation code sumit-bose commented: """ > > Hi, > > thanks for the patch, it looks good. I just wonder if it might be risky to > > use the pretty generic macro `TRUE` which other libraries we might includ

[SSSD] [sssd PR#5356][comment] krb5_child: Harden credentials validation code

2020-10-07 Thread simo5
URL: https://github.com/SSSD/sssd/pull/5356 Title: #5356: krb5_child: Harden credentials validation code simo5 commented: """ Sounds liek some tests failed due to infrastructure issues ... """ See the full comment at https://github.com/SSSD/sssd/pull/5356#issuecomment-705140663 ___

[SSSD] [sssd PR#5354][+Waiting for review] build: remove libsss_certmap from dependencies of libsss_cert

2020-10-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5354 Title: #5354: build: remove libsss_certmap from dependencies of libsss_cert Label: +Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-dev

[SSSD] [sssd PR#5356][comment] krb5_child: Harden credentials validation code

2020-10-07 Thread simo5
URL: https://github.com/SSSD/sssd/pull/5356 Title: #5356: krb5_child: Harden credentials validation code simo5 commented: """ > Hi, > > thanks for the patch, it looks good. I just wonder if it might be risky to > use the pretty generic macro `TRUE` which other libraries we might include as >

[SSSD] [sssd PR#5303][-Waiting for review] tests: run TIER-0 multihost tests in PRCI

2020-10-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5303 Title: #5303: tests: run TIER-0 multihost tests in PRCI Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#5303][+Accepted] tests: run TIER-0 multihost tests in PRCI

2020-10-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5303 Title: #5303: tests: run TIER-0 multihost tests in PRCI Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.or

[SSSD] [sssd PR#5303][comment] tests: run TIER-0 multihost tests in PRCI

2020-10-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5303 Title: #5303: tests: run TIER-0 multihost tests in PRCI alexey-tikhonov commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/5303#issuecomment-704996921 ___ sssd-devel mailing li

[SSSD] [sssd PR#5356][comment] krb5_child: Harden credentials validation code

2020-10-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5356 Title: #5356: krb5_child: Harden credentials validation code sumit-bose commented: """ Hi, if anyone is concerned about older version of SSSD, setting: verify_ap_req_nofail = true in the `[libdefaults]` section of /etc/krb5.conf would have the s

[SSSD] [sssd PR#5356][comment] krb5_child: Harden credentials validation code

2020-10-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5356 Title: #5356: krb5_child: Harden credentials validation code sumit-bose commented: """ Hi, thanks for the patch, it looks good. I just wonder if it might be risky to use the pretty generic macro `TRUE` which other libraries we might include as well

[SSSD] [sssd PR#5356][opened] krb5_child: Harden credentials validation code

2020-10-07 Thread simo5
URL: https://github.com/SSSD/sssd/pull/5356 Author: simo5 Title: #5356: krb5_child: Harden credentials validation code Action: opened PR body: """ The krb5_verify_init_creds() call is used to validate the credentials just obtained by trying to acquire a ticket from the KDC that we can decrypti

[SSSD] [sssd PR#5347][comment] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups sumit-bose commented: """ > The patch does not apply to 1.16, please open separate PR if it is needed. Hi, I created https://github.com/SSSD/sssd/pull/5355 with the backport. bye, Sumit """

[SSSD] [sssd PR#5355][opened] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5355 Author: sumit-bose Title: #5355: ad: add ad_allow_remote_domain_local_groups Action: opened PR body: """ As the option name says if set to true Domain Local groups from remote domains won't be filtered out. This option is added to facilitate the migr

[SSSD] [sssd PR#5354][opened] build: remove libsss_certmap from dependencies of libsss_cert

2020-10-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5354 Author: sumit-bose Title: #5354: build: remove libsss_certmap from dependencies of libsss_cert Action: opened PR body: """ The internal library libsss_cert is used at various places and the dependency to the public library libsss_certmap is not neede

[SSSD] [sssd PR#5347][-Accepted] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#5347][-Ready to push] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: -Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#5347][closed] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Author: sumit-bose Title: #5347: ad: add ad_allow_remote_domain_local_groups Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5347/head:pr5347 git checkout pr5347 __

[SSSD] [sssd PR#5347][comment] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups pbrezina commented: """ The patch does not apply to 1.16, please open separate PR if it is needed. """ See the full comment at https://github.com/SSSD/sssd/pull/5347#issuecomment-704886750 ___

[SSSD] [sssd PR#5347][+Pushed] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.or

[SSSD] [sssd PR#5347][comment] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5347 * `master` * 4f65a8d15b8e5f3dd613e789d68f38e60e0addc5 - ad: add ad_allow_remote_domain_local_groups """ See the

[SSSD] [sssd PR#5347][+Ready to push] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: +Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#5347][-branch: sssd-1-16] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: -branch: sssd-1-16 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedo

[SSSD] [sssd PR#5347][-Ready to push] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: -Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#5347][+branch: sssd-1-16] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: +branch: sssd-1-16 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedo

[SSSD] [sssd PR#5341][comment] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5341 * `master` * d39b6580ad865a3e37d154ff5351527913d0aad7 - KCM: Fix access after free on shutdown """ See the full comme

[SSSD] [sssd PR#5341][+Pushed] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fed

[SSSD] [sssd PR#5341][-Accepted] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#5341][-Ready to push] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown Label: -Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#5341][closed] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Author: justin-stephenson Title: #5341: KCM: Fix access after free on shutdown Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5341/head:pr5341 git checkout pr5341

[SSSD] [sssd PR#5347][+Ready to push] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: +Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#5347][+Accepted] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#5347][-Waiting for review] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#5347][comment] ad: add ad_allow_remote_domain_local_groups

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5347 Title: #5347: ad: add ad_allow_remote_domain_local_groups pbrezina commented: """ Thank you. Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/5347#issuecomment-704884042 ___ sssd-devel mai

[SSSD] [sssd PR#5341][+Accepted] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#5341][comment] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown pbrezina commented: """ Thank you. Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/5341#issuecomment-704784487 ___ sssd-devel mailing

[SSSD] [sssd PR#5303][comment] tests: run TIER-0 multihost tests in PRCI

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5303 Title: #5303: tests: run TIER-0 multihost tests in PRCI pbrezina commented: """ Ready for review. """ See the full comment at https://github.com/SSSD/sssd/pull/5303#issuecomment-704784081 ___ sssd-devel mai

[SSSD] [sssd PR#5341][+Ready to push] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown Label: +Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#5303][+Waiting for review] tests: run TIER-0 multihost tests in PRCI

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5303 Title: #5303: tests: run TIER-0 multihost tests in PRCI Label: +Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#5341][-Changes requested] KCM: Fix access after free on shutdown

2020-10-07 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5341 Title: #5341: KCM: Fix access after free on shutdown Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos