[SSSD] [sssd PR#5401][-Waiting for review] authtok: add label to Smartcard token

2020-12-11 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#5401][comment] authtok: add label to Smartcard token

2020-12-11 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token alexey-tikhonov commented: """ Now in `pamsrv_p11.c::pack_cert_data()` we pass `label` to `pam_sss` twice: once as part of a `prompt` and once as a `label`, right? I have few very minor remarks, ple

[SSSD] [sssd PR#5401][comment] authtok: add label to Smartcard token

2020-12-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5401 Title: #5401: authtok: add label to Smartcard token sumit-bose commented: """ > `adds the certificate label to the Smartcard authtok item to about the > ambiguity` -- "to resolve the ambiguity"? Thanks, the latest version fixes the commit message. b

[SSSD] [sssd PR#5401][synchronized] authtok: add label to Smartcard token

2020-12-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5401 Author: sumit-bose Title: #5401: authtok: add label to Smartcard token Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5401/head:pr5401 git checkout pr5401 From 662984347c93a

[SSSD] [sssd PR#5407][comment] kcm: check socket path loaded from configuration

2020-12-11 Thread ikerexxe
URL: https://github.com/SSSD/sssd/pull/5407 Title: #5407: kcm: check socket path loaded from configuration ikerexxe commented: """ > I have several comments to the code. However, I'm sorry, but I don't think > this is correct way to solve it. This is not a problem of KCM only, but it > affects

[SSSD] [sssd PR#5367][+Accepted] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5367 Title: #5367: pam: add pam_sss_gss module for gssapi authentication Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#5367][-Waiting for review] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5367 Title: #5367: pam: add pam_sss_gss module for gssapi authentication Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...

[SSSD] [sssd PR#5367][comment] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5367 Title: #5367: pam: add pam_sss_gss module for gssapi authentication sumit-bose commented: """ The rawhide failure is expected and the rhel8 failure is due to an issue in the CI runner. """ See the full comment at https://github.com/SSSD/sssd/pull/53

[SSSD] [sssd PR#5367][comment] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread Gundersanne
URL: https://github.com/SSSD/sssd/pull/5367 Title: #5367: pam: add pam_sss_gss module for gssapi authentication Gundersanne commented: """ Hai, So cockpit's perspective to this patch as I understand it: Cockpit would build an s4u ccache using gssapi. This means that the ccache we'd use has th

[SSSD] [sssd PR#5367][comment] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5367 Title: #5367: pam: add pam_sss_gss module for gssapi authentication sumit-bose commented: """ Hi, thanks for your patience, ACK. I will set the label when the CI checks are done. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#5367][comment] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5367 Title: #5367: pam: add pam_sss_gss module for gssapi authentication pbrezina commented: """ Thank you. Here's a diff: ```diff diff --git a/src/man/pam_sss_gss.8.xml b/src/man/pam_sss_gss.8.xml index d4bb705e3..ce5b11bff 100644 --- a/src/man/pam_sss_gs

[SSSD] [sssd PR#5367][synchronized] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5367 Author: pbrezina Title: #5367: pam: add pam_sss_gss module for gssapi authentication Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5367/head:pr5367 git checkout pr5367 From

[SSSD] [sssd PR#5367][synchronized] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5367 Author: pbrezina Title: #5367: pam: add pam_sss_gss module for gssapi authentication Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5367/head:pr5367 git checkout pr5367 From

[SSSD] [sssd PR#5367][comment] pam: add pam_sss_gss module for gssapi authentication

2020-12-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5367 Title: #5367: pam: add pam_sss_gss module for gssapi authentication sumit-bose commented: """ Hi, thanks for the updates, all my tests are working well. There is a missing `` in the pam_sss_gss man page. I like the idea using `-` to unset an option,

[SSSD] [sssd PR#5432][closed] kcm: decode base64 encoded secret on upgrade path

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5432 Author: pbrezina Title: #5432: kcm: decode base64 encoded secret on upgrade path Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5432/head:pr5432 git checkout pr5432 __

[SSSD] [sssd PR#5432][-Ready to push] kcm: decode base64 encoded secret on upgrade path

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path Label: -Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fe

[SSSD] [sssd PR#5432][-Accepted] kcm: decode base64 encoded secret on upgrade path

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorah

[SSSD] [sssd PR#5432][+Pushed] kcm: decode base64 encoded secret on upgrade path

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#5432][comment] kcm: decode base64 encoded secret on upgrade path

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5432 * `master` * 18b98836ef8e337992f0ecb239a32b9c3cedb750 - kcm: decode base64 encoded secret on upgrade path "

[SSSD] [sssd PR#5432][+Ready to push] kcm: decode base64 encoded secret on upgrade path

2020-12-11 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5432 Title: #5432: kcm: decode base64 encoded secret on upgrade path Label: +Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fe