URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
Added few more covscan fixes.
@sumit-bose asked on IRC to add a way to 'cancel' authentication indicator
check in a subdomain. I added support for `-` to achieve that,
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
@alexey-tikhonov so I looked closer to covscan failure that prevents the clean
run. It is due to the following problem:
```
RPM build errors:
error: Empty %files file /b
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
Hi @abbra,
> I saw this issue myself and reported it to @pbrezina already. This is
> definitely a difference between 2.4.1 release and current git master beca
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
I used `+%define _empty_manifest_terminate_build 0` to work-around covscan
build issue and run a `version-diff-build`.
I can confirm that this PR doesn't bring
URL: https://github.com/SSSD/sssd/pull/5485
Author: pbrezina
Title: #5485: sudo: do not search by low usn value to improve performance
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5485/head:pr5485
git checkout pr548
URL: https://github.com/SSSD/sssd/pull/5485
Title: #5485: sudo: do not search by low usn value to improve performance
pbrezina commented:
"""
```diff
diff --git a/src/providers/ldap/sdap_sudo_refresh.c
b/src/providers/ldap/sdap_sudo_refresh.c
index 3441dd8fd..83f944ccf 100644
--- a/src/provider
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
pbrezina commented:
"""
> I used `+%define _empty_manifest_terminate_build 0` to work-around covscan
> build issue and run a `version-diff-build`.
> I can confirm that this PR doesn't bring
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
> Would using `%find_lang` macro help?
I don't know, probably. But lets discuss this in a dedicated email thread as
this has nothing to do with this PR and wi
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
I'll move covscan fixes to a separate PR.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-776650660
URL: https://github.com/SSSD/sssd/pull/5485
Title: #5485: sudo: do not search by low usn value to improve performance
alexey-tikhonov commented:
"""
Thank you. Covscan is clean. ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5485#issuecomment-776650874
_
URL: https://github.com/SSSD/sssd/pull/5485
Title: #5485: sudo: do not search by low usn value to improve performance
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lis
URL: https://github.com/SSSD/sssd/pull/5485
Title: #5485: sudo: do not search by low usn value to improve performance
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel
URL: https://github.com/SSSD/sssd/pull/5494
Author: abbra
Title: #5494: pam_sss_gss: support authentication indicators
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5494/head:pr5494
git checkout pr5494
From b48633f72
URL: https://github.com/SSSD/sssd/pull/5498
Author: abbra
Title: #5498: Covscan fixes
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5498/head:pr5498
git checkout pr5498
From 7a6cc2f05bd33b43d27e02489290f
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
Moved the covscan fixes to PR https://github.com/SSSD/sssd/pull/5498
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-776655139
_
URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of C
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
sumit-bose commented:
"""
Hi,
thanks for the update. In my testing I only found that inheriting the option
from configured to trusted domain does not work. Something like:
```
diff --git a
URL: https://github.com/SSSD/sssd/pull/5494
Author: abbra
Title: #5494: pam_sss_gss: support authentication indicators
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5494/head:pr5494
git checkout pr5494
From c15cd84dd
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
@sumit-bose thank you! I added this one line and re-pushed.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-776927996
__
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
sumit-bose commented:
"""
Thanks, ACK.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-777231022
___
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahost
21 matches
Mail list logo
