URL: https://github.com/SSSD/sssd/pull/5525
Title: #5525: Log performance improvements.
alexey-tikhonov commented:
"""
UPD: changed sizeof `last_time_str` to 128 to prevent warning:
```
../src/util/debug.c:314:13: note: ‘snprintf’ output between 18 and 73 bytes
into a destination of size 32
URL: https://github.com/SSSD/sssd/pull/5525
Author: alexey-tikhonov
Title: #5525: Log performance improvements.
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5525/head:pr5525
git checkout pr5525
From
URL: https://github.com/SSSD/sssd/pull/5450
Title: #5450: kcm: add support for kerberos tgt renewals
justin-stephenson commented:
"""
It looks like most the CI failures are unrelated to this PR, @sumit-bose could
you please confirm this?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5526
Title: #5526: Covscan fixes
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of
URL: https://github.com/SSSD/sssd/pull/5526
Author: alexey-tikhonov
Title: #5526: Covscan fixes
Action: opened
PR body:
"""
This is overtake of PR #5498 (based on
https://github.com/SSSD/sssd/pull/5498#issuecomment-789576996 comment)
Two patches were taken "as is".
Patch "symlink() expects
URL: https://github.com/SSSD/sssd/pull/5525
Title: #5525: Log performance improvements.
alexey-tikhonov commented:
"""
> From my point of view, this would complicate code for a very minor perf gain
But the way, frankly speaking more or less the same statement applies to a
second patch
URL: https://github.com/SSSD/sssd/pull/5513
Title: #5513: TESTS: test socket path when systemd activation
ikerexxe commented:
"""
Rebased to fix merge conflict.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5513#issuecomment-789664521
URL: https://github.com/SSSD/sssd/pull/5513
Author: ikerexxe
Title: #5513: TESTS: test socket path when systemd activation
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5513/head:pr5513
git checkout pr5513
From
URL: https://github.com/SSSD/sssd/pull/5525
Title: #5525: Log performance improvements.
alexey-tikhonov commented:
"""
> At this point, you cache the whole string. If it differs, you generate the
> whole string again. But most often the only thing that changes is only the
> last "seconds"
URL: https://github.com/SSSD/sssd/pull/5525
Title: #5525: Log performance improvements.
pbrezina commented:
"""
Very nice.
At this point, you cache the whole string. If it differs, you generate the
whole string again. But most often the only thing that changes is only the last
"seconds" part.
URL: https://github.com/SSSD/sssd/pull/5525
Title: #5525: Log performance improvements.
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes
abbra commented:
"""
I did receive them but had no time to fix. If you have some time, please feel
free to overtake this PR. I don't think I'll have much time until maybe mid
March.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5498
Title: #5498: Covscan fixes
alexey-tikhonov commented:
"""
Hi @abbra,
thanks again for the patches.
I had a couple of minor remarks/questions (please see inline) and just realized
that probably you didn't receive a notification for inline
13 matches
Mail list logo
