[SSSD] [sssd PR#5712][synchronized] Health and Support Analyzer - Add request log parsing utility

2021-07-16 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5712 Author: justin-stephenson Title: #5712: Health and Support Analyzer - Add request log parsing utility Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5712/head:pr5712 git che

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-07-16 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility justin-stephenson commented: """ > I think update of `man sssctl` with new feature description is missing. Thank you for the review. I don't see the actual sssctl commands li

[SSSD] [sssd PR#5715][comment] p11_child: Add missing newline after log message

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5715 Title: #5715: p11_child: Add missing newline after log message mzidek-gh commented: """ test_files_provider.py::test_realloc_groups FAILED Not related to this patch. """ See the full comment at https://github.com/SSSD/sssd/pull/5715#issuecomment-881

[SSSD] [sssd PR#5715][+Accepted] p11_child: Add missing newline after log message

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5715 Title: #5715: p11_child: Add missing newline after log message Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#5715][comment] p11_child: Add missing newline after log message

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5715 Title: #5715: p11_child: Add missing newline after log message mzidek-gh commented: """ ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/5715#issuecomment-881362915 ___ sssd-devel mailing

[SSSD] [sssd PR#5714][+Accepted] Fix minor typo: indicated -> indicate

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5714 Title: #5714: Fix minor typo: indicated -> indicate Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fe

[SSSD] [sssd PR#5714][comment] Fix minor typo: indicated -> indicate

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5714 Title: #5714: Fix minor typo: indicated -> indicate mzidek-gh commented: """ Obvious ACK :) Thanks. """ See the full comment at https://github.com/SSSD/sssd/pull/5714#issuecomment-881361629 ___ sssd-devel m

[SSSD] [sssd PR#5715][opened] p11_child: Add missing newline after log message

2021-07-16 Thread Jakuje
URL: https://github.com/SSSD/sssd/pull/5715 Author: Jakuje Title: #5715: p11_child: Add missing newline after log message Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5715/head:pr5715 git checkout pr571

[SSSD] [sssd PR#5709][+Changes requested] General: Hardeninig getenv() usage

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5709 Title: #5709: General: Hardeninig getenv() usage Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#5709][comment] General: Hardeninig getenv() usage

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5709 Title: #5709: General: Hardeninig getenv() usage mzidek-gh commented: """ Hi, I have one suggestion. Creating a utility function ```int sss_getenv(char *variable_name, char **_value)`` to use where SSSD now uses normal getenv. The function would int

[SSSD] [sssd PR#5709][comment] General: Hardeninig getenv() usage

2021-07-16 Thread mzidek-gh
URL: https://github.com/SSSD/sssd/pull/5709 Title: #5709: General: Hardeninig getenv() usage mzidek-gh commented: """ Hi, I have one suggestion. Creating a utility function ```int sss_getenv(char *variable_name, char **_value)`` to use where SSSD now uses normal getenv. The function would int

[SSSD] [sssd PR#5689][comment] Tests: Add tests ported from bash for AD Parameters Domain

2021-07-16 Thread sidecontrol
URL: https://github.com/SSSD/sssd/pull/5689 Title: #5689: Tests: Add tests ported from bash for AD Parameters Domain sidecontrol commented: """ I forgot, please go through the pep8 failures and correct them. """ See the full comment at https://github.com/SSSD/sssd/pull/5689#issuecomment-88126