URL: https://github.com/SSSD/sssd/pull/5735
Author: cryptomilk
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
Action: opened
PR body:
"""
None
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5735/head:pr5735
URL: https://github.com/SSSD/sssd/pull/5735
Author: cryptomilk
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5735/head:pr5735
git checkout pr57
URL: https://github.com/SSSD/sssd/pull/5735
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented:
"""
In general this feels cleaner but this would require inclusion of
`sss_chain_id.c` to `libsss_debug`:
```
libsss_debug.so: undefined reference to `
URL: https://github.com/SSSD/sssd/pull/5735
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented:
"""
In general this feels cleaner but this would require inclusion of
`sss_chain_id.c` to `libsss_debug`:
```
libsss_debug.so: undefined reference to `
URL: https://github.com/SSSD/sssd/pull/5735
Author: cryptomilk
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5735/head:pr5735
git checkout pr57
URL: https://github.com/SSSD/sssd/pull/5735
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented:
"""
Other functions in `sss_chain_id.c ` still need to access `debug_chain_id`
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5735#issu
URL: https://github.com/SSSD/sssd/pull/5735
Author: cryptomilk
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5735/head:pr5735
git checkout pr57
URL: https://github.com/SSSD/sssd/pull/5735
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented:
"""
I guess include of `stdint.h` is missing in `debug.h`
But, in general, I'm not sure the split of ` sss_chain_id_*` function to
different files is
URL: https://github.com/SSSD/sssd/pull/5735
Author: cryptomilk
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5735/head:pr5735
git checkout pr57
URL: https://github.com/SSSD/sssd/pull/5735
Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented:
"""
I guess include of `stdint.h` is missing in `debug.h`
But, in general, I'm not sure the split of ` sss_chain_id_*` functions to
different files is
URL: https://github.com/SSSD/sssd/pull/5712
Author: justin-stephenson
Title: #5712: Health and Support Analyzer - Add request log parsing utility
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5712/head:pr5712
git che
URL: https://github.com/SSSD/sssd/pull/5712
Title: #5712: Health and Support Analyzer - Add request log parsing utility
justin-stephenson commented:
"""
> Some issues I have noticed testing more use cases:
>
> 1. Login attempts with a bad password, log tracking is not really helpful
> to i
URL: https://github.com/SSSD/sssd/pull/5733
Title: #5733: Work around issue #5729
justin-stephenson commented:
"""
@joakim-tjernlund I created https://github.com/SSSD/sssd/pull/5734 to fix this
properly, sorry for the delay. Do you still want/need this workaround PR ?
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/5733
Title: #5733: Work around issue #5729
joakim-tjernlund commented:
"""
> @joakim-tjernlund I created #5734 to fix this properly, sorry for the delay.
> Do you still want/need this workaround PR ?
We can hold that PR for now. Just clarify that is OK fo
URL: https://github.com/SSSD/sssd/pull/5733
Title: #5733: Work around issue #5729
justin-stephenson commented:
"""
> > @joakim-tjernlund I created #5734 to fix this properly, sorry for the
> > delay. Do you still want/need this workaround PR ?
>
> We can hold that PR for now. Just clarify that
URL: https://github.com/SSSD/sssd/pull/5733
Title: #5733: Work around issue #5729
joakim-tjernlund commented:
"""
> > > @joakim-tjernlund I created #5734 to fix this properly, sorry for the
> > > delay. Do you still want/need this workaround PR ?
> >
> >
> > We can hold that PR for now. Just
URL: https://github.com/SSSD/sssd/pull/5733
Title: #5733: Work around issue #5729
justin-stephenson commented:
"""
> > > > @joakim-tjernlund I created #5734 to fix this properly, sorry for the
> > > > delay. Do you still want/need this workaround PR ?
> > >
> > >
> > > We can hold that PR for
URL: https://github.com/SSSD/sssd/pull/5731
Title: #5731: simple: fix memory leak while reloading lists - 1.16
alexey-tikhonov commented:
"""
Hi,
thank you for the backport PR.
It seems `cherry picked from commit` reference is wrong (should be
19c2c641e669ee1c08d6706c132625dc30e64609)
"""
Se
URL: https://github.com/SSSD/sssd/pull/5731
Title: #5731: simple: fix memory leak while reloading lists - 1.16
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@l
URL: https://github.com/SSSD/sssd/pull/5732
Title: #5732: AD: do not override LDAP data during GC lookups - 1.16
alexey-tikhonov commented:
"""
Thank you, ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5732#issuecomment-892930511
URL: https://github.com/SSSD/sssd/pull/5732
Title: #5732: AD: do not override LDAP data during GC lookups - 1.16
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fe
URL: https://github.com/SSSD/sssd/pull/5731
Author: sumit-bose
Title: #5731: simple: fix memory leak while reloading lists - 1.16
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5731/head:pr5731
git checkout pr5731
Fro
URL: https://github.com/SSSD/sssd/pull/5731
Title: #5731: simple: fix memory leak while reloading lists - 1.16
sumit-bose commented:
"""
Hi,
sorry, looks like I picked it from my own branch and not from master, new
version fixes it.
bye,
Sumit
"""
See the full comment at
https://github.com/
URL: https://github.com/SSSD/sssd/pull/5731
Title: #5731: simple: fix memory leak while reloading lists - 1.16
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@
URL: https://github.com/SSSD/sssd/pull/5731
Title: #5731: simple: fix memory leak while reloading lists - 1.16
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@l
25 matches
Mail list logo
