[SSSD] [sssd PR#5743][comment] ad: fallback to ldap if cldap is not available in libldap

URL: https://github.com/SSSD/sssd/pull/5743 Title: #5743: ad: fallback to ldap if cldap is not available in libldap justin-stephenson commented: """ Hi, I compiled openldap-2.5.6 without CLDAP support on fedora rawhide. * Before the PR: ~~~ (2021-08-17 14:25:02): [be[ad.vm]] [ad_cldap_ping_sen

[SSSD] [sssd PR#5734][comment] MONITOR: Return success from genconf with no config

URL: https://github.com/SSSD/sssd/pull/5734 Title: #5734: MONITOR: Return success from genconf with no config alexey-tikhonov commented: """ Looks good to me. """ See the full comment at https://github.com/SSSD/sssd/pull/5734#issuecomment-900339126 _

[SSSD] [sssd PR#5750][comment] fix compilation warnings

URL: https://github.com/SSSD/sssd/pull/5750 Title: #5750: fix compilation warnings elkoniu commented: """ I think @alexey-tikhonov is right, you can just change signature of `sss_getenv()` to return `const char*`. As this memory is released by talloc there will be no issue with calling `free()

[SSSD] [sssd PR#5746][+Accepted] p11_child: do_card partially fix loop exit condition (redo of #5705)

URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) sumit-bose commented: """ Hi, thanks for the patch, the commit message is looking good now. ACK bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#5734][synchronized] MONITOR: Return success from genconf with no config

URL: https://github.com/SSSD/sssd/pull/5734 Author: justin-stephenson Title: #5734: MONITOR: Return success from genconf with no config Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5734/head:pr5734 git checkout pr57

[SSSD] [sssd PR#5750][comment] fix compilation warnings

URL: https://github.com/SSSD/sssd/pull/5750 Title: #5750: fix compilation warnings alexey-tikhonov commented: """ > > About 2nd patch... Can't we just change signature of `sss_getenv()` to `... > > const char **_value`? (CC @elkoniu) > > I think the problem has philosophical nature. We are all

[SSSD] [sssd PR#5750][comment] fix compilation warnings

URL: https://github.com/SSSD/sssd/pull/5750 Title: #5750: fix compilation warnings elkoniu commented: """ > About 2nd patch... Can't we just change signature of `sss_getenv()` to `... > const char **_value`? (CC @elkoniu) I think the problem has philosophical nature. We are allocating data and

[SSSD] [sssd PR#5750][comment] fix compilation warnings

URL: https://github.com/SSSD/sssd/pull/5750 Title: #5750: fix compilation warnings alexey-tikhonov commented: """ About 2nd patch... Can't we just change signature of `sss_getenv()` to `... const char **_value`? (CC @elkoniu) """ See the full comment at https://github.com/SSSD/sssd/pull/5750#

[SSSD] [sssd PR#5750][synchronized] fix compilation warnings

URL: https://github.com/SSSD/sssd/pull/5750 Author: pbrezina Title: #5750: fix compilation warnings Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5750/head:pr5750 git checkout pr5750 From b4cd4dbb0c37fb322e12130bf022

[SSSD] [sssd PR#5750][opened] fix compilation warnings

URL: https://github.com/SSSD/sssd/pull/5750 Author: pbrezina Title: #5750: fix compilation warnings Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5750/head:pr5750 git checkout pr5750 From f53e803a274