[SSSD] [PATCH] dlopen-tests: Check the result of asprintf

2013-10-17 Thread Benjamin Franzke
According to asprintf(3) the content off errmsg is undefined on error, lets set it to NULL. 0001-dlopen-tests-Check-result-of-asprintf.patch Description: Binary data ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [PATCHES] Heimdal Support

2013-10-17 Thread Benjamin Franzke
Hi list, I've tried to use sssd with heimdal, there were some fixes to be done. Are you intrested in reviewing and integrating them? They are available at: https://git.bnfr.net/sssd/log/?h=heimdal-1 Note: They are on top of other build fixes i've send to the list (but thats visible in the log).

Re: [SSSD] [PATCHES] Heimdal Support

2013-10-17 Thread Benjamin Franzke
2013/10/17 Jakub Hrozek jhro...@redhat.com On Thu, Oct 17, 2013 at 01:35:08PM +0200, Benjamin Franzke wrote: Hi list, I've tried to use sssd with heimdal, there were some fixes to be done. Are you intrested in reviewing and integrating them? They are available at: https

Re: [SSSD] [PATCHES] Heimdal Support

2013-10-17 Thread Benjamin Franzke
2013/10/17 Stephen Gallagher sgall...@redhat.com -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/17/2013 07:35 AM, Benjamin Franzke wrote: Hi list, I've tried to use sssd with heimdal, there were some fixes to be done. Are you intrested in reviewing and integrating them

[SSSD] Build Fixes

2013-10-15 Thread Benjamin Franzke
Hi, These two patches add missing CFLAGS/LIBS to Makefile.am: [PATCH 1/2] BUILD: Link libsss_ad.so to sasl libs [PATCH 2/2] BUILD: Use OPENLDAP_CFLAGS instead of LDAP_CFLAGS This underlinking was noticed in make check (dlopen-test). Note: It failed for me since my openldap build had no sasl

Re: [SSSD] Build Fixes

2013-10-15 Thread Benjamin Franzke
Hi Lukas, 2013/10/15 Lukas Slebodnik lsleb...@redhat.com On (15/10/13 11:47), Benjamin Franzke wrote: Hi, These two patches add missing CFLAGS/LIBS to Makefile.am: [PATCH 1/2] BUILD: Link libsss_ad.so to sasl libs [PATCH 2/2] BUILD: Use OPENLDAP_CFLAGS instead of LDAP_CFLAGS ACK

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Benjamin Franzke
/14 Sumit Bose sb...@redhat.com On Sat, Oct 12, 2013 at 06:21:26AM +0200, Benjamin Franzke wrote: Hi Dmitri, 2013/10/11 Dmitri Pal d...@redhat.com On 10/11/2013 07:47 AM, Sumit Bose wrote: On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb

Re: [SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Benjamin Franzke
Hi Sumit, Should the spec file also include an /etc/alternatives integration, like cifs-utils has? http://pkgs.fedoraproject.org/cgit/cifs-utils.git/tree/cifs-utils.spec#n90 2013/10/14 Sumit Bose sb...@redhat.com and now with the patch included :-) On Mon, Oct 14, 2013 at 01:08:39PM +0200,

Re: [SSSD] Fwd: [sudo-users] objectClass=sudoRule vs objectClass=sudoRole in AD

2013-10-12 Thread Benjamin Franzke
From a quick grep: src/providers/ldap/ldap_opts.h:310 struct sdap_attr_map native_sudorule_map[] = { { ldap_sudorule_object_class, sudoRole, SYSDB_SUDO_CACHE_OC, NULL }, sudoRole is mapped to SYSDB_SUDO_CACHE_OC, which is: src/db/sysdb_sudo.h:36 #define SYSDB_SUDO_CACHE_OC

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Benjamin Franzke
2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed is attached. Thank you for the new version. I only have two comments left: +if (handle == NULL || errmsg

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Benjamin Franzke
Hi, Lukas 2013/10/11 Lukas Slebodnik lsleb...@redhat.com On (11/10/13 12:53), Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Benjamin Franzke
Hi Dmitri, 2013/10/11 Dmitri Pal d...@redhat.com On 10/11/2013 07:47 AM, Sumit Bose wrote: On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-09 Thread Benjamin Franzke
:13PM +0200, Benjamin Franzke wrote: 2013/10/7 Sumit Bose sb...@redhat.com On Thu, Oct 03, 2013 at 11:57:07PM +0200, Benjamin Franzke wrote: Hi Ben, this is really great, thank you very much for the contribution! As a matter of fact, we've been planning on delivering

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-07 Thread Benjamin Franzke
2013/10/7 Sumit Bose sb...@redhat.com On Thu, Oct 03, 2013 at 11:57:07PM +0200, Benjamin Franzke wrote: Hi Ben, this is really great, thank you very much for the contribution! As a matter of fact, we've been planning on delivering the CIFS plugin as part of the next release

[SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-03 Thread Benjamin Franzke
Hello list, I've started to implement a plugin for the cifs-utils idmap interface. Currently it lives in an own repository and can be build outside the sssd tree, thanks to the public sssd libraries libsss_idmap.so and libsss_nss_idmap.so: http://git.bnfr.net/cifs_idmap_sss/tree/cifs_idmap_sss.c