[SSSD] Re: [PATCH] PAM/KRB5: optional otp and password prompting

2016-07-06 Thread Nathaniel McCallum
Patch WFM and looks clean. My only question is on the overall prompting. Currently we have:   * 1FA:     - "Password"   * 2FA (required):     - "First Factor"     - "Second Factor"   * 2FA (optional):     - "First Factor or Password"     - "Second Factor, press return for Password authentication"

Re: [SSSD] [PATCH] Skip CHAUTHTOK_PRELIM when using OTPs

2014-12-03 Thread Nathaniel McCallum
On Tue, 2014-12-02 at 10:22 +0100, Jakub Hrozek wrote: > On Mon, Dec 01, 2014 at 05:16:49PM -0500, Nathaniel McCallum wrote: > > On Mon, 2014-12-01 at 22:15 +0100, Jakub Hrozek wrote: > > > Hi, > > > > > > the attached patch fixes chpass for OTP users

Re: [SSSD] [PATCH] Skip CHAUTHTOK_PRELIM when using OTPs

2014-12-02 Thread Nathaniel McCallum
On Tue, 2014-12-02 at 10:22 +0100, Jakub Hrozek wrote: > On Mon, Dec 01, 2014 at 05:16:49PM -0500, Nathaniel McCallum wrote: > > On Mon, 2014-12-01 at 22:15 +0100, Jakub Hrozek wrote: > > > Hi, > > > > > > the attached patch fixes chpass for OTP users

Re: [SSSD] [PATCH] Skip CHAUTHTOK_PRELIM when using OTPs

2014-12-01 Thread Nathaniel McCallum
On Mon, 2014-12-01 at 22:15 +0100, Jakub Hrozek wrote: > Hi, > > the attached patch fixes chpass for OTP users for me. I hope looking at > the ipaUserAuthType attribute is acceptable. > > The attribute is undocumented on purpose -- I don't see a reason for the > user to set this attribute to a di

Re: [SSSD] [PATCH] PAM: Remove authtok from PAM stack with OTP

2014-11-06 Thread Nathaniel McCallum
On Thu, 2014-10-23 at 11:28 +0200, Lukas Slebodnik wrote: > On (22/10/14 14:55), Nathaniel McCallum wrote: > >On Wed, 2014-10-22 at 17:43 +0200, Lukas Slebodnik wrote: > >> On (22/10/14 10:58), Nathaniel McCallum wrote: > >> >On Tue, 2014-10-21 at 20:34 +0200, Lukas S

Re: [SSSD] [PATCH] PAM: Remove authtok from PAM stack with OTP

2014-10-22 Thread Nathaniel McCallum
On Wed, 2014-10-22 at 17:43 +0200, Lukas Slebodnik wrote: > On (22/10/14 10:58), Nathaniel McCallum wrote: > >On Tue, 2014-10-21 at 20:34 +0200, Lukas Slebodnik wrote: > >> On (21/10/14 20:06), Jakub Hrozek wrote: > >> >On Tue, Oct 21, 2014 at 01:29:53PM -0400, Nathan

Re: [SSSD] [PATCH] PAM: Remove authtok from PAM stack with OTP

2014-10-22 Thread Nathaniel McCallum
On Tue, 2014-10-21 at 20:34 +0200, Lukas Slebodnik wrote: > On (21/10/14 20:06), Jakub Hrozek wrote: > >On Tue, Oct 21, 2014 at 01:29:53PM -0400, Nathaniel McCallum wrote: > >> On Tue, 2014-10-21 at 00:44 +0200, Lukas Slebodnik wrote: > >> > ehlo, > >> >

Re: [SSSD] [PATCH] PAM: Remove authtok from PAM stack with OTP

2014-10-21 Thread Nathaniel McCallum
On Tue, 2014-10-21 at 00:44 +0200, Lukas Slebodnik wrote: > ehlo, > > We remove the password from the PAM stack when OTP is used to make sure > that other pam modules (pam-gnome-keyring, pam_mount) cannot use it anymore > and have to request a password on their own. > > Resolves: https://fedoraho

Re: [SSSD] [PATCH] PAM: Remove authtok from PAM stack with OTP

2014-10-21 Thread Nathaniel McCallum
On Tue, 2014-10-21 at 09:59 +0200, Jakub Hrozek wrote: > On Tue, Oct 21, 2014 at 12:44:00AM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > We remove the password from the PAM stack when OTP is used to make sure > > that other pam modules (pam-gnome-keyring, pam_mount) cannot use it anymore > > an

Re: [SSSD] [PATCH] KRB5: Do not attemtp to get a TGT after a password change using OTP

2014-03-18 Thread Nathaniel McCallum
The patch looks okay to me. There is however, a spelling error in the commit message: "attemtp". - Original Message - > Hi, > > the attached patch fixes #2271. Kindly see the patch and the commit > message for more details. > > I tested password change w/o OTPs to make sure we don't reg

[SSSD] [PATCH] Fix krb5 changepw when FAST-only preauth methods are used (like OTP)

2014-03-07 Thread Nathaniel McCallum
fix this problem we removed the second option set used for changepw requests. All requests now use a single option set which is modified, if needed, for well-defined subsequent requests. >From bcbf3f26013afd58adc58d092149e58d1173e920 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Fri, 7

Re: [SSSD] [PATCH] IPA: Default to krb5_use_fast=try

2014-02-13 Thread Nathaniel McCallum
On Wed, 2014-02-12 at 14:08 +0100, Jakub Hrozek wrote: > On Wed, Feb 12, 2014 at 01:09:44PM +0100, Pavel Březina wrote: > > On 02/11/2014 05:32 PM, Jakub Hrozek wrote: > > >Hi, > > > > > >as agreed with Nathaniel, we should change the defaults of krb_use_fast > > >to "try" with the IPA backend and

[SSSD] rawhide test failure: krb5-utils-tests

2013-03-11 Thread Nathaniel McCallum
http://koji.fedoraproject.org/koji/taskinfo?taskID=5108784 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] BUILD: Fix cmocka

2013-03-11 Thread Nathaniel McCallum
On Mon, 2013-03-11 at 13:08 -0400, Stephen Gallagher wrote: > On Mon 11 Mar 2013 01:03:52 PM EDT, Lukas Slebodnik wrote: > > On (11/03/13 12:38), Stephen Gallagher wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > >> > >> We were not properly detecting that cmocka was unavailable. It > >

Re: [SSSD] [PATCH] Add support for krb5 1.11's responder callback.

2013-03-08 Thread Nathaniel McCallum
On Fri, 2013-03-08 at 12:18 -0500, Nathaniel McCallum wrote: > On Fri, 2013-03-08 at 13:09 +0100, Jakub Hrozek wrote: > > On Tue, Mar 05, 2013 at 03:58:54PM -0500, Nathaniel McCallum wrote: > > > This email provides the patch as an attachment. It also provides a more > &

Re: [SSSD] [PATCH] Add support for krb5 1.11's responder callback.

2013-03-08 Thread Nathaniel McCallum
On Fri, 2013-03-08 at 13:09 +0100, Jakub Hrozek wrote: > On Tue, Mar 05, 2013 at 03:58:54PM -0500, Nathaniel McCallum wrote: > > This email provides the patch as an attachment. It also provides a more > > substantial commit message and fixes one comment formatting issue. > >

Re: [SSSD] [PATCH] Add support for krb5 1.11's responder callback.

2013-03-08 Thread Nathaniel McCallum
On Fri, 2013-03-08 at 09:02 -0500, Simo Sorce wrote: > On Fri, 2013-03-08 at 13:09 +0100, Jakub Hrozek wrote: > > In general in code that uses talloc, functions that return an > > allocated > > value should accept TALLOC_CTX *mem_ctx as the first parameter. The > > output parameters should then be

Re: [SSSD] [PATCH] Add support for krb5 1.11's responder callback.

2013-03-05 Thread Nathaniel McCallum
This email provides the patch as an attachment. It also provides a more substantial commit message and fixes one comment formatting issue. Nathaniel >From a544ee1457c8fd928d7e4d8fd9a3c8ee7ced5503 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Tue, 5 Mar 2013 15:57:45 -0500 Subj

[SSSD] [PATCH] Add support for krb5 1.11's responder callback.

2013-03-05 Thread Nathaniel McCallum
--- src/external/krb5.m4| 1 + src/providers/krb5/krb5_auth.c | 2 +- src/providers/krb5/krb5_auth.h | 1 + src/providers/krb5/krb5_child.c | 201 src/providers/krb5/krb5_child_handler.c | 7 ++ src/sss_client/s