[SSSD] [sssd PR#397][comment] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2018-08-07 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS amitkumar50 commented: """ @fidencio Done Changes. """ See the full comment at https://github.com/SSSD/sssd/pull/397#issuecomment-410974638 __

[SSSD] [sssd PR#397][synchronized] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2018-08-07 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397 From

[SSSD] [sssd PR#397][synchronized] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2018-08-07 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397 From

[SSSD] [sssd PR#397][synchronized] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2018-08-01 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397 From

[SSSD] [sssd PR#599][comment] MAN: Give information regarding priority of ldap lookup

2018-06-22 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/599 Title: #599: MAN: Give information regarding priority of ldap lookup amitkumar50 commented: """ @fidencio I see all programlistings tags are kept at left in document. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#599][synchronized] MAN: Give information regarding priority of ldap lookup

2018-06-22 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/599 Author: amitkumar50 Title: #599: MAN: Give information regarding priority of ldap lookup Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/599/head:pr599 git checkout pr599

[SSSD] [sssd PR#599][opened] MAN: Give information regarding priority of ldap lookup

2018-06-14 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/599 Author: amitkumar50 Title: #599: MAN: Give information regarding priority of ldap lookup Action: opened PR body: """ This PR provides information about priority of lookup similar to as provided by function select_principal_from_keyt

[SSSD] [sssd PR#596][comment] [CONFDB]:[RFE] Add "enabled" option to domain section

2018-06-13 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section amitkumar50 commented: """ @jhrozek @mzidek-rh Yup Thanks for support. I would be working on this feature. @mzidek-rh can go a head to write up design doc .. T

[SSSD] [sssd PR#596][comment] [CONFDB]:[RFE] Add "enabled" option to domain section

2018-06-13 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/596 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section amitkumar50 commented: """ Hello @mzidek-rh Thanks for Comments. I read this from upstream ticket: > Instead of enabling domains using the "dom

[SSSD] [sssd PR#596][synchronized] [CONFDB]:[RFE] Add "enabled" option to domain section

2018-06-13 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/596 Author: amitkumar50 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/596/head:pr596 git checkout

[SSSD] [sssd PR#591][comment] sss_obuscate: Fix traceback while reading space in sssd.conf

2018-06-11 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/591 Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf amitkumar50 commented: """ @jhrozek I corrected the Title. Issue is same as mentioned in upstream. If we place space before any option in sssd.conf. And run ss

[SSSD] [sssd PR#591][edited] sss_obuscate: Fix traceback while reading space in sssd.conf

2018-06-11 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/591 Author: amitkumar50 Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf Action: edited Changed field: title Original value: """ Remove spaces after comment delimiters in the exam

[SSSD] [sssd PR#596][opened] [CONFDB]:[RFE] Add "enabled" option to domain section

2018-06-11 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/596 Author: amitkumar50 Title: #596: [CONFDB]:[RFE] Add "enabled" option to domain section Action: opened PR body: """ Upstream Request: Instead of enabling domains using the "domains" option in [sssd] section we co

[SSSD] [sssd PR#592][edited] Responder: simplify if-else structure in sss_dp_get_account_msg()

2018-06-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Author: amitkumar50 Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg() Action: edited Changed field: title Original value: """ too complex if-else structure in sss_dp_

[SSSD] [sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

2018-06-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Title: #592: too complex if-else structure in sss_dp_get_account_msg amitkumar50 commented: """ @fidencio Apologies Yes I know about template. I submit PR with template most time. Skipped this time. Will remember. >And thanks fo

[SSSD] [sssd PR#592][synchronized] too complex if-else structure in sss_dp_get_account_msg

2018-06-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Author: amitkumar50 Title: #592: too complex if-else structure in sss_dp_get_account_msg Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/592/head:pr592 git checkout pr592

[SSSD] [sssd PR#592][synchronized] too complex if-else structure in sss_dp_get_account_msg

2018-06-06 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Author: amitkumar50 Title: #592: too complex if-else structure in sss_dp_get_account_msg Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/592/head:pr592 git checkout pr592

[SSSD] [sssd PR#592][opened] too complex if-else structure in sss_dp_get_account_msg

2018-06-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Author: amitkumar50 Title: #592: too complex if-else structure in sss_dp_get_account_msg Action: opened PR body: """ The structure of if-else statements in sss_dp_get_account_msg become too complex. Replacing if-else with switch

[SSSD] [sssd PR#591][edited] Remove spaces after comment delimiters in the example config file

2018-06-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/591 Author: amitkumar50 Title: #591: Remove spaces after comment delimiters in the example config file Action: edited Changed field: body Original value: """ If sssd.conf file contains configuration directives preceded with whites

[SSSD] [sssd PR#591][opened] Remove spaces after comment delimiters in the example config file

2018-06-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/591 Author: amitkumar50 Title: #591: Remove spaces after comment delimiters in the example config file Action: opened PR body: """ If sssd.conf file contains configuration directives preceded with whitespace characters sss_obfuscate gene

[SSSD] [sssd PR#578][comment] proxy: proxy_child hardening

2018-05-23 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/578 Title: #578: proxy: proxy_child hardening amitkumar50 commented: """ sanitizing --domain argument is to be worked upon. your thoughts on this. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#578][opened] proxy: proxy_child hardening

2018-05-22 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/578 Author: amitkumar50 Title: #578: proxy: proxy_child hardening Action: opened PR body: """ proxy_child will call chdir("/"), umask(022) and reset the environment with clearenv(). The --domain argument to be sanitized. Re

[SSSD] [sssd PR#571][opened] MAN: Clarify how comments work in sssd.conf

2018-05-17 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/571 Author: amitkumar50 Title: #571: MAN: Clarify how comments work in sssd.conf Action: opened PR body: """ PR changes comment description in sssd.conf from: 'A line comment starts with a hash sign...' to 'A commen

[SSSD] [sssd PR#550][comment] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing amitkumar50 commented: """ @fidencio @justin-stephenson My pleasure on this. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#550][synchronized] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/550 Author: amitkumar50 Title: #550: MAN: Add sss-certmap man page regarding priority processing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/550/head:pr550 git checkout pr550

[SSSD] [sssd PR#550][synchronized] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/550 Author: amitkumar50 Title: #550: MAN: Add sss-certmap man page regarding priority processing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/550/head:pr550 git checkout pr550

[SSSD] [sssd PR#550][comment] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing amitkumar50 commented: """ @fidencio Done Changes. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#550][synchronized] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/550 Author: amitkumar50 Title: #550: MAN: Add sss-certmap man page regarding priority processing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/550/head:pr550 git checkout pr550

[SSSD] [sssd PR#550][synchronized] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/550 Author: amitkumar50 Title: #550: MAN: Add sss-certmap man page regarding priority processing Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/550/head:pr550 git checkout pr550

[SSSD] [sssd PR#550][opened] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/550 Author: amitkumar50 Title: #550: MAN: Add sss-certmap man page regarding priority processing Action: opened PR body: """ PR adds following text in PRIORITY section of man sss-certmap: The processing is stopped when a matched rule

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-09 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ Huge Thanks @fidencio for tmate session help. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#515][synchronized] sssctl: Showing help even when sssd not configured

2018-04-09 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Author: amitkumar50 Title: #515: sssctl: Showing help even when sssd not configured Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/515/head:pr515 git checkout pr515 From

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ @jhrozek @pbrezina Done the changes on my branch itself. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#515][synchronized] sssctl: Showing help even when sssd not configured

2018-04-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Author: amitkumar50 Title: #515: sssctl: Showing help even when sssd not configured Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/515/head:pr515 git checkout pr515 From

[SSSD] [sssd PR#387][comment] Setting ldap_sudo_include_regexp to false

2018-04-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/387 Title: #387: Setting ldap_sudo_include_regexp to false amitkumar50 commented: """ @jhrozek Yes. Are Only comments at this point are those provided by @fidencio on Sep 18, 2017 """ See the full comment at https:/

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-03-12 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ @jhrozek Done changes. Thanks """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#515][synchronized] sssctl: Showing help even when sssd not configured

2018-03-12 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Author: amitkumar50 Title: #515: sssctl: Showing help even when sssd not configured Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/515/head:pr515 git checkout pr515 From

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-03-02 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ @pbrezina Done thanks. But passed "help" value back 3 functions.. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#515][synchronized] sssctl: Showing help even when sssd not configured

2018-03-02 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Author: amitkumar50 Title: #515: sssctl: Showing help even when sssd not configured Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/515/head:pr515 git checkout pr515 From

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-03-01 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ @pbrezina Thanks. With /usr/local/sbin/sssctl cache-remove --help int help = 100; int opt; struct poptOption options[] = {

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-02-26 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ @pbrezina Thanks for review. As I understood I need to add `poptGetOptArg(poptContext context)` function inside `poptGetNextOpt()` to parse --h

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-02-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ Don't know why build check failed.. """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-02-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/515#issuecomment-366146010

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-02-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured amitkumar50 commented: """ @tiran Done changes. Thanks. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#515][synchronized] sssctl: Showing help even when sssd not configured

2018-02-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Author: amitkumar50 Title: #515: sssctl: Showing help even when sssd not configured Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/515/head:pr515 git checkout pr515 From

[SSSD] [sssd PR#515][opened] sssctl: Showing help even when sssd not configured

2018-02-14 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/515 Author: amitkumar50 Title: #515: sssctl: Showing help even when sssd not configured Action: opened PR body: """ Current Issue: On a clean and unconfigured system, it's not possible to use --help. `# dnf install sssd-tools` `#

[SSSD] [sssd PR#510][comment] MAN: Explain how does auto_private_groups affect subdomains

2018-02-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/510 Title: #510: MAN: Explain how does auto_private_groups affect subdomains amitkumar50 commented: """ Need to check IDM-AD sudomains, pointers would be helpful though. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#510][opened] MAN: Explain how does auto_private_groups affect subdomains

2018-02-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/510 Author: amitkumar50 Title: #510: MAN: Explain how does auto_private_groups affect subdomains Action: opened PR body: """ Fix explains how auto_private_groups affects subdomains. a. POSIX sudomains, gets inherited to subdomain

[SSSD] [sssd PR#481][comment] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-01-04 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn amitkumar50 commented: """ @fidencio Ack & Thanks :+1: """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#481][comment] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2017-12-20 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn amitkumar50 commented: """ @jhrozek Apologies for not checking logic already implemented in sssd for handling gcc attributes. I hope now I am direction of addres

[SSSD] [sssd PR#481][synchronized] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2017-12-20 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/481 Author: amitkumar50 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/481/head:pr481 git checkout pr481

[SSSD] [sssd PR#481][opened] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2017-12-18 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/481 Author: amitkumar50 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Action: opened PR body: """ -Wsuggest-attribute=noreturn warns about functions that might be candidates for attributes "pure", "

[SSSD] [sssd PR#463][comment] cache: Check for max_id/min_id in cache_req

2017-12-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Title: #463: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ @fidencio is this PR waiting for some.. tests. I cannot see what's contents on vm-031 page. """ See the full comment at ht

[SSSD] [sssd PR#463][comment] cache: Check for max_id/min_id in cache_req

2017-12-06 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Title: #463: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ @jhrozek I have squashed the PRs. On my work station all tests have passed now. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#463][synchronized] cache: Check for max_id/min_id in cache_req

2017-12-06 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Author: amitkumar50 Title: #463: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/463/head:pr463 git checkout pr463 From

[SSSD] [sssd PR#463][comment] cache: Check for max_id/min_id in cache_req

2017-12-06 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Title: #463: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ @jhrozek After merging 2 of your commits. test_ad_create_1way_trust_options fails. FAIL: ad_common_tests = [==] Ru

[SSSD] [sssd PR#436][comment] subdomains: Remove code only used in tests

2017-12-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/436 Title: #436: subdomains: Remove code only used in tests amitkumar50 commented: """ @jhrozek Yes I plan to update. But still not clear which tests to remove from test_ad_create_1way_trust_options(void **state) and test_ad_create_2wa

[SSSD] [sssd PR#463][synchronized] cache: Check for max_id/min_id in cache_req

2017-12-02 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Author: amitkumar50 Title: #463: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/463/head:pr463 git checkout pr463 From

[SSSD] [sssd PR#463][comment] cache: Check for max_id/min_id in cache_req

2017-12-02 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Title: #463: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ Opening new PR. I have wrongly commited an unrelevant PR on old and even long back, rebased it several times. I need to do bit of work on How to re

[SSSD] [sssd PR#449][closed] cache: Check for max_id/min_id in cache_req

2017-11-30 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/449/head:pr449 git checkout pr449

[SSSD] [sssd PR#463][comment] cache: Check for max_id/min_id in cache_req

2017-11-30 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Title: #463: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ Created Duplicate of https://github.com/SSSD/sssd/pull/449 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#463][opened] cache: Check for max_id/min_id in cache_req

2017-11-30 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/463 Author: amitkumar50 Title: #463: cache: Check for max_id/min_id in cache_req Action: opened PR body: """ The cache_req code doesn't check the min_id/max_id boundaries for requests by ID. Extending the .lookup_fn function in each

[SSSD] [sssd PR#449][synchronized] cache: Check for max_id/min_id in cache_req

2017-11-30 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/449/head:pr449 git checkout pr449 From

[SSSD] [sssd PR#449][synchronized] cache: Check for max_id/min_id in cache_req

2017-11-29 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/449/head:pr449 git checkout pr449 From

[SSSD] [sssd PR#457][comment] ipa: Removal of umask(0) in selinux_child

2017-11-26 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/457 Title: #457: ipa: Removal of umask(0) in selinux_child amitkumar50 commented: """ if libsemanage-2.6 does not need umask(0), if it is so. are we good to go on PR, or any additional changes are required. """ See the full

[SSSD] [sssd PR#457][comment] ipa: Removal of umask(0) in selinux_child

2017-11-23 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/457 Title: #457: ipa: Removal of umask(0) in selinux_child amitkumar50 commented: """ I believe this change would go into rhel-7.1 and above since mentioned bugzilla is fixed there. But yes this code should not go to rhel-6/Debian etc wh

[SSSD] [sssd PR#457][opened] ipa: Removal of umask(0) in selinux_child

2017-11-21 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/457 Author: amitkumar50 Title: #457: ipa: Removal of umask(0) in selinux_child Action: opened PR body: """ Code for calling umask(0) was added to address bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1186422. Now this bugzilla is

[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req

2017-11-16 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req amitkumar50 commented: """ @jhrozek Thanks for comments. So Shall I not work on this patch as of now? Or instead of EOK define `ERR_UID_OUTSIDE_RANGE` in `./src/util/util_errors

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-16 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format amitkumar50 commented: """ @fidencio Thanks I read inttypes.h convention here goes PRIuN. Done. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#448][synchronized] common: Correction of cache_req debug string ID format

2017-11-16 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Author: amitkumar50 Title: #448: common: Correction of cache_req debug string ID format Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/448/head:pr448 git checkout pr448 From

[SSSD] [sssd PR#449][synchronized] cache: Check for max_id/min_id in cache_req

2017-11-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/449/head:pr449 git checkout pr449 From

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format amitkumar50 commented: """ Are some changes required? Label is 'Changed Requested' """ See the full comment at https://github.com/S

[SSSD] [sssd PR#448][synchronized] common: Correction of cache_req debug string ID format

2017-11-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Author: amitkumar50 Title: #448: common: Correction of cache_req debug string ID format Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/448/head:pr448 git checkout pr448 From

[SSSD] [sssd PR#449][synchronized] cache: Check for max_id/min_id in cache_req

2017-11-14 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/449/head:pr449 git checkout pr449 From

[SSSD] [sssd PR#449][opened] cache: Check for max_id/min_id in cache_req

2017-11-13 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: opened PR body: """ The cache_req code doesn't check the min_id/max_id boundaries for requests by ID. Extending the .lookup_fn function in each

[SSSD] [sssd PR#448][opened] common: Correction of cache_req debug string ID format

2017-11-13 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Author: amitkumar50 Title: #448: common: Correction of cache_req debug string ID format Action: opened PR body: """ The cache-req debug string representation uses a wrong format specifier for by-ID requests. %d should be replaced

[SSSD] [sssd PR#436][comment] subdomains: Remove code only used in tests

2017-11-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/436 Title: #436: subdomains: Remove code only used in tests amitkumar50 commented: """ @fidencio Thanks for comments. Which specific tests to remove for, can you please guide. """ See the full comment at https:/

[SSSD] [sssd PR#436][opened] subdomains: Remove code only used in tests

2017-11-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/436 Author: amitkumar50 Title: #436: subdomains: Remove code only used in tests Action: opened PR body: """ When setting the ad_options in subdomain code there is an condition if (cdb == NULL || conf_path == NULL) True branch is only usabl

[SSSD] [sssd PR#397][synchronized] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2017-10-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397 From

[SSSD] [sssd PR#397][comment] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2017-10-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS amitkumar50 commented: """ Would be sending commit to remove 'domain->legacy_passwords' and related code. """ See the full comment at https://github.co

[SSSD] [sssd PR#397][opened] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2017-10-03 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: opened PR body: """ Since CONFDB_DOMAIN_LEGACY_PASS is legacy parameter that is rooted in pre-1.0 SSSD. We should just nuke it as we remove ot

[SSSD] [sssd PR#372][synchronized] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-25 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/372 Author: amitkumar50 Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/372/head:pr372 git checkout

[SSSD] [sssd PR#372][comment] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-25 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/372 Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary amitkumar50 commented: """ @jhrozek Done Thanks.. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

2017-09-25 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/386 Title: #386: intg: prevent "TypeError: must be type, not classobj" amitkumar50 commented: """ @lslebodn waiting for your comments.. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#386][comment] intg: prevent "TypeError: must be type, not classobj"

2017-09-20 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/386 Title: #386: intg: prevent "TypeError: must be type, not classobj" amitkumar50 commented: """ @fidencio So Would this PR title be suitable: `Changing class declaration from old to new-style type.` Or what title you would

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-09-20 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ @jhrozek Done rebase, squash, push -f. Thanks """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-09-20 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334

[SSSD] [sssd PR#372][comment] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-20 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/372 Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary amitkumar50 commented: """ @jhrozek dropped the line that documents ldap_user_certificate in modified_defaults. Please have a look. Thanks """

[SSSD] [sssd PR#372][synchronized] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-20 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/372 Author: amitkumar50 Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/372/head:pr372 git checkout

[SSSD] [sssd PR#387][opened] Setting ldap_sudo_include_regexp to false

2017-09-19 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/387 Author: amitkumar50 Title: #387: Setting ldap_sudo_include_regexp to false Action: opened PR body: """ Disable ldap_sudo_include_regexp option by default since this is costly operation for evaluation on ldap server. Resolves: https:/

[SSSD] [sssd PR#386][opened] intg: prevent "TypeError: must be type, not classobj"

2017-09-19 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/386 Author: amitkumar50 Title: #386: intg: prevent "TypeError: must be type, not classobj" Action: opened PR body: """ Changes - src/config/SSSDConfig/ipachangeconf.py:class IPAChangeConf: - src/sbus/sbus_codegen:class Base: - sr

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-09-19 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ @jhrozek Done changes thanks. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-09-19 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-09-19 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-09-19 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334

[SSSD] [sssd PR#372][comment] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-19 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/372 Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary amitkumar50 commented: """ @jhrozek Thanks for review. On latest master Its: ` ldap_user_certificate = userCer

[SSSD] [sssd PR#334][synchronized] Print a warning when enumeration is requested but disabled

2017-09-09 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334

[SSSD] [sssd PR#372][comment] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/372 Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary amitkumar50 commented: """ @jhrozek Done Changes. Thanks """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#372][synchronized] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/372 Author: amitkumar50 Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/372/head:pr372 git checkout

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-09-07 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ @jhrozek ./src/responder/common/responder.h struct resp_ctx { .. bool enumeration_warn_logged; }; ./src/responder/c

  1   2   >