[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-09-04 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) assafmo commented: """ Honestly I don't feel comfortable tinkering with this coee any more then I did. I can confirm that this patch did solve my

[SSSD] [sssd PR#5705][comment] p11_child: do_card partially fix loop exit condition

2021-08-15 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card partially fix loop exit condition assafmo commented: """ Closing, please see #5746 for resolution of this PR. """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5705][comment] p11_child: do_card partially fix loop exit condition

2021-08-15 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card partially fix loop exit condition assafmo commented: """ See #5746 for resolution of this PR. """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5746][opened] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-15 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5746 Author: assafmo Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) Action: opened PR body: """ This PR fixes the exit condition when searching for a token in p11_child/do_card, specifically in

[SSSD] [sssd PR#5705][closed] p11_child: do_card partially fix loop exit condition

2021-08-15 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Author: assafmo Title: #5705: p11_child: do_card partially fix loop exit condition Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5705/head:pr5705 git checkout pr5705

[SSSD] [sssd PR#5705][comment] p11_child: do_card partially fix loop exit condition

2021-08-02 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card partially fix loop exit condition assafmo commented: """ @sumit-bose Unfortunately I accidentally made this PR an orphan, so I cannot update the commit or push new commits. What do you want me to do? &q

[SSSD] [sssd PR#5705][edited] p11_child: do_card partially fix loop exit condition

2021-08-02 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Author: assafmo Title: #5705: p11_child: do_card partially fix loop exit condition Action: edited Changed field: title Original value: """ p11_child: do_card fix loop exit condition """

[SSSD] [sssd PR#5705][comment] p11_child: do_card fix loop exit condition

2021-07-14 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card fix loop exit condition assafmo commented: """ Also, the most recent version for Debian is v2.2.3 (8607b4822e4b6437d87dabf714882407f8959ef2), so here's the fix for it: ```diff [p11_child.patch.txt

[SSSD] [sssd PR#5705][edited] p11_child: do_card fix loop exit condition

2021-07-12 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Author: assafmo Title: #5705: p11_child: do_card fix loop exit condition Action: edited Changed field: body Original value: """ This commit fixes the exit condition when searching for a token in p11_child/do_card, specifically in

[SSSD] [sssd PR#5705][comment] p11_child: do_card fix loop exit condition

2021-07-12 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card fix loop exit condition assafmo commented: """ > Can we please remove the Closes: tag? This PR addresses one specific case, > but doesn't address the full scope of the problem described in #

[SSSD] [sssd PR#5705][opened] p11_child: do_card fix loop exit condition

2021-07-07 Thread assafmo
URL: https://github.com/SSSD/sssd/pull/5705 Author: assafmo Title: #5705: p11_child: do_card fix loop exit condition Action: opened PR body: """ This commit fixes the exit condition when searching for a token in p11_child/do_card, specifically in case a token is present in a