[SSSD] [sssd PR#5872][edited] p11_child: Fixes for authentication

2021-12-07 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5872 Author: dpward Title: #5872: p11_child: Fixes for authentication Action: edited Changed field: body Original value: """ This addresses several issues when searching for a token for (pre-)authentication, in particular when `--wait_fo

[SSSD] [sssd PR#5872][edited] p11_child: Fixes for authentication

2021-12-05 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5872 Author: dpward Title: #5872: p11_child: Fixes for authentication Action: edited Changed field: body Original value: """ This addresses several issues when searching for a token for (pre-)authentication, in particular when `--wait_fo

[SSSD] [sssd PR#5872][edited] p11_child: Fixes for authentication

2021-11-11 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5872 Author: dpward Title: #5872: p11_child: Fixes for authentication Action: edited Changed field: body Original value: """ This addresses several issues when searching for a token for (pre-)authentication, in particular when `--wait_fo

[SSSD] [sssd PR#5872][opened] p11_child: Fixes for authentication

2021-11-11 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5872 Author: dpward Title: #5872: p11_child: Fixes for authentication Action: opened PR body: """ This addresses several issues when searching for a token for (pre-)authentication, in particular when `--wait_for_card` is used. It includes

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-09-06 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) dpward commented: """ @assafmo Please see commit a9218fbe0b36ec2b1ffba70ba6028aabfcfe4ef8. """ See the full comment at https://

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-09-06 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) dpward commented: """ @assafmo Please see commit a036fc871588372a75c2111cf2075453f4a3eb7f. """ See the full comment at https://

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-09-04 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) dpward commented: """ @assafmo Please see commit df58e6e647834b1dae1e5f2906aadb546405dd86. """ See the full comment at https://

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-09-04 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) dpward commented: """ @assafmo Please see commit df58e6e647834b1dae1e5f2906aadb546405dd86 which fixes the regression caused by this patch. "&quo

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() dpward commented: """ I agree with the comments here, except to clarify: > As before p11_child can only wait on a single reader, in the old version it > was the

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() dpward commented: """ I agree with the comments here, except to clarify: > As before p11_child can only wait on a single reader, in the old version it > was the

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() dpward commented: """ I agree with the comments here, except to clarify: > As before p11_child can only wait on a single reader, in the old version it > was the

[SSSD] [sssd PR#5760][synchronized] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Author: dpward Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5760/head:pr5760 git checkout pr5760 From

[SSSD] [sssd PR#5760][edited] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-27 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Author: dpward Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Action: edited Changed field: body Original value: """ This restores the previous behavior of `--wait_for_card`, and fixes issues with initializat

[SSSD] [sssd PR#5760][synchronized] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-25 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Author: dpward Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5760/head:pr5760 git checkout pr5760 From

[SSSD] [sssd PR#5760][synchronized] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-25 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Author: dpward Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5760/head:pr5760 git checkout pr5760 From

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-25 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) dpward commented: """ @sumit-bose I don't think a simple patch can fix this. I think some re-factoring of `do_card()` and `wait_for_card()` is w

[SSSD] [sssd PR#5760][synchronized] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-25 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Author: dpward Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5760/head:pr5760 git checkout pr5760 From

[SSSD] [sssd PR#5760][synchronized] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-24 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Author: dpward Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5760/head:pr5760 git checkout pr5760 From

[SSSD] [sssd PR#5760][opened] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-24 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5760 Author: dpward Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Action: opened PR body: """ This restores the previous behavior of `--wait_for_card`, and fixes issues with initialization and cleanup. """

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-24 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) dpward commented: """ @sumit-bose I don't think a simple patch can fix this. I think some re-factoring of `do_card()` and `wait_for_card()` is w

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-23 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) dpward commented: """ FYI this change breaks some existing assumptions in the code after it When this code is reached: https://github.com

[SSSD] [sssd PR#5705][comment] p11_child: do_card fix loop exit condition

2021-07-12 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card fix loop exit condition dpward commented: """ Can we please remove the Closes: tag? This PR addresses one specific case, but doesn't address the full scope of the problem described in #5025.

[SSSD] [sssd PR#5705][comment] p11_child: do_card fix loop exit condition

2021-07-12 Thread dpward
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card fix loop exit condition dpward commented: """ Can we please remove the Closes: tag? This PR addresses one specific case, but doesn't address the full scope of the problem described in #5025. "

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2020-08-17 Thread dpward
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable dpward commented: """ > Although it is true @dpward that SHA-1 is allowed, you need to read the fine > print as well "for applications that do not require collision resist

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2020-08-17 Thread dpward
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable dpward commented: """ > But intention (perhaps wrong) was to get rid of sha-1 as much as possible as > its widespread deprecation feels anticipated. @alexey-tikhonov Could I

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2020-08-13 Thread dpward
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable dpward commented: """ @alexey-tikhonov @sumit-bose I think you are getting a few things confused here. The FIPS requirement you referenced states it is for **cryptographic** hashe

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2020-08-13 Thread dpward
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable dpward commented: """ @alexey-tikhonov @sumit-bose I think you are getting a few things confused here. The FIPS requirement you referenced is for **cryptographic** hashes. For ex

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2020-08-13 Thread dpward
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable dpward commented: """ @alexey-tikhonov @sumit-bose I think you are getting a few things confused here. The FIPS requirement you referenced is for **cryptographic** hashes. For ex

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2020-08-13 Thread dpward
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable dpward commented: """ @alexey-tikhonov @sumit-bose I think you are getting a few things confused here. The FIPS requirement you referenced is for **cryptographic** hashes. For ex

[SSSD] [sssd PR#837][comment] p11_child: make OCSP digest configurable

2020-08-13 Thread dpward
URL: https://github.com/SSSD/sssd/pull/837 Title: #837: p11_child: make OCSP digest configurable dpward commented: """ @alexey-tikhonov I think you are getting a few things confused here. The FIPS requirement you referenced is for **cryptographic** hashes. This pull request