[SSSD] [sssd PR#552][comment] GPO: Store security CSE settings of all applicable GPOs

2018-04-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/552 Title: #552: GPO: Store security CSE settings of all applicable GPOs fidencio commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#529][comment] SPEC: Move secrets responder to the package sssd-kcm

2018-04-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/529 Title: #529: SPEC: Move secrets responder to the package sssd-kcm fidencio commented: """ Based on @jhrozek's comment and considering we may even deprecate the secrets responder soon, I'm closing this PR as "Rejected&quo

[SSSD] [sssd PR#529][+Rejected] SPEC: Move secrets responder to the package sssd-kcm

2018-04-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/529 Title: #529: SPEC: Move secrets responder to the package sssd-kcm Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

2018-04-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/378 Title: #378: [RFC] Use GNULIB's compiler warning code fidencio commented: """ @pbrezina, thanks for the offer but there's no need, sincerely. :-) There's more important work to be done/reviewed at the moment and keeping the PR ope

[SSSD] [sssd PR#481][-Changes requested] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#481][-Blocked] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Label: -Blocked ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#481][closed] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Author: amitkumar50 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/481/head:pr481 git checkout pr481

[SSSD] [sssd PR#378][closed] [RFC] Use GNULIB's compiler warning code

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/378 Author: fidencio Title: #378: [RFC] Use GNULIB's compiler warning code Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/378/head:pr378 git checkout pr378

[SSSD] [sssd PR#481][+Rejected] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#481][comment] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn fidencio commented: """ @amitkumar50, as #378 has been closed as "Rejected", I'm taking the freedom to also close this one (as we won't work o

[SSSD] [sssd PR#378][+Rejected] [RFC] Use GNULIB's compiler warning code

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/378 Title: #378: [RFC] Use GNULIB's compiler warning code Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#550][comment] MAN: Add sss-certmap man page regarding priority processing

2018-04-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing fidencio commented: """ CI: http://vm-031.${abc}/logs/job/87/79/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#550][comment] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing fidencio commented: """ @amitkumar50, thanks for reworking the patch including mine and @justin-stephenson suggestion. I'm firing a CI build just for the sake

[SSSD] [sssd PR#550][+Accepted] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#550][comment] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing fidencio commented: """ You have an ACK from me. I'll wait for @justin-stephenson's review before adding the "Accepted Label" """ See

[SSSD] [sssd PR#550][-Changes requested] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#550][comment] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing fidencio commented: """ @justin-stephenson, may I ask you for a review as well? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#550][comment] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing fidencio commented: """ @justin-stephenson, may I ask you here for a review as well? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#550][+Changes requested] MAN: Add sss-certmap man page regarding priority processing

2018-04-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/550 Title: #550: MAN: Add sss-certmap man page regarding priority processing Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Here's the CI results for the current version of this patch set: http://vm-031.${abc}/logs/job/87/73/summary.html "&quo

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ I really failed to understand how to write a test without calling `sss_cache` to invalidate the cache as done in https://gith

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ > Have you considered changing the ldb expiration timestamps with pyldb or > shelling out to ldbmodify? I don't understan

[SSSD] [sssd PR#515][+Accepted] sssctl: Showing help even when sssd not configured

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured fidencio commented: """ CI: http://vm-031.${abc}/logs/job/87/72/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#128][synchronized] Fix group renaming issue when "id_provider = ldap" is set

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Author: fidencio Title: #128: Fix group renaming issue when "id_provider = ldap" is set Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/128/head:pr128 git checkout

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured fidencio commented: """ @amitkumar50, I'll just run our internal CI in your patches (for the sake of the process) and then I'll add the Accepted label (in case ev

[SSSD] [sssd PR#515][-Changes requested] sssctl: Showing help even when sssd not configured

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-04-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Your version seems okay, please, force-push it to my branch. Just a note: Although I do appreciate you took some time to come u

[SSSD] [sssd PR#528][comment] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used fidencio commented: """ CI got stuck due to rawhide failures, but those have been already reported :-/ The job was 8754. """

[SSSD] [sssd PR#528][+Accepted] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#544][+Accepted] IPA: Qualify the externalUser sudo attribute

2018-04-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/544 Title: #544: IPA: Qualify the externalUser sudo attribute Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#544][comment] IPA: Qualify the externalUser sudo attribute

2018-04-04 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/544 Title: #544: IPA: Qualify the externalUser sudo attribute fidencio commented: """ CI got stuck due to rawhide failures, but those have been already reported :-/ There was also a failure on find_uid tests, which fails every now and

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured fidencio commented: """ @amitkumar50, you have squashed **all** patches from @pbrezina into yours and that's not exactly the best way to go. We'd like to keep: Your patch

[SSSD] [sssd PR#548][opened] SERVER: Tone down shutdown messages for socket-activated responders

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/548 Author: fidencio Title: #548: SERVER: Tone down shutdown messages for socket-activated responders Action: opened PR body: """ When dealing with socket-activated responders, those may be shut themselves down after some inactivy per

[SSSD] [sssd PR#515][+Changes requested] sssctl: Showing help even when sssd not configured

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured fidencio commented: """ @amitkumar50, please, squash the patches suggested by Pavel and also add his other patch atop of yours. """ See the full comment at

[SSSD] [sssd PR#485][comment] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider fidencio commented: """ Sorry, I'm removing the "Accepted" label. Just for the process sake, @jhrozek or @justin-stephenson, would you mind to force push @jh

[SSSD] [sssd PR#485][-Accepted] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#528][comment] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used fidencio commented: """ I'll add back the "Accepted" label after getting results from our CI. """ See the full comment a

[SSSD] [sssd PR#528][-Accepted] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#543][+Accepted] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email

[SSSD] [sssd PR#543][comment] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 fidencio commented: """ Ack, thanks for the change! """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#464][comment] SYSDB: Properly handle name/gid override when using domain resolution order

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order fidencio commented: """ @sumit-bose, did you have the chance to take a look at https://github.com/SSSD/sssd/pull/464#issuecomment-373682283 ? &q

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @jhrozek, @pbrezina, @sumit-bose, @mzidek-rh ... Please, could someone take a look on https://github.com/SSSD/sssd/pull/1

[SSSD] [sssd PR#528][comment] NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/528 Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint refresh is used fidencio commented: """ @jhrozek, code looks fine by me. I'll fire a CI just for the process sake. @pbrezina, may I get your input here as

[SSSD] [sssd PR#539][comment] Make nss netgroup requests more robust

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/539 Title: #539: Make nss netgroup requests more robust fidencio commented: """ @jhrozek, did you get the results of the downstream tests? Is this PR good to go? """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#481][+Blocked] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn Label: +Blocked ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#481][comment] gcc warnings: Getting rid of -Wsuggest-attribute=noreturn

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn fidencio commented: """ As this PR is blocked by #378, I'm adding the "Blocked" label here. """ See the full comment at https://gi

[SSSD] [sssd PR#434][+Changes requested] sudo: require sudoHost attribute and do not merge rules

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/434 Title: #434: sudo: require sudoHost attribute and do not merge rules Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#485][comment] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider fidencio commented: """ I'm adding the "Accepted" label as per @pbrezina's review. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#485][+Accepted] Support alternative sources for the files provider

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/485 Title: #485: Support alternative sources for the files provider Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#543][+Changes requested] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-04-03 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#511][comment] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-03-30 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/511 Title: #511: Do not shutdown KCM/Secrets responders when activities are happening ... fidencio commented: """ @simo5, please, bear with me here. I'm a little bit confused about tevent_ops/tevent_signal/tevent_queue. Taking a look at

[SSSD] [sssd PR#546][+Blocked] TESTS: Re-add tests for `kdestroy -A`

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/546 Title: #546: TESTS: Re-add tests for `kdestroy -A` Label: +Blocked ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#546][comment] TESTS: Re-add tests for `kdestroy -A`

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/546 Title: #546: TESTS: Re-add tests for `kdestroy -A` fidencio commented: """ Yep, that's exactly the situation I could see the "blocked"/"depends-on" tag being used. """ See the full comment at

[SSSD] [sssd PR#511][comment] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/511 Title: #511: Do not shutdown KCM/Secrets responders when activities are happening ... fidencio commented: """ > Sorry for late comment, but should't you simply have a list of "inflight" > calls and take that in consid

[SSSD] [sssd PR#511][comment] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/511 Title: #511: Do not shutdown KCM/Secrets responders when activities are happening ... fidencio commented: """ I'm removing the "Changes Requested" label. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#511][-Changes requested] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/511 Title: #511: Do not shutdown KCM/Secrets responders when activities are happening ... Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email

[SSSD] [sssd PR#547][opened] Tests for #511

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/547 Author: fidencio Title: #547: Tests for #511 Action: opened PR body: """ We've decided to split the fix/tests in two different PRs. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/

[SSSD] [sssd PR#511][synchronized] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/511 Author: fidencio Title: #511: Do not shutdown KCM/Secrets responders when activities are happening ... Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/511/head:pr511 git

[SSSD] [sssd PR#511][comment] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/511 Title: #511: Do not shutdown KCM/Secrets responders when activities are happening ... fidencio commented: """ We have discussed in a phone meeting Today that we will go for this patches and decide about https://pagure.io/SSSD/sssd/i

[SSSD] [sssd PR#543][-Changes requested] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#543][comment] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 fidencio commented: """ @jhrozek, I've made the change and mistakenly pushed to your branch (well, not so bad in the end as it may sav

[SSSD] [sssd PR#543][synchronized] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Author: jhrozek Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#543][comment] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 fidencio commented: """ @jhrozek, please, just squash the following patch into your: ``` [ffidenci@pessoa sssd]$ cat 0001-fixup-SYS

[SSSD] [sssd PR#544][comment] IPA: Qualify the externalUser sudo attribute

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/544 Title: #544: IPA: Qualify the externalUser sudo attribute fidencio commented: """ @jhrozek, the patch itself looks good. Do we have downstream tests covering this situation? Wouldn't be worth it to open a RHEL bug for this issue? &q

[SSSD] [sssd PR#546][opened] TESTS: Re-add tests for `kdestroy -A`

2018-03-29 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/546 Author: fidencio Title: #546: TESTS: Re-add tests for `kdestroy -A` Action: opened PR body: """ This reverts commit 89726be5a05493b7af312f0be9ac5ecb6f1822e1 and also do a few modifications on it in order to ensure we don't have

[SSSD] [sssd PR#545][opened] Two small fixes for KCM

2018-03-28 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/545 Author: fidencio Title: #545: Two small fixes for KCM Action: opened PR body: """ Please, see each patch for a more complete description of each issue/fix. """ To pull the PR as Git branch: git remote add ghsssd ht

[SSSD] [sssd PR#533][comment] KCM's payload related patches

2018-03-27 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches fidencio commented: """ Patchset has been updated """ See the full comment at https://github.com/SSSD/sssd/pull/533#issuecomment-376672067

[SSSD] [sssd PR#533][-Changes requested] KCM's payload related patches

2018-03-27 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#533][synchronized] KCM's payload related patches

2018-03-27 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Author: fidencio Title: #533: KCM's payload related patches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/533/head:pr533 git checkout pr533 From

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data fidencio commented: """ @jhrozek, @pbrezina, Without looking at the code I'd give a +1 to Pavel's suggestion as well. However, taking a look at the code makes me

[SSSD] [sssd PR#543][+Changes requested] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-03-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#543][comment] SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1

2018-03-23 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/543 Title: #543: SYSDB: When marking an entry as expired, also set the originalModifyTimestamp to 1 fidencio commented: """ @jhrozek, CentOS CI failed due to pep8 issues. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data fidencio commented: """ That's another approach that can be taken. If you prefer taking this path, let me go for this. """ See the full comment at htt

[SSSD] [sssd PR#542][comment] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/542 Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data fidencio commented: """ Right, I'll do a complete check on that. I've already mentioned that it has to be checked in the issue I've opened ... About the json_loads()

[SSSD] [sssd PR#542][opened] KCM: Use json_loadb() when dealing with sss_iobuf data

2018-03-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/542 Author: fidencio Title: #542: KCM: Use json_loadb() when dealing with sss_iobuf data Action: opened PR body: """ As sss_iobuf data is *non* NULL terminated, we have to use json_loadb() passing the data's length instead of just u

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ CI: http://vm-031.${abc}/logs/job/87/16/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#537][-Changes requested] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ Fixed your request and fixed the el6 related issue. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537

[SSSD] [sssd PR#533][comment] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches fidencio commented: """ There's one issue found on fedora-rawhide by our CI but doesn't seem to be related to this patch: ``` Traceback (most recent call last): File "/usr/bin/py.test&qu

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ === FAILURES === __ test_sssctl_domain_

[SSSD] [sssd PR#537][+Changes requested] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ The failure is el6 specific. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ I also would like to ask for help in this one as I didn't find an easy way to test it without having to call "sss_ca

[SSSD] [sssd PR#538][+Pushed] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Title: #538: NSS: Remove dead code Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#538][-Accepted] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Title: #538: NSS: Remove dead code Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#538][closed] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Author: fidencio Title: #538: NSS: Remove dead code Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/538/head:pr538 git checkout pr538

[SSSD] [sssd PR#538][comment] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Title: #538: NSS: Remove dead code fidencio commented: """ master: 718bce1 """ See the full comment at https://github.com/SSSD/sssd/pull/538#issuecomment-373742223 ___ sssd-de

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537

[SSSD] [sssd PR#537][-Changes requested] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ @jhrozek, thanks for the review. I didn't know a ldb_transaction_start() would be a no-op in case a transaction has alrea

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537

[SSSD] [sssd PR#533][comment] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches fidencio commented: """ I've updated the patch set and moved the allocation of the payload under kcm_req_ctx. I'm removing the "Changes Requested" label. """ See the

[SSSD] [sssd PR#533][-Changes requested] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#533][synchronized] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Author: fidencio Title: #533: KCM's payload related patches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/533/head:pr533 git checkout pr533 From

<    1   2   3   4   5   6   7   8   9   10   >