URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
fidencio commented:
"""
@sumit-bose, thanks for your review.
Patch set has been updated with:
- Making use of the missing attribut
URL: https://github.com/SSSD/sssd/pull/472
Author: fidencio
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to s
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
fidencio commented:
"""
I've double-check with @justin-stephenson on IRC and he said:
18:30 justin-time: may we get your final word here:
htt
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
fidencio commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
fidencio commented:
"""
I'm adding back the "Changes Requested" label as per @amitkumar50's request.
"""
See the
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to s
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
fidencio commented:
"""
@sumit-bose, thanks for the suggestion.
Just for the record, what I've done in order to set
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an ema
URL: https://github.com/SSSD/sssd/pull/484
Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem()
fidencio commented:
"""
CI: http://vm-031.${abc}/logs/job/82/83/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/484
Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem()
fidencio commented:
"""
Okay. I've fired a CI build with this patch rebased atop of #378 and no
warnings have been introduced.
"""
See the full comme
URL: https://github.com/SSSD/sssd/pull/484
Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem()
fidencio commented:
"""
Ah, I forgot to mention, @lslebodn feel free to just ignore my comment, remove
the "Changes Requested" label and take over the review if
URL: https://github.com/SSSD/sssd/pull/486
Title: #486: TOOLS: Fix typo: exist -> exists
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/486
Title: #486: TOOLS: Fix typo: exist -> exists
fidencio commented:
"""
Adding the "Accepted" label as per @lslebodn's review.
"""
See the full comment at
https://gith
URL: https://github.com/SSSD/sssd/pull/484
Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem()
fidencio commented:
"""
> Can you see some warnings?
> Could you explain the reason?
On the system that I use I haven't seen any warning. Unfortunately #378 has
URL: https://github.com/SSSD/sssd/pull/486
Author: fidencio
Title: #486: TOOLS: Fix typo: exist -> exists
Action: opened
PR body:
"""
I've noticed the typo while working on #472
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.c
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
fidencio commented:
"""
I have failed to try to reproduce the issue with `sss_override` +
`sss_ssh_authorizedkeys`.
`sss_ove
URL: https://github.com/SSSD/sssd/pull/476
Title: #476: IPA: Handle empty nisDomainName
fidencio commented:
"""
Patch looks good, although I don't know how to reproduce the issue.
Would be possible to add steps to reproduce (either here or in the pagure
issue)?
ps: I'
URL: https://github.com/SSSD/sssd/pull/484
Title: #484: SDAP: skip builtin AD groups in sdap_save_grpmem()
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists
URL: https://github.com/SSSD/sssd/pull/481
Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn
fidencio commented:
"""
> "But still I am not sure should -Wsuggest-attribute=noreturn go in
> Makefile.am or elsewhere.."
@amitkumar50, please, t
URL: https://github.com/SSSD/sssd/pull/400
Author: fidencio
Title: #400: PAM: Avoid overwriting pam_status in _lookup_by_cert_done()
Action: opened
PR body:
"""
In case add_pam_cert_response() failed pam_status has to be set to
PAM_AUTHINFO_UNAVAIL. Although it's done
URL: https://github.com/SSSD/sssd/pull/481
Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn
fidencio commented:
"""
This PR depends on #378 and any warning removed should:
- Pass our internal CI (with patches from #378 applied)
- The manywarnings file
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to s
URL: https://github.com/SSSD/sssd/pull/480
Title: #480: MAN: Describe the constrains of ipa_server_mode better in the man
page
fidencio commented:
"""
Patch is good to me and, please, do **not** wait for my review to proceed with
this bug (as I'll be out for a few weeks
URL: https://github.com/SSSD/sssd/pull/479
Title: #479: MAN: Document that auth and access IPA and AD providers rely on
id_provider being set to the same type
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubsc
URL: https://github.com/SSSD/sssd/pull/479
Title: #479: MAN: Document that auth and access IPA and AD providers rely on
id_provider being set to the same type
fidencio commented:
"""
This patch is good as it is, no need of a debug message IMO.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/478
Title: #478: ifp: use realloc in ifp_list_ctx_remaining_capacity()
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedor
URL: https://github.com/SSSD/sssd/pull/478
Title: #478: ifp: use realloc in ifp_list_ctx_remaining_capacity()
fidencio commented:
"""
Although CI has not fully passed, the problem with rhel-7 is due to a missing
dep in the buildroot.
CI: http://vm-031.${abc}/logs/job/82/
URL: https://github.com/SSSD/sssd/pull/478
Title: #478: ifp: use realloc in ifp_list_ctx_remaining_capacity()
fidencio commented:
"""
@sumit-bose, patch works fine and behaves accordingly to expected.
I have one request about the commit message, though. May you mention in the
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@pbrezina, @jhrozek: This PR has been updated and is ready to be reviewed &
possibly merged.
I've opened two issues related to this PR:
http
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
CI: http://vm-031.abc.idm.lab.eng.brq.redhat.com/logs/job/82/70/summary.html
"""
See the full comment at
https://github.com/SSSD/s
URL: https://github.com/SSSD/sssd/pull/477
Author: fidencio
Title: #477: SYSDB: Return EOK in case a non-fatal issue happened
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/477/head:pr477
git checkout pr477
From
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
I've fired a CI build and I'm waiting for its results.
"""
See the full comment at
https://github.
URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@pbrezina, @jhrozek: This PR has been updated and is read to be reviewed &
possibly merged.
I've opened two issues related to this PR:
http
URL: https://github.com/SSSD/sssd/pull/378
Author: fidencio
Title: #378: [RFC] Use GNULIB's compiler warning code
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/378/head:pr378
git checkout pr378
URL: https://github.com/SSSD/sssd/pull/477
Author: fidencio
Title: #477: SYSDB: Return EOK in case a non-fatal issue happened
Action: opened
PR body:
"""
There may be the case where we aren't able to merge the timestamps from
the fast ts db, which are treated as non-fata
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
cigarette
"""
See the full comment at
https://github.com/SSSD/sssd/pull/379#issuecomment-351685924
___
sssd-devel mailing list -- sssd-devel@lists.
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Well, when a PR is not reviewed and the comments come with:
"Coding style was never a priority and I cannot see a reason why
core developer need to sped a time with fixing
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
As per @lslebodn's comments I understand that SSSD project has **no** interest
on this PR at the moment.
I've opened https://pagure.io/SSSD/sssd/issue/3605 and I&#x
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@li
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
fidencio commented:
"""
CI: http://vm-031.abc.idm.lab.eng.brq.redhat.com/logs/job/82/60/summary.html
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Hmm. And seems that I will have to re-work these patches as more new issues
have been added meanwhile this patch was stuck. :-/
We **really** have to have a better way to han
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
I have updated the patch set and fired a CI build.
I'd really appreciate if we can have this one pushed as soon as our internal CI
passes and then avoid having to fi
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
From
URL: https://github.com/SSSD/sssd/pull/474
Title: #474: p11_child: properly check results of CERT_VerifyCertificateNow
fidencio commented:
"""
Ack! spoore has verified that this patch properly solves the issue.
I'm waiting for our internal CI results ...
""&qu
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
fidencio commented:
"""
I have updated the patchset adding a patch solving the issue on the client side
as well.
I'm keeping
URL: https://github.com/SSSD/sssd/pull/472
Author: fidencio
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull
URL: https://github.com/SSSD/sssd/pull/473
Title: #473: Revert "intg: Disable add_remove tests"
fidencio commented:
"""
Adding the "Accepted" label as per mine and @mzidek-rh's review.
"""
See the full comment at
https
URL: https://github.com/SSSD/sssd/pull/473
Title: #473: Revert "intg: Disable add_remove tests"
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/471
Title: #471: Fix a few typos
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/471
Title: #471: Fix a few typos
fidencio commented:
"""
I have updated the patch set dropping the patch that was fixing the indentation.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/471
Author: fidencio
Title: #471: Fix a few typos
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/471/head:pr471
git checkout pr471
From c76ead5f5d8e7426768cbffd2f9cdfec93538ab6
URL: https://github.com/SSSD/sssd/pull/473
Title: #473: Revert "intg: Disable add_remove tests"
fidencio commented:
"""
Hmm. Seems okay by me. @mzidek-rh said in the past he'd spend some time trying
to figure out this issue and here I'm wondering whether he
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
fidencio commented:
"""
And actually I found out that my solution is incomplete and it only works on
the server side. :-/
Mor
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
fidencio commented:
"""
Let me add the "Changes Requested" label till I have the answer.
"""
See the
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an ema
URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
fidencio commented:
"""
That's a good question, @lslebodn, although I don't have the answer for that
right now. I'
URL: https://github.com/SSSD/sssd/pull/472
Author: fidencio
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's
removed from IPA
Action: opened
PR body:
"""
Those two patches provide a fix for https://pagure.io/SSSD/sssd/issue/3602.
When
URL: https://github.com/SSSD/sssd/pull/471
Author: fidencio
Title: #471: Fix a few typos
Action: opened
PR body:
"""
Those typos where found while navigating through the code ...
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/
URL: https://github.com/SSSD/sssd/pull/468
Title: #468: enable lookup of "sshPublicKey" for active directory
fidencio commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/468#issuecomment-350641800
__
URL: https://github.com/SSSD/sssd/pull/464
Title: #464: SYSDB: Properly handle name/gid override when using domain
resolution order
fidencio commented:
"""
@lslebodn, wow, thanks for the very good explanation.
I actually misread your first comment as "tests" inst
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
@amitkumar50, CI has passed (that's the content of the link) and the PR is
waiting for @jhrozek's review.
"""
See the full comme
URL: https://github.com/SSSD/sssd/pull/464
Title: #464: SYSDB: Properly handle name/gid override when using domain
resolution order
fidencio commented:
"""
Sure thing. I'd appreciate some guidance on how to write a valid test for this
case, considering it involves a
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-d
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
fidencio commented:
"""
In an IPA master:
- Without the patch:
```
[root@master7 ~]# getent passwd administra...@ad.ff
administra...@ad.ff:*:3788
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-d
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
fidencio commented:
"""
So let me remove the accepted label and properly do the manual test as this is
only reproduced in the server side.
&q
URL: https://github.com/SSSD/sssd/pull/467
Title: #467: nss-idmap: allow NULL result in *_timeout calls
fidencio commented:
"""
CI: http://vm-031.${abc}/logs/job/82/41/summary.html
Please, whoever pushes this patch add also @abbra as reviewer.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/467
Title: #467: nss-idmap: allow NULL result in *_timeout calls
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/467
Title: #467: nss-idmap: allow NULL result in *_timeout calls
fidencio commented:
"""
I'm firing a CI build.
Code-wise it looks good and **does** make sense to allow the result argument to
be NULL as in some cases the caller is ju
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-d
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
fidencio commented:
"""
Hmm. Seems that I can't reproduce the issue with my "One-way trust" setup.
OTOH, the issue has been confi
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
fidencio commented:
"""
CI:http://vm-031.${abc}/logs/job/82/40/summary.html
I'll run a manual test Tomorrow before adding the "Accepted&
URL: https://github.com/SSSD/sssd/pull/465
Title: #465: p11_child: make sure OCSP checks are done
fidencio commented:
"""
CI: http://vm-031.${abc}/logs/job/82/39/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/465
Title: #465: p11_child: make sure OCSP checks are done
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
fidencio commented:
"""
I've fired a CI build and will add the "Accepted" label as soon as I get the
results.
"""
URL: https://github.com/SSSD/sssd/pull/466
Title: #466: IPA: Include SYSDB_OBJECTCATEGORY, not OBJECTCLASS in cache search
results
fidencio commented:
"""
Looks fine by me.
Do you want to have an ACK from @sumit-bose as well or just mine is fine?
"""
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
CI: http://vm-031.${abc}/logs/job/82/37/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/465
Title: #465: p11_child: make sure OCSP checks are done
fidencio commented:
"""
Patch looks fine by me and has been tested by Scott Poore (who must be added as
reviewer as well) when this patch gets pushed.
I've just fired a CI bu
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
Okay, after talking to @amitkumar50 on IRC, he gave me the permission to force
push my changes on his branch.
New patchset has been updated and conf
URL: https://github.com/SSSD/sssd/pull/463
Author: amitkumar50
Title: #463: cache: Check for max_id/min_id in cache_req
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/463/head:pr463
git checkout pr463
From 7bdcb54201d
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
After the last patchset pushed to master this branch has a lot of conflicts.
In order to speed up the review process, I've rebased @amitkumar50'
URL: https://github.com/SSSD/sssd/pull/464
Title: #464: SYSDB: Properly handle name/gid override when using domain
resolution order
fidencio commented:
"""
Coverity: passed without issues!
Internal CI: also passed without issues ...
http://vm-031.${abc}/logs/job/82/16/summar
URL: https://github.com/SSSD/sssd/pull/464
Title: #464: SYSDB: Properly handle name/gid override when using domain
resolution order
fidencio commented:
"""
Coverity: passed without issues!
Internal CI: waiting for rawhide results, but all the other passed without
issues!
&q
URL: https://github.com/SSSD/sssd/pull/464
Author: fidencio
Title: #464: SYSDB: Properly handle name/gid override when using domain
resolution order
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/464/head:pr464
git
URL: https://github.com/SSSD/sssd/pull/464
Author: fidencio
Title: #464: SYSDB: Properly handle name/gid override when using domain
resolution order
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/464/head:pr464
git
URL: https://github.com/SSSD/sssd/pull/464
Author: fidencio
Title: #464: SYSDB: Properly handle name/gid override when using domain
resolution order
Action: opened
PR body:
"""
When using name/gid override together with domain resolution order the
mpg name/gid may be returned
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
fidencio commented:
"""
@amitkumar50, you don't have to **remove** tests from
test_ad_create_1way_trust_options and test_ad_create_2way_trust_options. What
you'll have
URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to
SSSD-1.13
fidencio commented:
"""
> Maybe, I do not know whether you used the same of IPA server for testing
> master and 1.13 but version of ipa-client sho
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
Opening new PR.
> I have wrongly commited an unrelevant PR on old and even long back, rebased
> it several times. I need to do bit of work on How
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
I'm removing the "Changes Requested" label and the patch has been update by
@amitkumar50 and I don't have any more comments to add (so
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedora
URL: https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/463#issuecomment-348881798
URL: https://github.com/SSSD/sssd/pull/458
Title: #458: overrides: fixes for sysdb_invalidate_overrides()
fidencio commented:
"""
Thanks! Added the "Accepted" label!
"""
See the full comment at
https://github.com/S
URL: https://github.com/SSSD/sssd/pull/458
Title: #458: overrides: fixes for sysdb_invalidate_overrides()
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahos
URL: https://github.com/SSSD/sssd/pull/458
Title: #458: overrides: fixes for sysdb_invalidate_overrides()
fidencio commented:
"""
Manual test went fine and our internal CI passed without issues.
CI: http://vm-031.${abc}/logs/job/82/02/summary.html
"""
801 - 900 of 2359 matches
Mail list logo
