[SSSD] [sssd PR#645][comment] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist jhrozek commented: """ Thank you for the review. I agree about documenting the issue, but at least RHEL-wise, it is not clear to me whi

[SSSD] [sssd PR#645][+Pushed] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-

[SSSD] [sssd PR#645][comment] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist jhrozek commented: """ * master: 945865ae16120ffade267227ca48cefd58822fd2 * sssd-1-16: e7e942ceb1f8402d00f5f14a9e065d3fc434b711 "&q

[SSSD] [sssd PR#645][closed] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Author: jhrozek Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/645/head:pr64

[SSSD] [sssd PR#652][+Accepted] Multihost-SanityTests: New test case for ssh login with KCM as default

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/652 Title: #652: Multihost-SanityTests: New test case for ssh login with KCM as default Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel

[SSSD] [sssd PR#652][-Changes requested] Multihost-SanityTests: New test case for ssh login with KCM as default

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/652 Title: #652: Multihost-SanityTests: New test case for ssh login with KCM as default Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to s

[SSSD] [sssd PR#651][comment] test-library: fixes related to KCM, TLS on Directory server

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/651 Title: #651: test-library: fixes related to KCM, TLS on Directory server jhrozek commented: """ LGTM. The commit still does too many things at once for my taste. I would prefer if you could split the commits into smaller ones that do

[SSSD] [sssd PR#651][+Accepted] test-library: fixes related to KCM, TLS on Directory server

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/651 Title: #651: test-library: fixes related to KCM, TLS on Directory server Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@list

[SSSD] [sssd PR#652][+Changes requested] Multihost-SanityTests: New test case for ssh login with KCM as default

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/652 Title: #652: Multihost-SanityTests: New test case for ssh login with KCM as default Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to s

[SSSD] [sssd PR#652][comment] Multihost-SanityTests: New test case for ssh login with KCM as default

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/652 Title: #652: Multihost-SanityTests: New test case for ssh login with KCM as default jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#651][comment] test-library: fixes related to KCM, TLS on Directory server

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/651 Title: #651: test-library: fixes related to KCM, TLS on Directory server jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/651#issuecomment-420273006 __

[SSSD] [sssd PR#642][closed] TESTS: Fixes to test library and add new test case for kcm.

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/642 Author: mrniranjan Title: #642: TESTS: Fixes to test library and add new test case for kcm. Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/642/head:pr642 git checkout pr642 ___

[SSSD] [sssd PR#642][+superseded] TESTS: Fixes to test library and add new test case for kcm.

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/642 Title: #642: TESTS: Fixes to test library and add new test case for kcm. Label: +superseded ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lis

[SSSD] [sssd PR#642][comment] TESTS: Fixes to test library and add new test case for kcm.

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/642 Title: #642: TESTS: Fixes to test library and add new test case for kcm. jhrozek commented: """ this PR is superseded by PR #651 and PR #652 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#645][+Accepted] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sss

[SSSD] [sssd PR#642][comment] TESTS: Fixes to test library and add new test case for kcm.

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/642 Title: #642: TESTS: Fixes to test library and add new test case for kcm. jhrozek commented: """ One pep8 error I see is `src/tests/python/sssd/testlib/common/libdirsrv.py:201:9: E265 block comment should start with '# '` &qu

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups jhrozek commented: """ I tried to point out places where I'm unsure about something so that the reviewer has hopefully a little easier job. ""&qu

[SSSD] [sssd PR#650][-Changes requested] Implement a hybrid mode of generating private groups

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lis

[SSSD] [sssd PR#650][synchronized] Implement a hybrid mode of generating private groups

2018-09-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Author: jhrozek Title: #650: Implement a hybrid mode of generating private groups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/650/head:pr650 git checkout pr650 From

[SSSD] [sssd PR#650][+Changes requested] Implement a hybrid mode of generating private groups

2018-09-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lis

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-09-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups jhrozek commented: """ CI failed because older libcheck versions don't support one check macro: ``` /var/lib/jenkins/workspace/ci/label/rhel7/src/tests/sysdb-

[SSSD] [sssd PR#650][opened] Implement a hybrid mode of generating private groups

2018-09-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Author: jhrozek Title: #650: Implement a hybrid mode of generating private groups Action: opened PR body: """ Related: https://pagure.io/SSSD/sssd/issue/3822 Design page PR: https://pagure.io/SSSD/docs/pull-request/72 Commit

[SSSD] [sssd PR#645][-Changes requested] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an ema

[SSSD] [sssd PR#645][comment] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist jhrozek commented: """ thanks I pushed a new version """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#645][synchronized] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Author: jhrozek Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/645/head:pr64

[SSSD] [sssd PR#639][closed] sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/639 Author: pbrezina Title: #639: sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/639/head:pr639 git

[SSSD] [sssd PR#639][+Pushed] sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/639 Title: #639: sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#639][comment] sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/639 Title: #639: sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module jhrozek commented: """ * master: * c895fa2449900f4abd1dce6bb62a45c52bbb12cf * ca50c40511f08c0f7c786598e

[SSSD] [sssd PR#647][+Pushed] sbus: register filter on new connection

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/647 Title: #647: sbus: register filter on new connection Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedo

[SSSD] [sssd PR#647][closed] sbus: register filter on new connection

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/647 Author: pbrezina Title: #647: sbus: register filter on new connection Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/647/head:pr647 git checkout pr647 _

[SSSD] [sssd PR#647][comment] sbus: register filter on new connection

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/647 Title: #647: sbus: register filter on new connection jhrozek commented: """ * master: 55d5b43543b5ef62322fe635fe8108410cb4ea77 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#647][+Accepted] sbus: register filter on new connection

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/647 Title: #647: sbus: register filter on new connection Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fe

[SSSD] [sssd PR#647][comment] sbus: register filter on new connection

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/647 Title: #647: sbus: register filter on new connection jhrozek commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/647#issuecomment-419117435 ___ s

[SSSD] [sssd PR#646][comment] proxy: access provider directly not through be_ctx

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx jhrozek commented: """ btw I'm seeing the crash with PR #647 applied..but only with the proxy domain, not e.g. IPA domain """ See the full comment at

[SSSD] [sssd PR#646][comment] proxy: access provider directly not through be_ctx

2018-09-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/646 Title: #646: proxy: access provider directly not through be_ctx jhrozek commented: """ This improves the situation in the sense that the proxy provider now works, but I'm seeing this crash on shutdown: ``` Sep 06 14:29:55 cli

[SSSD] [sssd PR#648][comment] GPO: Add gpo_implicit_deny option

2018-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/648 Title: #648: GPO: Add gpo_implicit_deny option jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/648#issuecomment-418878920 _

[SSSD] [sssd PR#647][comment] sbus: register filter on new connection

2018-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/647 Title: #647: sbus: register filter on new connection jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/647#issuecomment-418878831

[SSSD] [sssd PR#639][+Accepted] sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module

2018-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/639 Title: #639: sbus: fix sbus_message_bound_ref and add unit tests for sbus_message public module Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email t

[SSSD] [sssd PR#645][comment] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist jhrozek commented: """ self-nack on the grounds of a Coverity error: ``` sssd-2.0.99/src/util/sss_semanage.c:263:11: warning: 1st function

[SSSD] [sssd PR#645][+Changes requested] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an ema

[SSSD] [sssd PR#645][opened] SELINUX: Always add SELinux user to the semanage database if it doesn't exist

2018-09-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/645 Author: jhrozek Title: #645: SELINUX: Always add SELinux user to the semanage database if it doesn't exist Action: opened PR body: """ Previously, we tried to optimize too much and only set the SELinux user to Linux user mapping

[SSSD] [sssd PR#643][-Pushed] KCM: Don't error out if creating a new ID as the first step

2018-08-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/643 Title: #643: KCM: Don't error out if creating a new ID as the first step Label: -Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#643][closed] KCM: Don't error out if creating a new ID as the first step

2018-08-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/643 Author: jhrozek Title: #643: KCM: Don't error out if creating a new ID as the first step Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/643/head:pr643 git checkout

[SSSD] [sssd PR#643][+Pushed] KCM: Don't error out if creating a new ID as the first step

2018-08-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/643 Title: #643: KCM: Don't error out if creating a new ID as the first step Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#643][+Accepted] KCM: Don't error out if creating a new ID as the first step

2018-08-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/643 Title: #643: KCM: Don't error out if creating a new ID as the first step Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists

[SSSD] [sssd PR#643][comment] KCM: Don't error out if creating a new ID as the first step

2018-08-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/643 Title: #643: KCM: Don't error out if creating a new ID as the first step jhrozek commented: """ * master: 81dce19792cf300950411722d16b72f8816aecb0 """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#642][comment] TESTS: Fixes to test library and add new test case for kcm.

2018-08-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/642 Title: #642: TESTS: Fixes to test library and add new test case for kcm. jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/642#issuecomment-416863207 __

[SSSD] [sssd PR#643][opened] KCM: Don't error out if creating a new ID as the first step

2018-08-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/643 Author: jhrozek Title: #643: KCM: Don't error out if creating a new ID as the first step Action: opened PR body: """ We need to handle the case where the nextID operation is ran, but the secdb is totally empty, otherwise logins wi

[SSSD] [sssd PR#132][-Accepted] Add "Wants=" to sssd unit

2018-08-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/132 Title: #132: Add "Wants=" to sssd unit Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of C

[SSSD] [sssd PR#132][comment] Add "Wants=" to sssd unit

2018-08-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/132 Title: #132: Add "Wants=" to sssd unit jhrozek commented: """ I still found two issues: - with no sssd.conf, the nss service is still enabled in confdb, so it's started by the monitor and then also the socket-activated

[SSSD] [sssd PR#630][closed] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Author: jhrozek Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git

[SSSD] [sssd PR#630][+Pushed] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.

[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder jhrozek commented: """ * master: fcbedf46fcfc66f443afa3171036b4bc7bbd380b f74feb08b86e72eb3e098ed09

[SSSD] [sssd PR#611][+Pushed] Do not build the local provider by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#611][closed] Do not build the local provider by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Author: fidencio Title: #611: Do not build the local provider by default Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/611/head:pr611 git checkout pr611 __

[SSSD] [sssd PR#611][comment] Do not build the local provider by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default jhrozek commented: """ * master: 0e211b8ba30c3adcdeef21ca1339b194cbfffb04 82d51b7feba8df49df3f7a023d2b16aba26a858e b8946c46e04e8b5329e4d95f9a67b4a76f883bb2 c075e2865b2fbedb6a7eeb6a9

[SSSD] [sssd PR#611][comment] Do not build the local provider by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/611#issuecomment-412574313

[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder jhrozek commented: """ retest this please """ See the full comment at https:/

[SSSD] [sssd PR#611][comment] Do not build the local provider by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/611#issuecomment-412564711

[SSSD] [sssd PR#629][+Pushed] ldap: remove parallel requests from rfc2307bis

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/629 Title: #629: ldap: remove parallel requests from rfc2307bis Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o

[SSSD] [sssd PR#629][comment] ldap: remove parallel requests from rfc2307bis

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/629 Title: #629: ldap: remove parallel requests from rfc2307bis jhrozek commented: """ * master: 5dafa8177326e032503a3f8195eb0d0dd4cb1b15 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#629][closed] ldap: remove parallel requests from rfc2307bis

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/629 Author: fidencio Title: #629: ldap: remove parallel requests from rfc2307bis Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/629/head:pr629 git checkout pr629 __

[SSSD] [sssd PR#628][comment] providers: drop ldap_{init, }groups_use_matching_rule_in_chain support

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/628 Title: #628: providers: drop ldap_{init,}groups_use_matching_rule_in_chain support jhrozek commented: """ * master: 65bd6bf05d75c843e525f8bf89e9b75b02a2bfb7 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#628][+Pushed] providers: drop ldap_{init, }groups_use_matching_rule_in_chain support

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/628 Title: #628: providers: drop ldap_{init,}groups_use_matching_rule_in_chain support Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le

[SSSD] [sssd PR#628][closed] providers: drop ldap_{init, }groups_use_matching_rule_in_chain support

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/628 Author: fidencio Title: #628: providers: drop ldap_{init,}groups_use_matching_rule_in_chain support Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/628/head:pr628 git checkout pr62

[SSSD] [sssd PR#627][closed] providers: disable ldap_sudo_include_regexp by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/627 Author: fidencio Title: #627: providers: disable ldap_sudo_include_regexp by default Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/627/head:pr627 git checkout pr627 __

[SSSD] [sssd PR#627][comment] providers: disable ldap_sudo_include_regexp by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/627 Title: #627: providers: disable ldap_sudo_include_regexp by default jhrozek commented: """ * master; a2d543f61266f7ec0095a5395a4ea38c8e1426d5 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#627][+Pushed] providers: disable ldap_sudo_include_regexp by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/627 Title: #627: providers: disable ldap_sudo_include_regexp by default Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedora

[SSSD] [sssd PR#397][+Pushed] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fe

[SSSD] [sssd PR#397][comment] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/397 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS jhrozek commented: """ * master: 1adf2f982c28096ca03b9910a412a8a63559ec10 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#397][closed] cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/397 Author: amitkumar50 Title: #397: cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/397/head:pr397 git checkout pr397

[SSSD] [sssd PR#601][closed] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Author: pbrezina Title: #601: sbus: integrate sssd with sbus2 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/601/head:pr601 git checkout pr601 _

[SSSD] [sssd PR#601][+Pushed] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ * master: c0c8499b6ac36b44e3db7e8c1d44ce32f38662b5 3d1b6458568f3df4d5c192f432e73d65e4a9d293 7c1dd71c31faa00039f764af45a28e8668731769 5edba6ce412f5be57a36fac1a

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ I think this PR has gotten sufficient testing given its sheer size. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#601][+Accepted] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Cod

[SSSD] [sssd PR#638][opened] Explicitly add GPLv3+ license blob to several files

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/638 Author: jhrozek Title: #638: Explicitly add GPLv3+ license blob to several files Action: opened PR body: """ In the absence of an explicit license blob in a file, the default GPLv3+ license applies, but it's better to be explicit.

[SSSD] [sssd PR#637][comment] Relicense GPLv2 only files as GPLv3+

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/637 Title: #637: Relicense GPLv2 only files as GPLv3+ jhrozek commented: """ I think it's fine as long as the centos ci passes, realistically the only thing that could have break is pep8. """ See the full comment at ht

[SSSD] [sssd PR#636][comment] failover: tune up default timeouts

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/636 Title: #636: failover: tune up default timeouts jhrozek commented: """ 18 and 24 seem like /really/ long time outs. Can we use something lower? I can't imagine waiting for 24 seconds until sssd goes offline.. ""&qu

[SSSD] [sssd PR#637][opened] Relicense GPLv2 only files as GPLv3+

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/637 Author: jhrozek Title: #637: Relicense GPLv2 only files as GPLv3+ Action: opened PR body: """ This patchset is seemingly large, but only the license blobs were in fact changed. There is one patch per changed file. In most case

[SSSD] [sssd PR#628][+Accepted] providers: drop ldap_{init, }groups_use_matching_rule_in_chain support

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/628 Title: #628: providers: drop ldap_{init,}groups_use_matching_rule_in_chain support Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-

[SSSD] [sssd PR#611][comment] Do not build the local provider by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default jhrozek commented: """ Coverity and CI were OK """ See the full comment at https://github.com/SSSD/sssd/pull/611#issuecomment-412460335

[SSSD] [sssd PR#611][+Accepted] Do not build the local provider by default

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ And one more thing - after I ran make, I seem to have a newline in each of the generated files, e.g.: ``` diff --git a/src/responder/ifp/ifp_iface/sbus_ifp_arg

[SSSD] [sssd PR#601][-Changes requested] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ I can't figure that one either. Please create a ticket into 2.1 and resubmit the patches with the test disabled. btw the beaker test with the non-root user i

[SSSD] [sssd PR#635][+Accepted] sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/635 Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorah

[SSSD] [sssd PR#635][comment] sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys

2018-08-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/635 Title: #635: sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys jhrozek commented: """ LGTM, let's give CI time to finish """ See the full comment at https://github.com/SSS

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ I've started some more beaker test to be sure everything is OK before acking.. """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ No, sorry, please ignore. Coverity was telling me that these were "fixed", so these are false positives from the earlier code. """ See the

[SSSD] [sssd PR#601][+Changes requested] sbus: integrate sssd with sbus2

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ There are still some Coverity warnings: ``` Error: CLANG_WARNING: sssd-1.16.4/src/monitor/monitor.c:2138:9: warning: Value stored to 'ret' is never read #

[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder jhrozek commented: """ retest this please """ See the full comment at https:/

[SSSD] [sssd PR#611][comment] Do not build the local provider by default

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default jhrozek commented: """ I'll ack once coverity finishes """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#611][comment] Do not build the local provider by default

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/611 Title: #611: Do not build the local provider by default jhrozek commented: """ I wish we had more time to nuke the code completely, but not building it by default is a good start. We can remove the stuff completely in 2.1 ""&

[SSSD] [sssd PR#630][+postponed until sssd 2.0] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder Label: +postponed until sssd 2.0 ___ sssd-devel mailing list -- sssd-devel@l

[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder

2018-08-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder jhrozek commented: """ Thank you, I merged your patch. I also changed the patch that fixes to libsec

[SSSD] [sssd PR#634][opened] P11: Don't return int failure from a bool function

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/634 Author: jhrozek Title: #634: P11: Don't return int failure from a bool function Action: opened PR body: """ The functions return bool as per their prototype, but returning EINVAL on failure meant that EINVAL (typically 22) was con

[SSSD] [sssd PR#601][+Changes requested] sbus: integrate sssd with sbus2

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2

2018-08-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ Another issue revelaed by tests is that starting with `user=sssd` does not work at the moment.. """ See the full comment at https://github.com/S

<    8   9   10   11   12   13   14   15   16   17   >