URL: https://github.com/SSSD/sssd/pull/988
Title: #988: man: fix typos
miztake commented:
"""
Hi, @pbrezina
Thank you for your confirmation.
I understood that missing spaces is due to my environment.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/988
Title: #988: man: fix typos
miztake commented:
"""
Hi, @pbrezina
Thank you for your comment.
> May I ask you what distribution do you use?
I use CentOS 7.
I built sssd on CentOS 7.
# cat /etc/redhat-release
CentOS Linu
URL: https://github.com/SSSD/sssd/pull/988
Author: miztake
Title: #988: man: fix typos
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/988/head:pr988
git checkout pr988
From 2a22fff90acfa79a4996cd57bc734b70a0fcb0eb
URL: https://github.com/SSSD/sssd/pull/988
Author: miztake
Title: #988: man: fix typos
Action: opened
PR body:
"""
- add whitespace between words
- correct manpage reference
- correct wrong word
- capitalize the first letter
"""
To pull the PR as Git branc
URL: https://github.com/SSSD/sssd/pull/982
Author: miztake
Title: #982: monitor: Fix check process about multiple starts of sssd when
pidfile…
Action: opened
PR body:
"""
… remains
If PIDFile is invalid in sssd.service, pidfile remains if sssd terminates
abnormally.
Also,
URL: https://github.com/SSSD/sssd/pull/980
Author: miztake
Title: #980: Remove redundant header file inclusion
Action: opened
PR body:
"""
There are some source code including the same header file redundantly.
We remove these redundant header file inclusion.
"""
URL: https://github.com/SSSD/sssd/pull/974
Author: miztake
Title: #974: util/server: Fix the timing to close() the PID file
Action: opened
PR body:
"""
The PID file is closed just before pidfile function returns.
However, if close() is called immediately after read()/write(),
t
URL: https://github.com/SSSD/sssd/pull/931
Author: miztake
Title: #931: Fix memory leak about krb5 error message
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/931/head:pr931
git checkout pr931
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
miztake commented:
"""
Hi, @alexey-tikhonov san
PR#915 includes all of PR#931.
As a result, there are no additional fixes to PR#915.
I'll close this PR.
Thank you for your c
URL: https://github.com/SSSD/sssd/pull/937
Author: miztake
Title: #937: Unify the indentation to 4 spaces
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/937/head:pr937
git checkout pr937
URL: https://github.com/SSSD/sssd/pull/937
Title: #937: Unify the indentation to 4 spaces
miztake commented:
"""
mzidek-rh san,
Thank you for your polite comment.
I accept not to merge this PR.
Thank you for taking your time.
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/938
Title: #938: Don't use tabs for indentation
miztake commented:
"""
mzidek-rh san,
Thank you for your polite comment.
I missed the explanation below.
https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
All new c
URL: https://github.com/SSSD/sssd/pull/938
Title: #938: Don't use tabs for indentation
miztake commented:
"""
mzidek-rh san,
Thank you for your polite comment.
I missed the explanation below.
https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
URL: https://github.com/SSSD/sssd/pull/938
Author: miztake
Title: #938: Don't use tabs for indentation
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/938/head:pr938
git checkout
URL: https://github.com/SSSD/sssd/pull/938
Author: miztake
Title: #938: Don't use tabs for indentation
Action: opened
PR body:
"""
The Coding guidelines include the following:
https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
MUST: No tabs all
URL: https://github.com/SSSD/sssd/pull/937
Author: miztake
Title: #937: Unify the indentation to 4 spaces
Action: opened
PR body:
"""
The Coding guidelines include the following:
https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
MUST: No tabs all inden
URL: https://github.com/SSSD/sssd/pull/933
Author: miztake
Title: #933: Unify the indentation to 4 spaces
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/933/head:pr933
git checkout pr933
URL: https://github.com/SSSD/sssd/pull/933
Title: #933: Unify the indentation to 4 spaces
miztake commented:
"""
This PR alone cannot cover the 4 spaces indentation.
I'm sorry, but I'll close this PR once and organize it again.
# If you don't like many sources be
URL: https://github.com/SSSD/sssd/pull/933
Title: #933: Unify the indentation to 4 spaces
miztake commented:
"""
This PR alone cannot cover the 4 spaces indentation.
I'm sorry, but I'll close this PR once and organize it again.
If you don't like many sources be
URL: https://github.com/SSSD/sssd/pull/933
Author: miztake
Title: #933: Unify the indentation to 4 spaces
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/933/head:pr933
git checkout pr933
From
URL: https://github.com/SSSD/sssd/pull/933
Title: #933: Unify the indentation to 4 spaces
miztake commented:
"""
Added the following indentation fixes.
- sss_client/sudo/sss_sudo_response.c:199
- providers/ldap/ldap_auth.c:1405
- responder/common/negcache.c:1116
- r
URL: https://github.com/SSSD/sssd/pull/933
Author: miztake
Title: #933: Unify the indentation to 4 spaces
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/933/head:pr933
git checkout pr933
From
URL: https://github.com/SSSD/sssd/pull/933
Author: miztake
Title: #933: Unify the indentation to 4 spaces
Action: opened
PR body:
"""
The Coding guidelines include the following:
https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
MUST: No tabs all inden
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
miztake commented:
"""
Is this duplicate with PR#915?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/931#issuecomment-552153081
__
URL: https://github.com/SSSD/sssd/pull/931
Author: miztake
Title: #931: Fix memory leak about krb5 error message
Action: opened
PR body:
"""
krb5 error message obtained with sss_krb5_get_error_message() must be released
with sss_krb5_free_error_message().
It is not released
URL: https://github.com/SSSD/sssd/pull/927
Author: miztake
Title: #927: Add processing to save errno before outputting DEBUG
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/927/head:pr927
git checkout pr927
From
URL: https://github.com/SSSD/sssd/pull/927
Author: miztake
Title: #927: Add processing to save errno before outputting DEBUG
Action: opened
PR body:
"""
In some processes, DEBUG is output after a system call error, and errno is
returned.
errno should be saved before DEBUG i
URL: https://github.com/SSSD/sssd/pull/922
Author: miztake
Title: #922: Fix timing to save errno
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/922/head:pr922
git checkout pr922
From
URL: https://github.com/SSSD/sssd/pull/922
Author: miztake
Title: #922: Fix timing to save errno
Action: opened
PR body:
"""
The timing to save some errnos is after DEBUG output, not immediately after the
system call.
Fix to save errno before DEBUG output so that errno is not
URL: https://github.com/SSSD/sssd/pull/921
Author: miztake
Title: #921: util/server.c: fix handling when error occurs in waitpid()
Action: opened
PR body:
"""
-1 is returned if an error occurs in waitpid().
Fixed inappropriate error handling.
"""
To pull the PR
URL: https://github.com/SSSD/sssd/pull/917
Author: miztake
Title: #917: sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return
errno
Action: opened
PR body:
"""
sss_nss_timedloc() should return errno, but returns -1 if clock_gettime(2)
fails.
Fix sss_nss_timedlock()
31 matches
Mail list logo