[SSSD] [sssd PR#988][comment] man: fix typos

2020-03-03 Thread miztake
URL: https://github.com/SSSD/sssd/pull/988 Title: #988: man: fix typos miztake commented: """ Hi, @pbrezina Thank you for your confirmation. I understood that missing spaces is due to my environment. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#988][comment] man: fix typos

2020-02-25 Thread miztake
URL: https://github.com/SSSD/sssd/pull/988 Title: #988: man: fix typos miztake commented: """ Hi, @pbrezina Thank you for your comment. > May I ask you what distribution do you use? I use CentOS 7. I built sssd on CentOS 7. # cat /etc/redhat-release CentOS Linu

[SSSD] [sssd PR#988][synchronized] man: fix typos

2020-02-21 Thread miztake
URL: https://github.com/SSSD/sssd/pull/988 Author: miztake Title: #988: man: fix typos Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/988/head:pr988 git checkout pr988 From 2a22fff90acfa79a4996cd57bc734b70a0fcb0eb

[SSSD] [sssd PR#988][opened] man: fix typos

2020-02-16 Thread miztake
URL: https://github.com/SSSD/sssd/pull/988 Author: miztake Title: #988: man: fix typos Action: opened PR body: """ - add whitespace between words - correct manpage reference - correct wrong word - capitalize the first letter """ To pull the PR as Git branc

[SSSD][sssd PR#982][opened] monitor: Fix check process about multiple starts of sssd when pidfile…

2020-02-05 Thread miztake
URL: https://github.com/SSSD/sssd/pull/982 Author: miztake Title: #982: monitor: Fix check process about multiple starts of sssd when pidfile… Action: opened PR body: """ … remains If PIDFile is invalid in sssd.service, pidfile remains if sssd terminates abnormally. Also,

[SSSD] [sssd PR#980][opened] Remove redundant header file inclusion

2020-02-03 Thread miztake
URL: https://github.com/SSSD/sssd/pull/980 Author: miztake Title: #980: Remove redundant header file inclusion Action: opened PR body: """ There are some source code including the same header file redundantly. We remove these redundant header file inclusion. """

[SSSD] [sssd PR#974][opened] util/server: Fix the timing to close() the PID file

2020-01-25 Thread miztake
URL: https://github.com/SSSD/sssd/pull/974 Author: miztake Title: #974: util/server: Fix the timing to close() the PID file Action: opened PR body: """ The PID file is closed just before pidfile function returns. However, if close() is called immediately after read()/write(), t

[SSSD] [sssd PR#931][closed] Fix memory leak about krb5 error message

2019-11-22 Thread miztake
URL: https://github.com/SSSD/sssd/pull/931 Author: miztake Title: #931: Fix memory leak about krb5 error message Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/931/head:pr931 git checkout pr931

[SSSD] [sssd PR#931][comment] Fix memory leak about krb5 error message

2019-11-22 Thread miztake
URL: https://github.com/SSSD/sssd/pull/931 Title: #931: Fix memory leak about krb5 error message miztake commented: """ Hi, @alexey-tikhonov san PR#915 includes all of PR#931. As a result, there are no additional fixes to PR#915. I'll close this PR. Thank you for your c

[SSSD] [sssd PR#937][closed] Unify the indentation to 4 spaces

2019-11-14 Thread miztake
URL: https://github.com/SSSD/sssd/pull/937 Author: miztake Title: #937: Unify the indentation to 4 spaces Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/937/head:pr937 git checkout pr937

[SSSD] [sssd PR#937][comment] Unify the indentation to 4 spaces

2019-11-14 Thread miztake
URL: https://github.com/SSSD/sssd/pull/937 Title: #937: Unify the indentation to 4 spaces miztake commented: """ mzidek-rh san, Thank you for your polite comment. I accept not to merge this PR. Thank you for taking your time. """ See the full comment at https:/

[SSSD] [sssd PR#938][comment] Don't use tabs for indentation

2019-11-14 Thread miztake
URL: https://github.com/SSSD/sssd/pull/938 Title: #938: Don't use tabs for indentation miztake commented: """ mzidek-rh san, Thank you for your polite comment. I missed the explanation below. https://docs.pagure.org/SSSD.sssd/developers/coding_style.html All new c

[SSSD] [sssd PR#938][comment] Don't use tabs for indentation

2019-11-14 Thread miztake
URL: https://github.com/SSSD/sssd/pull/938 Title: #938: Don't use tabs for indentation miztake commented: """ mzidek-rh san, Thank you for your polite comment. I missed the explanation below. https://docs.pagure.org/SSSD.sssd/developers/coding_style.html

[SSSD] [sssd PR#938][closed] Don't use tabs for indentation

2019-11-14 Thread miztake
URL: https://github.com/SSSD/sssd/pull/938 Author: miztake Title: #938: Don't use tabs for indentation Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/938/head:pr938 git checkout

[SSSD] [sssd PR#938][opened] Don't use tabs for indentation

2019-11-13 Thread miztake
URL: https://github.com/SSSD/sssd/pull/938 Author: miztake Title: #938: Don't use tabs for indentation Action: opened PR body: """ The Coding guidelines include the following: https://docs.pagure.org/SSSD.sssd/developers/coding_style.html MUST: No tabs all

[SSSD] [sssd PR#937][opened] Unify the indentation to 4 spaces

2019-11-13 Thread miztake
URL: https://github.com/SSSD/sssd/pull/937 Author: miztake Title: #937: Unify the indentation to 4 spaces Action: opened PR body: """ The Coding guidelines include the following: https://docs.pagure.org/SSSD.sssd/developers/coding_style.html MUST: No tabs all inden

[SSSD] [sssd PR#933][closed] Unify the indentation to 4 spaces

2019-11-13 Thread miztake
URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/933/head:pr933 git checkout pr933

[SSSD] [sssd PR#933][comment] Unify the indentation to 4 spaces

2019-11-13 Thread miztake
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces miztake commented: """ This PR alone cannot cover the 4 spaces indentation. I'm sorry, but I'll close this PR once and organize it again. # If you don't like many sources be

[SSSD] [sssd PR#933][comment] Unify the indentation to 4 spaces

2019-11-13 Thread miztake
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces miztake commented: """ This PR alone cannot cover the 4 spaces indentation. I'm sorry, but I'll close this PR once and organize it again. If you don't like many sources be

[SSSD] [sssd PR#933][synchronized] Unify the indentation to 4 spaces

2019-11-12 Thread miztake
URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/933/head:pr933 git checkout pr933 From

[SSSD] [sssd PR#933][comment] Unify the indentation to 4 spaces

2019-11-12 Thread miztake
URL: https://github.com/SSSD/sssd/pull/933 Title: #933: Unify the indentation to 4 spaces miztake commented: """ Added the following indentation fixes. - sss_client/sudo/sss_sudo_response.c:199 - providers/ldap/ldap_auth.c:1405 - responder/common/negcache.c:1116 - r

[SSSD] [sssd PR#933][synchronized] Unify the indentation to 4 spaces

2019-11-12 Thread miztake
URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/933/head:pr933 git checkout pr933 From

[SSSD] [sssd PR#933][opened] Unify the indentation to 4 spaces

2019-11-11 Thread miztake
URL: https://github.com/SSSD/sssd/pull/933 Author: miztake Title: #933: Unify the indentation to 4 spaces Action: opened PR body: """ The Coding guidelines include the following: https://docs.pagure.org/SSSD.sssd/developers/coding_style.html MUST: No tabs all inden

[SSSD] [sssd PR#931][comment] Fix memory leak about krb5 error message

2019-11-09 Thread miztake
URL: https://github.com/SSSD/sssd/pull/931 Title: #931: Fix memory leak about krb5 error message miztake commented: """ Is this duplicate with PR#915? """ See the full comment at https://github.com/SSSD/sssd/pull/931#issuecomment-552153081 __

[SSSD] [sssd PR#931][opened] Fix memory leak about krb5 error message

2019-11-09 Thread miztake
URL: https://github.com/SSSD/sssd/pull/931 Author: miztake Title: #931: Fix memory leak about krb5 error message Action: opened PR body: """ krb5 error message obtained with sss_krb5_get_error_message() must be released with sss_krb5_free_error_message(). It is not released

[SSSD] [sssd PR#927][synchronized] Add processing to save errno before outputting DEBUG

2019-11-04 Thread miztake
URL: https://github.com/SSSD/sssd/pull/927 Author: miztake Title: #927: Add processing to save errno before outputting DEBUG Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/927/head:pr927 git checkout pr927 From

[SSSD] [sssd PR#927][opened] Add processing to save errno before outputting DEBUG

2019-11-04 Thread miztake
URL: https://github.com/SSSD/sssd/pull/927 Author: miztake Title: #927: Add processing to save errno before outputting DEBUG Action: opened PR body: """ In some processes, DEBUG is output after a system call error, and errno is returned. errno should be saved before DEBUG i

[SSSD] [sssd PR#922][synchronized] Fix timing to save errno

2019-10-31 Thread miztake
URL: https://github.com/SSSD/sssd/pull/922 Author: miztake Title: #922: Fix timing to save errno Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/922/head:pr922 git checkout pr922 From

[SSSD] [sssd PR#922][opened] Fix timing to save errno

2019-10-30 Thread miztake
URL: https://github.com/SSSD/sssd/pull/922 Author: miztake Title: #922: Fix timing to save errno Action: opened PR body: """ The timing to save some errnos is after DEBUG output, not immediately after the system call. Fix to save errno before DEBUG output so that errno is not

[SSSD] [sssd PR#921][opened] util/server.c: fix handling when error occurs in waitpid()

2019-10-30 Thread miztake
URL: https://github.com/SSSD/sssd/pull/921 Author: miztake Title: #921: util/server.c: fix handling when error occurs in waitpid() Action: opened PR body: """ -1 is returned if an error occurs in waitpid(). Fixed inappropriate error handling. """ To pull the PR

[SSSD] [sssd PR#917][opened] sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return errno

2019-10-25 Thread miztake
URL: https://github.com/SSSD/sssd/pull/917 Author: miztake Title: #917: sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return errno Action: opened PR body: """ sss_nss_timedloc() should return errno, but returns -1 if clock_gettime(2) fails. Fix sss_nss_timedlock()