Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-12 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/2009 09:29 PM, Dmitri Pal wrote: 8) in elapi_log.c, the check for handle-appname == NULL on line 228 should probably be moved before the TRACE_FLOW_STRING on line 225 as the trace macro tries to access the memory in handle-appname. Also

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-12 Thread Dmitri Pal
Jakub Hrozek wrote: On 08/11/2009 09:29 PM, Dmitri Pal wrote: 8) in elapi_log.c, the check for handle-appname == NULL on line 228 should probably be moved before the TRACE_FLOW_STRING on line 225 as the trace macro tries to access the memory in handle-appname. Also maybe it's OK to just

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-12 Thread Simo Sorce
On Wed, 2009-08-12 at 11:41 -0400, Dmitri Pal wrote: Ah! Ok, that makes sense. I opened a ticket (103) to review the collection, INI and ELAPI code about the use of errno. I tried not to make this mistake but it seems like I did and you caught it - good! But this grants a better, a more