Re: [SSSD] [PATCH] [RFC] refactor nested group processing

2013-02-21 Thread Pavel Březina
On 02/18/2013 02:40 PM, Pavel Březina wrote: On 02/15/2013 07:42 PM, Pavel Březina wrote: Happy weekend everyone, if you are bored you can look at this code. I believe noderef path is fully completed. I haven't tried it so far, it will not even compile - hopefully only because there are no func

Re: [SSSD] [PATCH] [RFC] refactor nested group processing

2013-02-13 Thread Jakub Hrozek
On Wed, Feb 13, 2013 at 03:53:10PM +0100, Pavel Březina wrote: > >When is the groups being saved? In sdap_nested_group_done() or in the > >consumer of sdap_nested_group_recv()? > > Groups are saved to sysdb at once in the consumer of _recv() > (current behaviour). I'm not against moving it to _don

Re: [SSSD] [PATCH] [RFC] refactor nested group processing

2013-02-13 Thread Pavel Březina
On 02/13/2013 02:24 PM, Jakub Hrozek wrote: On Wed, Feb 13, 2013 at 01:22:40PM +0100, Pavel Březina wrote: Hi, I started working on https://fedorahosted.org/sssd/ticket/1784 and I'd like to get some comments so I know I'm heading the right direction. *Current state:* There is one tevent request

Re: [SSSD] [PATCH] [RFC] refactor nested group processing

2013-02-13 Thread Jakub Hrozek
On Wed, Feb 13, 2013 at 01:22:40PM +0100, Pavel Březina wrote: > Hi, > I started working on https://fedorahosted.org/sssd/ticket/1784 and I'd > like to get some comments so I know I'm heading the right direction. > > *Current state:* > There is one tevent request per a nesting level. The request c

[SSSD] [PATCH] [RFC] refactor nested group processing

2013-02-13 Thread Pavel Březina
Hi, I started working on https://fedorahosted.org/sssd/ticket/1784 and I'd like to get some comments so I know I'm heading the right direction. *Current state:* There is one tevent request per a nesting level. The request continues with many "step" and other-named functions. The path is different