Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

2015-10-04 Thread Jakub Hrozek
> Works for me, > > ACK * master: 83ac838339d15192642e07710156a7c537f18248 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

2015-10-04 Thread Jakub Hrozek
On Fri, Oct 02, 2015 at 01:51:18PM +0200, Lukas Slebodnik wrote: > On (02/10/15 13:02), Lukas Slebodnik wrote: > >On (30/09/15 09:22), Jakub Hrozek wrote: > >>On Tue, Sep 29, 2015 at 08:28:30AM +0200, Lukas Slebodnik wrote: > >>> On (28/09/15 14:19), Jakub Hrozek wrote: > >>> >Hi, > >>> > > >>> >to

Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

2015-10-02 Thread Lukas Slebodnik
On (02/10/15 13:02), Lukas Slebodnik wrote: >On (30/09/15 09:22), Jakub Hrozek wrote: >>On Tue, Sep 29, 2015 at 08:28:30AM +0200, Lukas Slebodnik wrote: >>> On (28/09/15 14:19), Jakub Hrozek wrote: >>> >Hi, >>> > >>> >to activate this hook, copy it from contrib to .git/hooks and make sure >>> >the

Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

2015-10-02 Thread Lukas Slebodnik
On (30/09/15 09:22), Jakub Hrozek wrote: >On Tue, Sep 29, 2015 at 08:28:30AM +0200, Lukas Slebodnik wrote: >> On (28/09/15 14:19), Jakub Hrozek wrote: >> >Hi, >> > >> >to activate this hook, copy it from contrib to .git/hooks and make sure >> >the executable flag is on. Attempting to push a commit

Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

2015-09-30 Thread Jakub Hrozek
On Tue, Sep 29, 2015 at 08:28:30AM +0200, Lukas Slebodnik wrote: > On (28/09/15 14:19), Jakub Hrozek wrote: > >Hi, > > > >to activate this hook, copy it from contrib to .git/hooks and make sure > >the executable flag is on. Attempting to push a commit without > >Reviewed-By will then trigger an err

Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

2015-09-28 Thread Lukas Slebodnik
On (28/09/15 14:19), Jakub Hrozek wrote: >Hi, > >to activate this hook, copy it from contrib to .git/hooks and make sure >the executable flag is on. Attempting to push a commit without >Reviewed-By will then trigger an error. > Good idea. >If we want to be truly strict about not pushing commits wi

[SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

2015-09-28 Thread Jakub Hrozek
Hi, to activate this hook, copy it from contrib to .git/hooks and make sure the executable flag is on. Attempting to push a commit without Reviewed-By will then trigger an error. If we want to be truly strict about not pushing commits without a RB tag, then we need a server-side hook. >From 39166