-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/25/2010 01:35 PM, Sumit Bose wrote:
> On Thu, Mar 25, 2010 at 10:17:00AM -0400, Stephen Gallagher wrote:
> On 03/25/2010 09:56 AM, Sumit Bose wrote:
> NACK.
> Please consider the following two comments:
> - can you call free
On Thu, Mar 25, 2010 at 10:17:00AM -0400, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 03/25/2010 09:56 AM, Sumit Bose wrote:
> >> NACK.
> >
> >> Please consider the following two comments:
> >
> >> - can you call free(user_msg) just after do_pam_conversation
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/25/2010 09:56 AM, Sumit Bose wrote:
>> NACK.
>
>> Please consider the following two comments:
>
>> - can you call free(user_msg) just after do_pam_conversation() to avoid to
>> have
>> it two times?
>> - can you make buf in read_pipe_handler
On Wed, Mar 24, 2010 at 06:56:10AM -0400, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 03/24/2010 06:49 AM, Stephen Gallagher wrote:
> > On 03/23/2010 04:51 PM, Simo Sorce wrote:
> >> On Tue, 23 Mar 2010 16:38:57 -0400
> >> Stephen Gallagher wrote:
> >
> >>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/24/2010 06:49 AM, Stephen Gallagher wrote:
> On 03/23/2010 04:51 PM, Simo Sorce wrote:
>> On Tue, 23 Mar 2010 16:38:57 -0400
>> Stephen Gallagher wrote:
>
>>> +tempbuf = talloc_realloc(state, state->buf, uint8_t,
>>> +
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/23/2010 04:51 PM, Simo Sorce wrote:
> On Tue, 23 Mar 2010 16:38:57 -0400
> Stephen Gallagher wrote:
>
>> +tempbuf = talloc_realloc(state, state->buf, uint8_t,
>> + state->len + size);
>> +if(!temp
On Tue, 23 Mar 2010 16:38:57 -0400
Stephen Gallagher wrote:
> +tempbuf = talloc_realloc(state, state->buf, uint8_t,
> + state->len + size);
> +if(!tempbuf) {
> +tevent_req_error(req, ENOMEM);
> return;
> }
> +
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
The PAM standard allows for messages of any length to be returned
to the client. We were discarding all messages of length greater
than 255. This patch dynamically allocates the message buffers so
we can pass the complete message.
This resolves https:
