Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-15 Thread Sumit Bose
On Mon, Oct 14, 2013 at 01:05:22PM +0200, Sumit Bose wrote: On Mon, Oct 14, 2013 at 11:00:44AM +0200, Benjamin Franzke wrote: Oh, sorry, I shared an old branch between my devel machine and the testing virtual machine, where i did some other changes, which i merged later on, which caused

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Sumit Bose
On Fri, Oct 11, 2013 at 05:08:17PM -0400, Dmitri Pal wrote: On 10/11/2013 07:47 AM, Sumit Bose wrote: On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Sumit Bose
On Sat, Oct 12, 2013 at 06:21:26AM +0200, Benjamin Franzke wrote: Hi Dmitri, 2013/10/11 Dmitri Pal d...@redhat.com On 10/11/2013 07:47 AM, Sumit Bose wrote: On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Benjamin Franzke
Oh, sorry, I shared an old branch between my devel machine and the testing virtual machine, where i did some other changes, which i merged later on, which caused this. Sorry.. I've merge the changes again.. And gone through the notes in this thread, to ensure they are all included now.

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Sumit Bose
On Mon, Oct 14, 2013 at 11:00:44AM +0200, Benjamin Franzke wrote: Oh, sorry, I shared an old branch between my devel machine and the testing virtual machine, where i did some other changes, which i merged later on, which caused this. Sorry.. I've merge the changes again.. And gone through the

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Sumit Bose
On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed is attached. Thank you for the new version. I only have two comments left: +if (handle == NULL || errmsg == NULL) { +*errmsg = strerror(EINVAL); you

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Benjamin Franzke
2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed is attached. Thank you for the new version. I only have two comments left: +if (handle == NULL || errmsg ==

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Sumit Bose
On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed is attached. Thank you for the new

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Lukas Slebodnik
On (11/10/13 12:53), Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed is attached. Thank you for the new version. I only have two comments

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Sumit Bose
On Fri, Oct 11, 2013 at 03:36:13PM +0200, Lukas Slebodnik wrote: On (11/10/13 12:53), Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Benjamin Franzke
Hi, Lukas 2013/10/11 Lukas Slebodnik lsleb...@redhat.com On (11/10/13 12:53), Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed is

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Lukas Slebodnik
On (11/10/13 16:23), Benjamin Franzke wrote: Hi, Lukas 2013/10/11 Lukas Slebodnik lsleb...@redhat.com On (11/10/13 12:53), Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Dmitri Pal
On 10/11/2013 07:47 AM, Sumit Bose wrote: On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your review! snip The patch with your concers fixed is attached.

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-11 Thread Benjamin Franzke
Hi Dmitri, 2013/10/11 Dmitri Pal d...@redhat.com On 10/11/2013 07:47 AM, Sumit Bose wrote: On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: 2013/10/11 Sumit Bose sb...@redhat.com On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: Thanks for your

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-10 Thread Sumit Bose
On Wed, Oct 09, 2013 at 03:50:11PM +0200, Benjamin Franzke wrote: Hi Sumit, Sorry for the delay, got sidetracked by trying to find an appropriate way to handle the well known sids etc.. But thanks to your reminder I got over to do the integration into sssd's autoconf/make now :) So here is

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-09 Thread Benjamin Franzke
Hi Sumit, Sorry for the delay, got sidetracked by trying to find an appropriate way to handle the well known sids etc.. But thanks to your reminder I got over to do the integration into sssd's autoconf/make now :) So here is the patch as an attachment. (as recommended by the contrib page - but if

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-07 Thread Benjamin Franzke
2013/10/7 Sumit Bose sb...@redhat.com On Thu, Oct 03, 2013 at 11:57:07PM +0200, Benjamin Franzke wrote: Hi Ben, this is really great, thank you very much for the contribution! As a matter of fact, we've been planning on delivering the CIFS plugin as part of the next release:

[SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-03 Thread Benjamin Franzke
Hello list, I've started to implement a plugin for the cifs-utils idmap interface. Currently it lives in an own repository and can be build outside the sssd tree, thanks to the public sssd libraries libsss_idmap.so and libsss_nss_idmap.so: http://git.bnfr.net/cifs_idmap_sss/tree/cifs_idmap_sss.c

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-03 Thread Jakub Hrozek
On Thu, Oct 03, 2013 at 06:14:41PM +0200, Benjamin Franzke wrote: Hello list, I've started to implement a plugin for the cifs-utils idmap interface. Currently it lives in an own repository and can be build outside the sssd tree, thanks to the public sssd libraries libsss_idmap.so and