-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/09/2009 07:23 AM, Martin Nagy wrote:
> On Sat, 2009-11-07 at 13:22 -0500, Simo Sorce wrote:
>> On Sat, 2009-11-07 at 09:47 +0100, Martin Nagy wrote:
>>> Simo Sorce wrote:
if (tevent_req_is_error(req, &tstate, &err)) {
-retu
On Sat, 2009-11-07 at 13:22 -0500, Simo Sorce wrote:
> On Sat, 2009-11-07 at 09:47 +0100, Martin Nagy wrote:
> > Simo Sorce wrote:
> > > if (tevent_req_is_error(req, &tstate, &err)) {
> > > -return -1;
> > > +if (err) return err;
> > > +return EIO;
> > > }
> >
> >
On Sat, 2009-11-07 at 09:47 +0100, Martin Nagy wrote:
> Simo Sorce wrote:
> > if (tevent_req_is_error(req, &tstate, &err)) {
> > -return -1;
> > +if (err) return err;
> > +return EIO;
> > }
>
> Nack, err is not initialized here. I would recommend initializing it t
On Fri, 2009-11-06 at 21:37 -0500, Dmitri Pal wrote:
> Martin Nagy wrote:
> > Simo Sorce wrote:
> >
> >> This patch adds some cleanups and fixes coding style deviations.
> >> There are some more in the resolve code.
> >>
> >
> > You added braces to if constructs. I was under the impression
Simo Sorce wrote:
> if (tevent_req_is_error(req, &tstate, &err)) {
> -return -1;
> +if (err) return err;
> +return EIO;
> }
Nack, err is not initialized here. I would recommend initializing it to
EIO and replace return -1 with return err.
Martin
_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/09/2009 08:36 AM, Simo Sorce wrote:
> On Wed, 2009-09-09 at 14:19 +0200, Sumit Bose wrote:
>> Hi,
>>
>> I think the LDAP provider should link agains a LDAP library. So far it
>> only worked, because sssd_be exports all symbols and links against
>
On Wed, 2009-09-09 at 14:19 +0200, Sumit Bose wrote:
> Hi,
>
> I think the LDAP provider should link agains a LDAP library. So far it
> only worked, because sssd_be exports all symbols and links against
> libldb which links against libldap.
Absolutely, full ack!
Simo.
--
Simo Sorce * Red Hat,
Hi,
I think the LDAP provider should link agains a LDAP library. So far it
only worked, because sssd_be exports all symbols and links against
libldb which links against libldap.
bye,
Sumit
>From 911e1f245e00b95621d1d21e43c688e8973ceb12 Mon Sep 17 00:00:00 2001
From: sbose
Date: Wed, 9 Sep 2009
