Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-19 Thread Jakub Hrozek
On Tue, Mar 19, 2013 at 12:47:43PM +0100, Jakub Hrozek wrote: > On Sat, Mar 09, 2013 at 06:15:48PM -0500, Simo Sorce wrote: > > On Tue, 2013-03-05 at 18:57 +0100, Jakub Hrozek wrote: > > > On Tue, Mar 05, 2013 at 06:46:00PM +0100, Jakub Hrozek wrote: > > > > It seems that at least some error codes

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-19 Thread Jakub Hrozek
On Sat, Mar 09, 2013 at 06:15:48PM -0500, Simo Sorce wrote: > On Tue, 2013-03-05 at 18:57 +0100, Jakub Hrozek wrote: > > On Tue, Mar 05, 2013 at 06:46:00PM +0100, Jakub Hrozek wrote: > > > It seems that at least some error codes are mishandled. When I attempt > > > to auth with a bad password, SSSD

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-09 Thread Simo Sorce
On Tue, 2013-03-05 at 18:57 +0100, Jakub Hrozek wrote: > On Tue, Mar 05, 2013 at 06:46:00PM +0100, Jakub Hrozek wrote: > > It seems that at least some error codes are mishandled. When I attempt > > to auth with a bad password, SSSD returns System Error. This is not what > > we want, for some displa

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-05 Thread Jakub Hrozek
On Tue, Mar 05, 2013 at 06:46:00PM +0100, Jakub Hrozek wrote: > It seems that at least some error codes are mishandled. When I attempt > to auth with a bad password, SSSD returns System Error. This is not what > we want, for some display managers (xdm and I thin even kdm) the System > Error retval

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-05 Thread Jakub Hrozek
On Tue, Mar 05, 2013 at 05:11:29PM +0100, Pavel Březina wrote: > On 03/04/2013 07:34 PM, Simo Sorce wrote: > >On Mon, 2013-03-04 at 13:29 -0500, Simo Sorce wrote: > >>On Mon, 2013-03-04 at 13:10 +0100, Pavel Březina wrote: > >>>On 02/28/2013 12:29 AM, Simo Sorce wrote: > This patch removes yet

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-05 Thread Pavel Březina
On 03/04/2013 07:34 PM, Simo Sorce wrote: On Mon, 2013-03-04 at 13:29 -0500, Simo Sorce wrote: On Mon, 2013-03-04 at 13:10 +0100, Pavel Březina wrote: On 02/28/2013 12:29 AM, Simo Sorce wrote: This patch removes yet another set of custom and parallel error codes specified in the sdap_result en

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-04 Thread Simo Sorce
On Mon, 2013-03-04 at 13:29 -0500, Simo Sorce wrote: > On Mon, 2013-03-04 at 13:10 +0100, Pavel Březina wrote: > > On 02/28/2013 12:29 AM, Simo Sorce wrote: > > > This patch removes yet another set of custom and parallel error codes > > > specified in the sdap_result enumeration, and instead uses t

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-04 Thread Simo Sorce
On Mon, 2013-03-04 at 13:10 +0100, Pavel Březina wrote: > On 02/28/2013 12:29 AM, Simo Sorce wrote: > > This patch removes yet another set of custom and parallel error codes > > specified in the sdap_result enumeration, and instead uses the new > > unified error codes. > > > > This is to be applied

Re: [SSSD] [PATCH] Convert ldap_auth to new error codes

2013-03-04 Thread Pavel Březina
On 02/28/2013 12:29 AM, Simo Sorce wrote: This patch removes yet another set of custom and parallel error codes specified in the sdap_result enumeration, and instead uses the new unified error codes. This is to be applied on top of the previous patchset that adds SSSD specific error codes. I ha

[SSSD] [PATCH] Convert ldap_auth to new error codes

2013-02-27 Thread Simo Sorce
This patch removes yet another set of custom and parallel error codes specified in the sdap_result enumeration, and instead uses the new unified error codes. This is to be applied on top of the previous patchset that adds SSSD specific error codes. I have done minimal testing with my IPA install