Re: [SSSD] [PATCH] DB: Don't add empty ranges

2013-06-09 Thread Jakub Hrozek
On Tue, Jun 04, 2013 at 05:54:34PM +0200, Ondrej Kos wrote: On 06/04/2013 05:24 PM, Sumit Bose wrote: if an idrange has both of these set it is invalid as well, can you add a condition for this, too? bye, Sumit After off-list discussion with Sumit, here's new patch. Ondra Ack

Re: [SSSD] [PATCH] DB: Don't add empty ranges

2013-06-09 Thread Jakub Hrozek
On Sun, Jun 09, 2013 at 01:49:07PM +0200, Jakub Hrozek wrote: On Tue, Jun 04, 2013 at 05:54:34PM +0200, Ondrej Kos wrote: On 06/04/2013 05:24 PM, Sumit Bose wrote: if an idrange has both of these set it is invalid as well, can you add a condition for this, too? bye, Sumit After

[SSSD] [PATCH] DB: Don't add empty ranges

2013-06-04 Thread Ondrej Kos
Hi, Attached patch adresses issue https://fedorahosted.org/sssd/ticket/1816 I thought about ignoring these right after fetching from ldap, but the solution to just ignore the range while updating sysdb seems more appropriate, than going through whole range list. Ondra -- Ondrej Kos

Re: [SSSD] [PATCH] DB: Don't add empty ranges

2013-06-04 Thread Sumit Bose
On Tue, Jun 04, 2013 at 04:11:51PM +0200, Ondrej Kos wrote: Hi, Attached patch adresses issue https://fedorahosted.org/sssd/ticket/1816 I thought about ignoring these right after fetching from ldap, but the solution to just ignore the range while updating sysdb seems more appropriate,