Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-10 Thread Jakub Hrozek
On Mon, Apr 08, 2013 at 04:51:47PM +0200, Jakub Hrozek wrote: > There is quite some new functionality in this patchset that would be > great to have covered by unit-tests. I realize we need to finish the > code first and foremost, so maybe we could file tickets (trivial or > minor) and fix them in

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-10 Thread Jakub Hrozek
On Wed, Apr 10, 2013 at 03:33:37PM +0200, Jakub Hrozek wrote: > Simple SRV testing also passed with this round of patches. > > All patches are acked now. Pushed all patches to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https:/

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-10 Thread Jakub Hrozek
On Wed, Apr 10, 2013 at 02:22:26PM +0200, Pavel Březina wrote: > On 04/10/2013 01:28 PM, Jakub Hrozek wrote: > >On Tue, Apr 09, 2013 at 02:35:24PM +0200, Pavel Březina wrote: > >Patch 0001: resolv: add resolv_get_domain request to resolv utils > >Mostly OK, can you just explain this part of

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-10 Thread Jakub Hrozek
On Tue, Apr 09, 2013 at 02:35:24PM +0200, Pavel Březina wrote: > >>>Patch 0001: resolv: add resolv_get_domain request to resolv utils > >>>Mostly OK, can you just explain this part of the code? > >>> > >>>152 dns_domain = talloc_strdup(state, dns_domain); > >>>153 if (dns_domain == NULL) {

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-08 Thread Jakub Hrozek
On Mon, Apr 08, 2013 at 05:05:11PM -0400, Pavel Brezina wrote: > > > - Original Message - > > From: "Jakub Hrozek" > > To: sssd-devel@lists.fedorahosted.org > > Sent: Monday, April 8, 2013 10:38:47 PM > > Subject: Re: [SSSD] [PATCH] DNS

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-08 Thread Pavel Brezina
- Original Message - > From: "Jakub Hrozek" > To: sssd-devel@lists.fedorahosted.org > Sent: Monday, April 8, 2013 10:38:47 PM > Subject: Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup > plugin > > On Mon, Apr 08, 2013 at 04:51:47PM +0

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-08 Thread Jakub Hrozek
On Mon, Apr 08, 2013 at 10:38:47PM +0200, Jakub Hrozek wrote: > On Mon, Apr 08, 2013 at 04:51:47PM +0200, Jakub Hrozek wrote: > > On Mon, Apr 08, 2013 at 11:55:15AM +0200, Pavel Březina wrote: > > > On 04/05/2013 01:43 PM, Pavel Březina wrote: > > > >On 04/05/2013 12:41 PM, Pavel Březina wrote: > >

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-08 Thread Jakub Hrozek
On Mon, Apr 08, 2013 at 04:51:47PM +0200, Jakub Hrozek wrote: > On Mon, Apr 08, 2013 at 11:55:15AM +0200, Pavel Březina wrote: > > On 04/05/2013 01:43 PM, Pavel Březina wrote: > > >On 04/05/2013 12:41 PM, Pavel Březina wrote: > > >>On 04/03/2013 11:48 AM, Pavel Březina wrote: > > >>>On 04/02/2013 0

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-08 Thread Jakub Hrozek
On Mon, Apr 08, 2013 at 11:55:15AM +0200, Pavel Březina wrote: > On 04/05/2013 01:43 PM, Pavel Březina wrote: > >On 04/05/2013 12:41 PM, Pavel Březina wrote: > >>On 04/03/2013 11:48 AM, Pavel Březina wrote: > >>>On 04/02/2013 03:55 PM, Pavel Březina wrote: > On 03/27/2013 03:00 PM, Jakub Hrozek

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-08 Thread Jakub Hrozek
On Mon, Apr 08, 2013 at 11:55:15AM +0200, Pavel Březina wrote: > On 04/05/2013 01:43 PM, Pavel Březina wrote: > >On 04/05/2013 12:41 PM, Pavel Březina wrote: > >>On 04/03/2013 11:48 AM, Pavel Březina wrote: > >>>On 04/02/2013 03:55 PM, Pavel Březina wrote: > On 03/27/2013 03:00 PM, Jakub Hrozek

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-05 Thread Jakub Hrozek
On Wed, Apr 03, 2013 at 01:26:12PM +0200, Pavel Březina wrote: > >>We can also use it to initialize sdap_id_ctx instead of calling > >>sssm_ipa_id_init from other places. > > Given it more thoughts I don't think we should go this way. I like the > sssm_ipa_init() concept though and we should proba

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-04-03 Thread Pavel Březina
On 03/25/2013 05:18 PM, Jakub Hrozek wrote: On Fri, Mar 22, 2013 at 02:47:31PM +0100, Pavel Březina wrote: Hi, this patchset takes the current SRV lookup code and converts it into a plugin. Next waves will add custom plugin for IPA and AD. Patch 1: Introduce new plugin interface. Patch 2: Firs

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-03-27 Thread Jakub Hrozek
On Wed, Mar 27, 2013 at 11:22:49AM +0100, Pavel Březina wrote: > Later, we can place the plugin architecture inside a module that knows > about SSSD and is placed above resolver. You said you want to decouple > fail over to fail over -> cache -> resolver. This is nice idea. > > The plugin architec

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-03-27 Thread Pavel Březina
On 03/25/2013 05:18 PM, Jakub Hrozek wrote: +static void resolve_srv_step1_done(struct tevent_req *subreq); Ugh, step1 is not the greatest name :) Actually, this is suggested by tevent documentation :-) ___ sssd-devel mailing list sssd-devel@lists.

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-03-27 Thread Pavel Březina
On 03/27/2013 09:57 AM, Jakub Hrozek wrote: On Mon, Mar 25, 2013 at 05:18:27PM +0100, Jakub Hrozek wrote: On Fri, Mar 22, 2013 at 02:47:31PM +0100, Pavel Březina wrote: Hi, this patchset takes the current SRV lookup code and converts it into a plugin. Next waves will add custom plugin for IPA a

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-03-27 Thread Jakub Hrozek
On Mon, Mar 25, 2013 at 05:18:27PM +0100, Jakub Hrozek wrote: > On Fri, Mar 22, 2013 at 02:47:31PM +0100, Pavel Březina wrote: > > Hi, > > this patchset takes the current SRV lookup code and converts it into a > > plugin. Next waves will add custom plugin for IPA and AD. > > > > Patch 1: > > Intro

Re: [SSSD] [PATCH] DNS site support 1st wave - generic SRV lookup plugin

2013-03-25 Thread Jakub Hrozek
On Fri, Mar 22, 2013 at 02:47:31PM +0100, Pavel Březina wrote: > Hi, > this patchset takes the current SRV lookup code and converts it into a > plugin. Next waves will add custom plugin for IPA and AD. > > Patch 1: > Introduce new plugin interface. > > Patch 2: > First SRV lookup plugin. > > Pat